RFR: 8353614: JFR: jfr print --exact
Could I have a review of an enhancement that adds a command-line switch to `jfr print`, allowing timestamps, time spans, percentages, and byte values to be printed with full precision? Testing: tier1 + jdk/jdk/jfr Thank Erik ------------- Commit messages: - Fix help - Improve help - Fix formatting - Test update, bug fixes and man page - Initial Changes: https://git.openjdk.org/jdk/pull/24372/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=24372&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8353614 Stats: 185 lines in 4 files changed: 151 ins; 14 del; 20 mod Patch: https://git.openjdk.org/jdk/pull/24372.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/24372/head:pull/24372 PR: https://git.openjdk.org/jdk/pull/24372
On Wed, 2 Apr 2025 02:20:06 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of an enhancement that adds a command-line switch to `jfr print`, allowing timestamps, time spans, percentages, and byte values to be printed with full precision?
Testing: tier1 + jdk/jdk/jfr
Thank Erik
src/jdk.jfr/share/classes/jdk/jfr/internal/tool/Print.java line 76:
74: stream.println(" --json Print recording in JSON format"); 75: stream.println(); 76: stream.println(" --exact Pretty print numbers and timestamps in full precision.");
"with full precision." src/jdk.jfr/share/man/jfr.md line 124:
122: 123: <a id="print-option-exact">`--exact`</a> 124: : Pretty print numbers and timestamps in full precision.
"with full precision." ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24372#discussion_r2037069372 PR Review Comment: https://git.openjdk.org/jdk/pull/24372#discussion_r2037069969
Could I have a review of an enhancement that adds a command-line switch to `jfr print`, allowing timestamps, time spans, percentages, and byte values to be printed with full precision?
Testing: tier1 + jdk/jdk/jfr
Thank Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision: Update syntax ------------- Changes: - all: https://git.openjdk.org/jdk/pull/24372/files - new: https://git.openjdk.org/jdk/pull/24372/files/358d3273..728409f0 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=24372&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24372&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jdk/pull/24372.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/24372/head:pull/24372 PR: https://git.openjdk.org/jdk/pull/24372
On Thu, 10 Apr 2025 12:59:12 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of an enhancement that adds a command-line switch to `jfr print`, allowing timestamps, time spans, percentages, and byte values to be printed with full precision?
Testing: tier1 + jdk/jdk/jfr
Thank Erik
Erik Gahlin has updated the pull request incrementally with one additional commit since the last revision:
Update syntax
Marked as reviewed by mgronlun (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/24372#pullrequestreview-2756803000
On Wed, 2 Apr 2025 02:20:06 GMT, Erik Gahlin <egahlin@openjdk.org> wrote:
Could I have a review of an enhancement that adds a command-line switch to `jfr print`, allowing timestamps, time spans, percentages, and byte values to be printed with full precision?
Testing: tier1 + jdk/jdk/jfr
Thank Erik
This pull request has now been integrated. Changeset: 1d7138fe Author: Erik Gahlin <egahlin@openjdk.org> URL: https://git.openjdk.org/jdk/commit/1d7138fe021d64686ac59cddd1bc7c787c610aa9 Stats: 185 lines in 4 files changed: 151 ins; 14 del; 20 mod 8353614: JFR: jfr print --exact Reviewed-by: mgronlun ------------- PR: https://git.openjdk.org/jdk/pull/24372
participants (2)
-
Erik Gahlin
-
Markus Grönlund