April 2022 - jextract-dev

RFR: gradle buildscript improvements
by danieljarabek 05 May '22

05 May '22

Some improvements based on suggestions I made in an email [1]. Since then, the buildscript has a evolved quite a bit so some of my suggestions became obsolete or easier. This PR generally implements suggestions 2 and 3 from my email. Use Gradle incremental builds and up to date checks: - The `createJextractImage` and `createRuntimeImageForTest` tasks now use Gradle task input and ouputs to enable up to date checks. - The cmake tasks could theoretically also have inputs and outputs added, however cmake has incremental builds already and these tasks are only run when running jtreg and take little time compared to the test suite. I made a few minor style changes and fixed the comment on the jtreg task. I would like feedback on one change, which is making the assemble task automatically run the jextractapp task to build a jextract binary. Do you think it is best if the assemble task automatically runs the verify task as well? Or should things just be left as they are and require running verify or jextractapp manually? For some brief insight into Gradle lifecycle tasks for those not familiar: The build task should build and test everything so it depends on assemble and check. The assemble task is responsible for building everything, it depends on jar in a default configuration. The check task is responsible for running tests. For more information see the Gradle docs [2]. [1] - https://mail.openjdk.java.net/pipermail/panama-dev/2022-March/016665.html [2] - https://docs.gradle.org/current/userguide/base_plugin.html#sec:base_tasks ------------- Commit messages: - remove executable bit from gradlew - gradle buildscript improvements Changes: https://git.openjdk.java.net/jextract/pull/25/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=25&range=00 Stats: 30 lines in 1 file changed: 22 ins; 3 del; 5 mod Patch: https://git.openjdk.java.net/jextract/pull/25.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/25/head:pull/25 PR: https://git.openjdk.java.net/jextract/pull/25

3 11

RFR: Workaround CODETOOLS-7903174
by Jorn Vernee 29 Apr '22

29 Apr '22

This implements a workaround the crash in clang_reparseTranslationUnit. It enabled libclang's crash recovery on Windows, and if there's a crash in reparseTranslationUnit, we simply retry the call. This seems to be enough to workaround the crash for now. ------------- Commit messages: - Or -> And - Enable libclang crash recovery on Windows and use it to workaround the reparseTranslationUnit crash Changes: https://git.openjdk.java.net/jextract/pull/29/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=29&range=00 Stats: 9 lines in 2 files changed: 7 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/jextract/pull/29.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/29/head:pull/29 PR: https://git.openjdk.java.net/jextract/pull/29

2 2

RFR: Fix jextract GHA
by Maurizio Cimadamore 29 Apr '22

29 Apr '22

There are a couple of issue with the jextract GHA: * the action does not ignore pr/* branches, which seems to be the norm in JDK * the build is still referring to the old variable name `libclang_home` instead of `llvm_home` ------------- Commit messages: - Fix jextract GHA Changes: https://git.openjdk.java.net/jextract/pull/28/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=28&range=00 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jextract/pull/28.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/28/head:pull/28 PR: https://git.openjdk.java.net/jextract/pull/28

2 4

RFR: 7903173: jextract makefile build, test fails on macOS Monterey
by Athijegannathan Sundararajan 29 Apr '22

29 Apr '22

passing -L /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/lib via LDFLAGS. With that makefile build and test on macOS Monterey works fine. ------------- Commit messages: - 7903173: jextract makefile build, test fails on macOS Monterey Changes: https://git.openjdk.java.net/jextract/pull/27/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=27&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903173 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jextract/pull/27.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/27/head:pull/27 PR: https://git.openjdk.java.net/jextract/pull/27

2 2

RFR: 7903167: jextract makefiles still use joptsimple and generated module-info.java
by Athijegannathan Sundararajan 28 Apr '22

28 Apr '22

removed jopt dependency in makefiles as well. ------------- Commit messages: - 7903167: jextract makefiles still use joptsimple and generated module-info.java Changes: https://git.openjdk.java.net/jextract/pull/26/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=26&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903167 Stats: 35 lines in 1 file changed: 1 ins; 32 del; 2 mod Patch: https://git.openjdk.java.net/jextract/pull/26.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/26/head:pull/26 PR: https://git.openjdk.java.net/jextract/pull/26

2 2

RFR: Testing GHA
by Jorn Vernee 28 Apr '22

28 Apr '22

Add a basic actions workflow that runs the tests on pull requests ------------- Commit messages: - Use Oracle JDK - Back to repo hosted acitons - Update test.yml - Change actions to run in fork instead - Remove java check from test run - Typo - Add missing blank lines - Checkout specific jtreg tag - Working Impl - Remove whitespace - ... and 2 more: https://git.openjdk.java.net/jextract/compare/e6345e3a...c3d97f9a Changes: https://git.openjdk.java.net/jextract/pull/6/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=6&range=00 Stats: 64 lines in 1 file changed: 64 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/jextract/pull/6.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/6/head:pull/6 PR: https://git.openjdk.java.net/jextract/pull/6

2 13

RFR: Jextract build fails on Windows (take two)
by Maurizio Cimadamore 15 Apr '22

15 Apr '22

It seems like [1] did not address all the issues with Windows build. This patch makes the quoting of the jlink options explicit, and different between Windows and the other systems. I've verified on Windows (using powershell) and Ubuntu 20.04. Seems to work ok. [1] - https://github.com/openjdk/jextract/pull/24 ------------- Commit messages: - Initial push - README.md change for additional clang options (review suggestion) - argValue check for starting with '-' was in wrong place. - added test for -D option. - 7903164: cleanup jextract options Changes: https://git.openjdk.java.net/jextract/pull/24/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=24&range=00 Stats: 212 lines in 50 files changed: 124 ins; 9 del; 79 mod Patch: https://git.openjdk.java.net/jextract/pull/24.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/24/head:pull/24 PR: https://git.openjdk.java.net/jextract/pull/24

1 2

jextract build fails on windows
by Daniel Jarabek 15 Apr '22

15 Apr '22

Hi, After the changes in [1], the jextractapp gradle task fails on Windows with the error `Error: no value given for --add-options`. While I'm not exactly sure what is happening here, wrapping the escaped quotes at [2] in another level of escaping (so they look like `\\\"`) resolves the issue. After this fix, the task still works successfully on linux (and presumably mac). I would make a pull request to fix this but I am unsure if this is the best (or even a valid) solution and due to my OCA currently being under review, the merging would be blocked anyways. -DJ [1] - https://github.com/openjdk/jextract/pull/11 [2] - https://github.com/openjdk/jextract/blob/e184943f15e8df68c6122b8f7e49c0a910…

3 6

RFR: 7903164: cleanup jextract options
by Athijegannathan Sundararajan 15 Apr '22

15 Apr '22

* added -D option for preprocessor macros * renamed -d as --output * added support for ./compile_flags.txt to pass extra clang options to jextract * removed -C option ------------- Commit messages: - added test for -D option. - 7903164: cleanup jextract options Changes: https://git.openjdk.java.net/jextract/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903164 Stats: 207 lines in 50 files changed: 120 ins; 9 del; 78 mod Patch: https://git.openjdk.java.net/jextract/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/23/head:pull/23 PR: https://git.openjdk.java.net/jextract/pull/23

2 5

RFR: Re-arrange test directory structure
by Maurizio Cimadamore 14 Apr '22

14 Apr '22

Looking more at jextract tests, when we moved things in the standalone repo, few things went wrong. For instance, `TestSplit` cannot be executed right now, because it would need to be ran with some custom JDK properties. But since it's now part of a testng test structure, that is not possible. We'd need to move TestSplit in a different folder, but if we do that we have a problem, in that TestSplit depends on the TestUtils and JextractToolRunner helpers. This patch moves all the helper classes (JextractToolRunner, TestUtils, JextractAPITestBase) in the `testlib` package under the `test/lib` folder. Then, this patch restructures the test folder, as follows: * the `java` folder is renamed to `testng` - all testng test w/o jtreg header live here * the `generator` folder is moved under a new folder called `jtreg`; under this new folder we find tests with regular jtreg header With all this, we can now add a TEST.properties file under `test/testng` which contains a pointer to the lib folder that should be used by testng tests. And, we can finally move TestSplit under `test/jtreg`, and add the jtreg test header we need to be able to run this correctly. ------------- Commit messages: - Revamp test directory structure - Move JextractToolRunner and JextractApiTestBase in lib folder Changes: https://git.openjdk.java.net/jextract/pull/17/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=17&range=00 Stats: 977 lines in 175 files changed: 459 ins; 409 del; 109 mod Patch: https://git.openjdk.java.net/jextract/pull/17.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/17/head:pull/17 PR: https://git.openjdk.java.net/jextract/pull/17

2 5