June 2022 - jextract-dev

RFR: 7903209: Handle lifecycle of libclang abstractions more explicitly
by Maurizio Cimadamore 01 Jul '22

01 Jul '22

This patch clarifies the lifecycle of the entities generated by jextract. The main changes are two: 1. First, instead of "buffering" cursors in the `Cursor.children` method, so that a `Stream` can be returned, it instead accepts an action which will be executed for each visited cursor. This allows us to get rid of the buffering code, but at the same time it means that the downstream code has to be careful: any attempt to cache the cursor into a field, and access it _after_ the visitor has completed wil result in issues. 2. Secondly, it replaces uses of implicit session and implicit allocator almost everywhere. There are two main lifecycle entities: index and translation unit (there are others too, but these are the main ones). Translation units are created inside an index lifetime, whereas cursors and types are created inside the translation unit lifetime. This patch makes this organization clear, by adding a new type called `ClangDisposable`, an entity that has a session, and an associated arena allocator - and an `Owned` an entity that is owned by some `ClangDisposable` (and so it can use its arena to perform allocation). This scheme is relatively simple, but at the same time quite expressive, and helps keeping the complexity in check. As a result, most of the allocation now occurs in a confined scope, with clear lifetime boundaries. Any attemp to access e.g. a cursor after its translation unit is gone will result in an exception. I believe this can be quite useful to catch latent lifecycle issues in the code (I already fixed a few when working on this patch). ------------- Commit messages: - Fix whitespaces - Remove IMPLICIT_ALLOCATOR constant, so that we don't accidentally depend on it - Add copyright - Various cleanups - Add explicit management of libclang abstractions lifetime - Initial push Changes: https://git.openjdk.org/jextract/pull/48/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=48&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903209 Stats: 559 lines in 16 files changed: 181 ins; 123 del; 255 mod Patch: https://git.openjdk.org/jextract/pull/48.diff Fetch: git fetch https://git.openjdk.org/jextract pull/48/head:pull/48 PR: https://git.openjdk.org/jextract/pull/48

3 6

RFR: CODETOOLS-7903218: jextract test failure testng/org/openjdk/jextract/test/toolprovider/TestClassGeneration.java
by Athijegannathan Sundararajan 27 Jun '22

27 Jun '22

Fixed VH_bytes layout ------------- Commit messages: - CODETOOLS-7903218: jextract test failure testng/org/openjdk/jextract/test/toolprovider/TestClassGeneration.java Changes: https://git.openjdk.org/jextract/pull/49/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=49&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903218 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/49.diff Fetch: git fetch https://git.openjdk.org/jextract pull/49/head:pull/49 PR: https://git.openjdk.org/jextract/pull/49

2 2

RFR: 7903202: enable macOS CI checks
by Denys Makogon 08 Jun '22

08 Jun '22

This adjustment modifies the build config by introducing strategy matrix in order to enable builds from both Ubuntu and macOS. ------------- Commit messages: - renaming a job based on the given feedback - 7903202: enable macOS CI checks Changes: https://git.openjdk.java.net/jextract/pull/45/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=45&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903202 Stats: 34 lines in 1 file changed: 22 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/jextract/pull/45.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/45/head:pull/45 PR: https://git.openjdk.java.net/jextract/pull/45

4 8

RFR: 7903201: README.md referes old generated code pattern
by Athijegannathan Sundararajan 08 Jun '22

08 Jun '22

backporting applicable parts of the same fix from jdk19. * using latest generated code pattern in README.md * using module-version in --version output ------------- Commit messages: - 7903201: README.md referes old generated code pattern Changes: https://git.openjdk.java.net/jextract/pull/43/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=43&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903201 Stats: 11 lines in 2 files changed: 1 ins; 1 del; 9 mod Patch: https://git.openjdk.java.net/jextract/pull/43.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/43/head:pull/43 PR: https://git.openjdk.java.net/jextract/pull/43

2 2

RFR: makefile changes for mach5 build
by Athijegannathan Sundararajan 02 Jun '22

02 Jun '22

backporting the same changes from jdk19 branch ------------- Commit messages: - More makefile tweaks - Fixes needed for mach5 Changes: https://git.openjdk.java.net/jextract/pull/47/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=47&range=00 Stats: 185 lines in 4 files changed: 127 ins; 1 del; 57 mod Patch: https://git.openjdk.java.net/jextract/pull/47.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/47/head:pull/47 PR: https://git.openjdk.java.net/jextract/pull/47

2 2