July 2022 - jextract-dev

RFR: 7903239: ofAddress factory of function pointer type is wrong for struct returns
by Marko 02 Jan '24

02 Jan '24

When generating the lambda inside the `ofAddress` factory, it is missing the `SegmentAllocator` needed when the function returns a struct. This is [implemented for regular functions](https://github.com/openjdk/jextract/blob/0582eaf1b4cdba95f0ee8c2…, but not for function pointers. ------------- Commit messages: - 7903239: ofAddress factory of function pointer type is wrong for struct returns Changes: https://git.openjdk.org/jextract/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=58&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903239 Stats: 47 lines in 3 files changed: 44 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/58.diff Fetch: git fetch https://git.openjdk.org/jextract pull/58/head:pull/58 PR: https://git.openjdk.org/jextract/pull/58

3 11

BUG: function pointers inside a struct do not generate SegmentAllocators when needed
by Marko 02 Aug '22

02 Aug '22

Hello again! When trying to call a function pointer inside a struct which returns a MemorySegment, I receive the following error: ``` Exception in thread "main" java.lang.AssertionError: should not reach here at Foo$bar.lambda$ofAddress$0(Foo.java:34) at Main.main(Main.java:8) Caused by: java.lang.invoke.WrongMethodTypeException: expected (NativeSymbol,SegmentAllocator)MemorySegment but found (NativeSymbol)MemorySegment at java.base/java.lang.invoke.Invokers.newWrongMethodTypeException(Invokers.java:523) at java.base/java.lang.invoke.Invokers.checkExactType(Invokers.java:532) at Foo$bar.lambda$ofAddress$0(Foo.java:32) ... 1 more ``` I believe this is due to `FunctionalInterfaceBuilder#emitFunctionalFactoryForPointer` not checking to see if the returnType is a MemorySegment, as it does in `HeaderFileBuilder` for regular functions, see https://github.com/openjdk/jextract/blob/0582eaf1b4cdba95f0ee8c2480767433bb…. I began implementing a fix by copying this functionality over, however there is a bit of an issue I came across. When jextract emits the getter for the functional interface in a struct (StructBuilder), only the name of the interface is known. AFAIK, it does not know whether it needs a SegmentAllocator and cannot currently generate the correct code. I thought about adding another field to the method `emitFunctionalFactoryForPointer`, similar to fiName, like a boolean for whether a segment allocator is needed or not, however, I can't help but feel it is a bit hacky. I wonder what your opinions are on this. A repro can be found here: https://github.com/lost-illusi0n/jextract-func-ptr-seg-alloc-repro Just run the run script if you are on Linux. You will have to change the library output in the script if you are on another os.

3 9

Integrated: Remove spurious ^ char from tarball name
by Athijegannathan Sundararajan 28 Jul '22

28 Jul '22

backporting the same fix from jdk19 ------------- Commit messages: - Remove spurious ^ char from tarball name Changes: https://git.openjdk.org/jextract/pull/57/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=57&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/57.diff Fetch: git fetch https://git.openjdk.org/jextract pull/57/head:pull/57 PR: https://git.openjdk.org/jextract/pull/57

2 2

Jextract binaries now live!
by Maurizio Cimadamore 26 Jul '22

26 Jul '22

Hi, We're pleased to announce that the jextract binaries obtained from the standalone repo are available here: https://jdk.java.net/jextract/ It took quite a lot of effort to separate the jextract component from the panama repo, and I'd like to thank everyone involved in the process. Note: the build covers the Java 19 version of jextract. If you need a version of jextract that works with Java 18, you can either build the standalone jextract, using the Java 18 branch [1], or download the panama repo + jextract [2]. Maurizio [1] - https://github.com/openjdk/jextract/tree/jdk18 [2] - https://jdk.java.net/panama/

1 0

RFR: backport of 7903237: pointer to function struct member with the same name as struct crashes jextract
by Athijegannathan Sundararajan 19 Jul '22

19 Jul '22

backport of 7903237: pointer to function struct member with the same name as struct crashes jextract ------------- Commit messages: - backport of 7903237: pointer to function struct member with the same name as struct crashes jextract Changes: https://git.openjdk.org/jextract/pull/56/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=56&range=00 Stats: 52 lines in 3 files changed: 48 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jextract/pull/56.diff Fetch: git fetch https://git.openjdk.org/jextract pull/56/head:pull/56 PR: https://git.openjdk.org/jextract/pull/56

2 2

RFR: 7903237: pointer to function struct member with the same name as struct crashes jextract
by Athijegannathan Sundararajan 19 Jul '22

19 Jul '22

The lower case name was (wrongly) used to check hierarchical clash as well. Should be used only for local peers. ------------- Commit messages: - 7903237: pointer to function struct member with the same name as struct crashes jextract Changes: https://git.openjdk.org/jextract/pull/55/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=55&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903237 Stats: 52 lines in 3 files changed: 48 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jextract/pull/55.diff Fetch: git fetch https://git.openjdk.org/jextract pull/55/head:pull/55 PR: https://git.openjdk.org/jextract/pull/55

2 2

Integrated: Remove spurious `^` char from tarball name
by Maurizio Cimadamore 19 Jul '22

19 Jul '22

As the title says, this simple patch removes a spurious `^` char in the replacement text of a substitution applied during the tarball generation. Because of that, on Linux, the generated tarball has a topdir named `^jextract-<version>`. ------------- Commit messages: - Initial push Changes: https://git.openjdk.org/jextract/pull/54/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=54&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/54.diff Fetch: git fetch https://git.openjdk.org/jextract pull/54/head:pull/54 PR: https://git.openjdk.org/jextract/pull/54

2 2

BUG: function pointer as struct member does not compile if name is same as the struct
by Lost Illusion 19 Jul '22

19 Jul '22

Hello, I'm currently using jextract in tandem with Kotlin/Native's ability to generate shared libraries and header files. It works nicely until you add a class to the Kotlin code which generates a struct and a function pointer (the initializer for the class) as a struct member, with both having the same name. Here's a minimal header file with the same problem. test.h: ``` struct { int (*Foo)(); } Foo; ``` While this is valid for a header file, jextract has a problem processing it. Using the latest jextract on the jdk18 branch, and using the following command: `jextract test.h`. I get bombarded with 11 errors about resolving symbols and a duplicate class. Seems to be because a static class for the struct Foo is generated and an interface for the method Foo is also generated. I'm new to the project and not sure what the correct behavior should be in order to fix this issue.

3 2

RFR: updating libclang binding for jextract changes and llvm 13.0.0
by Athijegannathan Sundararajan 11 Jul '22

11 Jul '22

backport of same change from jdk19 master branch ------------- Commit messages: - updating libclang binding for jextract changes and llvm 13.0.0 Changes: https://git.openjdk.org/jextract/pull/53/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=53&range=00 Stats: 245 lines in 22 files changed: 6 ins; 7 del; 232 mod Patch: https://git.openjdk.org/jextract/pull/53.diff Fetch: git fetch https://git.openjdk.org/jextract pull/53/head:pull/53 PR: https://git.openjdk.org/jextract/pull/53

2 2

RFR: updating libclang binding for jetract changes and llvm 13.0.0
by Athijegannathan Sundararajan 08 Jul '22

08 Jul '22

regenerating LibClang binding for jextract changes and llvm 13.0.0 ------------- Commit messages: - updating libclang binding for jetract changes and llvm 13.0.0 Changes: https://git.openjdk.org/jextract/pull/52/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=52&range=00 Stats: 250 lines in 22 files changed: 6 ins; 9 del; 235 mod Patch: https://git.openjdk.org/jextract/pull/52.diff Fetch: git fetch https://git.openjdk.org/jextract pull/52/head:pull/52 PR: https://git.openjdk.org/jextract/pull/52

4 6