May 2023 - jextract-dev

RFR: 7903239: ofAddress factory of function pointer type is wrong for struct returns
by Marko 02 Jan '24

02 Jan '24

When generating the lambda inside the `ofAddress` factory, it is missing the `SegmentAllocator` needed when the function returns a struct. This is [implemented for regular functions](https://github.com/openjdk/jextract/blob/0582eaf1b4cdba95f0ee8c2…, but not for function pointers. ------------- Commit messages: - 7903239: ofAddress factory of function pointer type is wrong for struct returns Changes: https://git.openjdk.org/jextract/pull/58/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=58&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903239 Stats: 47 lines in 3 files changed: 44 ins; 2 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/58.diff Fetch: git fetch https://git.openjdk.org/jextract pull/58/head:pull/58 PR: https://git.openjdk.org/jextract/pull/58

3 11

RFR: Add path independence
by Per Minborg 02 Jan '24

02 Jan '24

This small PR incorporated feedback from the original PR: https://github.com/openjdk/jextract/pull/66 made after it was integrated. ------------- Commit messages: - Add path independence Changes: https://git.openjdk.org/jextract/pull/68/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=68&range=00 Stats: 10 lines in 4 files changed: 2 ins; 0 del; 8 mod Patch: https://git.openjdk.org/jextract/pull/68.diff Fetch: git fetch https://git.openjdk.org/jextract pull/68/head:pull/68 PR: https://git.openjdk.org/jextract/pull/68

5 7

RFR: Add Dockerfile, zero-dep reproducible builds
by Gavin Ray 02 Jan '24

02 Jan '24

As title says, adds a Dockerfile that will fetch all necessary deps and build `jextract` for you on Ubuntu 22.10 It would be nice if some official JDK organization could put this on their Dockerhub, so that users could just do: $ docker run --rm -it openjdk/jextract:latest I've pushed it to my personal Dockerhub, so if anyone would like to test it out, you can use the README directions but prepend `gavinray/` before the image name: $ echo "struct Foo { int a; long b; }; int use_foo(struct Foo foo);" >> sample.h $ docker run --rm -it -v ${PWD}:/tmp/jextract \ gavinray/jextract:latest \ -I /tmp/jextract \ --source \ -l libfoo \ --output /tmp/jextract/generated \ --target-package com.example \ ------------- Commit messages: - Add Dockerfile, zero-dep reproducible builds Changes: https://git.openjdk.org/jextract/pull/74/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=74&range=00 Stats: 75 lines in 2 files changed: 75 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jextract/pull/74.diff Fetch: git fetch https://git.openjdk.org/jextract pull/74/head:pull/74 PR: https://git.openjdk.org/jextract/pull/74

3 6

RFR: Add third-party sample list to README, populate with java-vulkan.
by Michael Ennen 02 Jan '24

02 Jan '24

I made a more complex example (1000 lines, mostly because setting up a boilerplate Vulkan program is super lengthy) of using jextract on Vulkan and Win32 APIs. I think it may be too lengthy and too much of a maintenance burden to commit to the `/samples` directory, so I thought maybe including a section on third-party samples would be better. If this is not something you want to entertain that's totally understandable, but thought I would put it out there a bigger sample that interfaces with a pretty complex API may be helpful to others. ------------- Commit messages: - Add third-party sample list to README, populate with java-vulkan. Changes: https://git.openjdk.org/jextract/pull/93/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=93&range=00 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/93.diff Fetch: git fetch https://git.openjdk.org/jextract pull/93/head:pull/93 PR: https://git.openjdk.org/jextract/pull/93

3 3

jextract C++ support
by Rel 24 Sep '23

24 Sep '23

Hi, I would like to know how to participate in C++ support for jextract. Watching Project Panama video (https://inside.java/2023/04/18/levelup-panama/) Paul mentioned that C++ is in the plans. Do we have someone working on it already so I can syncup on what is the plan and where I can help? In particular: - will it be part of jextract or may be jextract++? - will it use clang or something else? if clang then which interface https://clang.llvm.org/docs/Tooling.html There are many things to be done for C++ support but if I pick the most basic like symbols, in C++ they are mangled so current jextract linking logic will need to be changed. Do you think modifying NameMangler to store those mangled C++ symbols will be the right approach? Regards,

4 15

RFR: 7903481: Jextract doesn't enforce group layout alignment correctly in some cases
by Maurizio Cimadamore 30 May '23

30 May '23

This patch overhauls the treatment of pragma packs directives. The current logic tries to detect fields occurring at misaligned offsets, and relaxes alignment constraints for these fields. However, in cases like this: #pragma pack(push, 1) struct A { long long a; int b; } Each field is correctly aligned. But the struct size (12) is not a multiple of its natural alignment (8). As a result, we run into issues when building a sequence layout out of this struct, because of the eager checks added to the layout API. This patch fixes support for packed structs "the right way", that is, by asking clang the struct/union alignment, and then making sure that any field is aligned accordingly before the group layout is created. ------------- Commit messages: - Initial push Changes: https://git.openjdk.org/jextract/pull/121/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=121&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903481 Stats: 105 lines in 9 files changed: 79 ins; 6 del; 20 mod Patch: https://git.openjdk.org/jextract/pull/121.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/121/head:pull/121 PR: https://git.openjdk.org/jextract/pull/121

2 3

RFR: 7903475: Jextract should use new byte-based layout methods
by Maurizio Cimadamore 30 May '23

30 May '23

This PR tweaks jextract to work with the API changes in the layout API introduced in https://github.com/openjdk/jdk/pull/14013. ------------- Commit messages: - Initial push Changes: https://git.openjdk.org/jextract/pull/120/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=120&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903475 Stats: 97 lines in 28 files changed: 3 ins; 0 del; 94 mod Patch: https://git.openjdk.org/jextract/pull/120.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/120/head:pull/120 PR: https://git.openjdk.org/jextract/pull/120

2 3

GPL license
by Shane Pearlman 08 May '23

08 May '23

What’s the reasoning for licensing a tool like this under the GPLv2? Code generators often need to be modified or adapted for large bindings projects, and the classes in org.openjdk.jextract.impl and org.openjdk.jextract.clang could be quite useful as a starting point. Under the current license, however, I will probably have to roll my own. Even the code generation template classes are under GPLv2, which is enough to prevent me from using jextract generated bindings in my non-GPL projects. Maybe someone’s reading of the license is that it is permissible, but is the uncertainty really necessary? That said, I am excited for the Panama project to deliver what looks to be a very well designed solution to a major, decade-long problem with Java. —Shane

3 6

RFR: 7903463: jextract generates empty padding layouts
by Maurizio Cimadamore 02 May '23

02 May '23

This simple patch fixes a bug where jextract would generate a zero-sized padding layout when handling bitfields. This behavior causes a test failure when running against JDK 21. ------------- Commit messages: - Fix failing test due to zero-size padding layout. Changes: https://git.openjdk.org/jextract/pull/119/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=119&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903463 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/119.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/119/head:pull/119 PR: https://git.openjdk.org/jextract/pull/119

2 2