June 2024 - jextract-dev

RFR: 7903758: jextract should avoid temporary file creation
by Athijegannathan Sundararajan 25 Jun '24

25 Jun '24

jextract creates a temporary file to support multiple headers and special header syntax <foo.h>. This patch avoids that temporary file creation by using clang's in-memory parsing API clang_createTranslationUnitFromSourceFile ------------- Commit messages: - trailing whitespace removed - 7903758: jextract should avoid temporary file creation Changes: https://git.openjdk.org/jextract/pull/251/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=251&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903758 Stats: 3378 lines in 13 files changed: 2466 ins; 66 del; 846 mod Patch: https://git.openjdk.org/jextract/pull/251.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/251/head:pull/251 PR: https://git.openjdk.org/jextract/pull/251

2 17

RFR: 7903758: jextract can avoid temporary file creation for single simple header case
by Athijegannathan Sundararajan 20 Jun '24

20 Jun '24

jextract creates a temporary file to support multiple headers and special header syntax <foo.h>. But, temporary file creation can be avoided for single, simple header file/path case. ------------- Commit messages: - 7903758: jextract can avoid temporary file creation for single simple header case Changes: https://git.openjdk.org/jextract/pull/250/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=250&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903758 Stats: 33 lines in 2 files changed: 25 ins; 5 del; 3 mod Patch: https://git.openjdk.org/jextract/pull/250.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/250/head:pull/250 PR: https://git.openjdk.org/jextract/pull/250

1 1

RFR: 7903755: multi header support and special syntax for header file
by Athijegannathan Sundararajan 20 Jun '24

20 Jun '24

jextract currently supports only one header file. If the user wants to extract more than one header file, s/he has to create a containing header that includes multiple headers and jextract the containing header. With the current change, jextract supports more than one header file in the command line. When multiple headers are specified in command line, --header-class-name option is mandatory and it is enforced. In addition to normal file names for header file names, a special syntax such as "<stdio.h>" is also supported. With this, user does not have to write long file name including directories such as /usr/include/stdio.h. jextract generates multiple headers by generating a temporary header file. If the command line argument is of the form "<stdio.h>" then jextract generates "#include <stdio.h>" in the auto-generated containing header. If the header specified in of the normal/existing form (say foo.h), then containing header will have #include "foo.h" line. ------------- Commit messages: - Merge pull request #1 from JornVernee/MultiHeaders_Windows - update sample scripts - add pwsh script - updated GUIDE.md - fixed tests for Windows. - 7903755: multi header support and special syntax for header file Changes: https://git.openjdk.org/jextract/pull/249/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=249&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903755 Stats: 230 lines in 35 files changed: 151 ins; 31 del; 48 mod Patch: https://git.openjdk.org/jextract/pull/249.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/249/head:pull/249 PR: https://git.openjdk.org/jextract/pull/249

4 16

RFR: 7903755: multi header support and special syntax for header file
by Athijegannathan Sundararajan 19 Jun '24

19 Jun '24

jextract currently supports only one header file. If the user wants to extract more than one header file, s/he has to create a containing header that includes multiple headers and jextract the containing header. With the current change, jextract supports more than one header file in the command line. When multiple headers are specified in command line, --header-class-name option is mandatory and it is enforced. In addition to normal file names for header file names, a special syntax such as "<stdio.h>" is also supported. With this, user does not have to write long file name including directories such as /usr/include/stdio.h. jextract generates multiple headers by generating a temporary header file. If the command line argument is of the form "<stdio.h>" then jextract generates "#include <stdio.h>" in the auto-generated containing header. If the header specified in of the normal/existing form (say foo.h), then containing header will have #include "foo.h" line. ------------- Commit messages: - 7903755: multi header support and special syntax for header file Changes: https://git.openjdk.org/jextract/pull/249/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=249&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903755 Stats: 142 lines in 22 files changed: 76 ins; 29 del; 37 mod Patch: https://git.openjdk.org/jextract/pull/249.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/249/head:pull/249 PR: https://git.openjdk.org/jextract/pull/249

2 6

RFR: Typo in word directory
by Brayan Munoz V. 12 Jun '24

12 Jun '24

This commit just fix a typo in the word directory. Please add the following to the description of the pull request: 1. A brief recap of the status quo, as it relates to the subject of the pull request. 2. A description of why the status quo is problematic. 3. A description of how this pull request addresses this issue. 4. If you ran into issues while making changes in the code that you had to work around, please mention these as well, as this helps reviewers understand the changes that have been made. For 1 and 2 it is also okay to refer to the JBS ticket, if that already contains a comprehensive problem description. Please test your pull request before submitting it by running `./gradlew jtreg`. If you're not able to test locally on your machine, please indicate this in the pull request description, and indicate which testing has been done instead (or indicate that no testing has been done). It is possible to run tests through Github actions if you enable them for your fork (this is free). Github actions can be enabled for your fork from the 'Actions' tab. The tests will then run automatically after the pull request has been created. ------------- Commit messages: - Typo in word directory Changes: https://git.openjdk.org/jextract/pull/240/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=240&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/240.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/240/head:pull/240 PR: https://git.openjdk.org/jextract/pull/240

2 2

RFR: Reference latest JEP of FFM API.
by Brayan Munoz V. 12 Jun '24

12 Jun '24

Let's reference the JEP 454 which is the latest for FFM API instead of the JEP 442 of the third preview. In the README.md the 454 is already being referenced. https://github.com/openjdk/jextract/blob/b4da3284d41863af47d4a36b5829849b27… Please add the following to the description of the pull request: 1. A brief recap of the status quo, as it relates to the subject of the pull request. 2. A description of why the status quo is problematic. 3. A description of how this pull request addresses this issue. 4. If you ran into issues while making changes in the code that you had to work around, please mention these as well, as this helps reviewers understand the changes that have been made. For 1 and 2 it is also okay to refer to the JBS ticket, if that already contains a comprehensive problem description. Please test your pull request before submitting it by running `./gradlew jtreg`. If you're not able to test locally on your machine, please indicate this in the pull request description, and indicate which testing has been done instead (or indicate that no testing has been done). It is possible to run tests through Github actions if you enable them for your fork (this is free). Github actions can be enabled for your fork from the 'Actions' tab. The tests will then run automatically after the pull request has been created. ------------- Commit messages: - Reference latest JEP of FFM API. Changes: https://git.openjdk.org/jextract/pull/243/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=243&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/243.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/243/head:pull/243 PR: https://git.openjdk.org/jextract/pull/243

3 4

RFR: 7903727: Remove the reliance on String Templates feature
by Nizar Benalla 05 Jun '24

05 Jun '24

This PR aims to replace the usage of string templates with `String::format`, since there will be no string template feature in JDK 23. I tried to keep similar indentation and convert them in-place, to make reviewing the changes easier. ------------- Commit messages: - convert string template usage to String::format Changes: https://git.openjdk.org/jextract/pull/244/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=244&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903727 Stats: 370 lines in 9 files changed: 62 ins; 4 del; 304 mod Patch: https://git.openjdk.org/jextract/pull/244.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/244/head:pull/244 PR: https://git.openjdk.org/jextract/pull/244

3 46