January 2025 - jextract-dev

RFR: 7903928: update build.gradle to use JDK 23
by Athijegannathan Sundararajan 19 Mar '25

19 Mar '25

We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d4… ) While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22". ------------- Commit messages: - 7903928: update build.gradle to use JDK 23 Changes: https://git.openjdk.org/jextract/pull/271/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=271&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903928 Stats: 8 lines in 1 file changed: 1 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jextract/pull/271.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/271/head:pull/271 PR: https://git.openjdk.org/jextract/pull/271

7 10

RFR: Gradle 8.11.1 update cleanups
by Jorn Vernee 13 Mar '25

13 Mar '25

Some things were missed as part of: https://github.com/openjdk/jextract/pull/264 - The action to validate the gradle wrapper accidentally uses a deprecated version - The readme was not updated. ------------- Commit messages: - update readme - use non-deprecated action to validate gradle wrapper Changes: https://git.openjdk.org/jextract/pull/272/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=272&range=00 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jextract/pull/272.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/272/head:pull/272 PR: https://git.openjdk.org/jextract/pull/272

3 4

Re: RFR: 7903731: Jextract should support macOS frameworks [v3]
by Nizar Benalla 03 Feb '25

03 Feb '25

> Read the JBS issue for more detail. > > This patch adds two new mac specific options, to make it easier to use frameworks and remove the need of a `compile_flags.txt` file. An exception is thrown if those options are used from an other platform, the error message is inspired from `jpackage` Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: use consistent spacing ------------- Changes: - all: https://git.openjdk.org/jextract/pull/268/files - new: https://git.openjdk.org/jextract/pull/268/files/aad02674..9ce83f36 Webrevs: - full: https://webrevs.openjdk.org/?repo=jextract&pr=268&range=02 - incr: https://webrevs.openjdk.org/?repo=jextract&pr=268&range=01-02 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.org/jextract/pull/268.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/268/head:pull/268 PR: https://git.openjdk.org/jextract/pull/268

4 11

Javadoc for API
by Nir Lisker 30 Jan '25

30 Jan '25

Hi, There are several public methods the JextractTool exposes. Please javadoc to these methods so tool users will know what they do and how to use them. Thanks, - Nir

2 6

Detailed version info
by Nir Lisker 28 Jan '25

28 Jan '25

Hi, The output of the --version parameter looks like this: jextract 22 JDK version 22+35-2369 LibClang version clang version 13.0.0 Is it possible to include a more detailed version of jextract, like the JDK does? e.g., the current build is Build 22-jextract+6-47. Also, is it possible to add a programmatic API to get the --version info such as a method on JextractTool? Java has a Runtime.Version class that is returned from Runtime#version. Maybe something like that is possible? Thanks, Nir

2 1

RFR: 7903928: update build.gradle to use JDK 23
by Nizar Benalla 22 Jan '25

22 Jan '25

We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d4…) build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22". The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/02091…. This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`. This PR has been obtained through a `git merge --squash` of #271. TIA ------------- Commit messages: - Updates based on review comment in pr/271 - jextract PR #271 Changes: https://git.openjdk.org/jextract/pull/275/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=275&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903928 Stats: 14 lines in 4 files changed: 2 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jextract/pull/275.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/275/head:pull/275 PR: https://git.openjdk.org/jextract/pull/275

4 12

RFR: 7903922: Update copyright year for jextract in files where it was missed
by Nizar Benalla 20 Jan '25

20 Jan '25

I have sampled a few files to manually check that this works as intended, I got the list of files changed in a certain year by running. git log --since="Jan 1" --name-only --pretty=format: | sort -u > 2024file.list git log --oneline --since="1/1/2023" --until="31/12/2023" --name-only --pretty=format: | sort -u > 2023file.list And then used a script to update the copyright year, I did a random sampling of files to check that it worked as intended. A few files had their original copyright year changed because I noticed they were added in 2024 instead. ------------- Commit messages: - Manually fix files that were created on 11/01/24 - Update (C) for 2024 - Update (C) for 2023 Changes: https://git.openjdk.org/jextract/pull/267/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=267&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903922 Stats: 66 lines in 66 files changed: 0 ins; 0 del; 66 mod Patch: https://git.openjdk.org/jextract/pull/267.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/267/head:pull/267 PR: https://git.openjdk.org/jextract/pull/267

4 21

RFR: 7903932: Make private static classes final and have a private constructor
by Nizar Benalla 20 Jan '25

20 Jan '25

Please review this patch to make static utility classes final with a private constructor, as they are not meant to be extended. This is a small refractor of the generated code. TIA ------------- Commit messages: - fix whitespace errors and add blank line - make private utility classes final with a private constructor Changes: https://git.openjdk.org/jextract/pull/274/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=274&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903932 Stats: 12 lines in 1 file changed: 9 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jextract/pull/274.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/274/head:pull/274 PR: https://git.openjdk.org/jextract/pull/274

4 6

RFR: 7903925: Only the main generated header class should be public
by Nizar Benalla 20 Jan '25

20 Jan '25

Please review this patch to make the different header classes jextract generates (e.g. foo_h, foo_h_1, foo_h_2, ...) into package-private classes, leaving the main header class (without prefixes) as the only public class. While reading the sources, I noticed what seems like small bug in `SourceFileBuilder` introduced in https://github.com/openjdk/jextract/commit/a699148238fad919390d67eeb73805e7… so I fixed it as part of this patch. TIA. ------------- Commit messages: - consider numbered header classes as part of the implementation Changes: https://git.openjdk.org/jextract/pull/273/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=273&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903925 Stats: 23 lines in 2 files changed: 8 ins; 0 del; 15 mod Patch: https://git.openjdk.org/jextract/pull/273.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/273/head:pull/273 PR: https://git.openjdk.org/jextract/pull/273

3 4

RFR: 7903923: Derive C_* layouts directly from the Linker
by Nizar Benalla 15 Jan '25

15 Jan '25

Depending on the platform, different `C_*` correspond to different `JAVA_*` types. We can get those values directly from the linker. This patch can allows us to have a common class for different platforms. Please review, and thanks in advance! ------------- Commit messages: - derive "C" types directly from the linker Changes: https://git.openjdk.org/jextract/pull/269/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=269&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903923 Stats: 12 lines in 1 file changed: 0 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jextract/pull/269.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/269/head:pull/269 PR: https://git.openjdk.org/jextract/pull/269

4 17