April 2025 - jextract-dev

RFR: 7903933: Move sharable items from different generations to a common file
by Nizar Benalla 08 May '25

08 May '25

Please review this patch to move the `C_*` layouts and the static utility methods into separate classes: `LayoutUtils.java` and `FFMUtils.java`, respectively. - The names could later be personalized through a JSON configuration. - We can use static imports if the `-t` option is no used and the files are generated into the default package, in that case we use the classname to call the static methods or use the `C_*` constants. Some tests had to be modified slightly, either by adding new static imports or replacing classnames. ------------- Commit messages: - move sharable items to a common class Changes: https://git.openjdk.org/jextract/pull/278/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=278&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903933 Stats: 411 lines in 21 files changed: 233 ins; 106 del; 72 mod Patch: https://git.openjdk.org/jextract/pull/278.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/278/head:pull/278 PR: https://git.openjdk.org/jextract/pull/278

4 35

RFR: 7903877: jextract exception handling in downcall wrappers
by Nizar Benalla 29 Apr '25

29 Apr '25

Can I please get a review for this patch to improve the exception handling in downcall wrappers, if the exception is reachable then throwing an exception is better than catching an exception and turning them into an `AssertionError`. TIA ------------- Commit messages: - improve downcall wrapper exception handling Changes: https://git.openjdk.org/jextract/pull/282/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=282&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903877 Stats: 124 lines in 5 files changed: 120 ins; 0 del; 4 mod Patch: https://git.openjdk.org/jextract/pull/282.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/282/head:pull/282 PR: https://git.openjdk.org/jextract/pull/282

4 7

RFR: 7903984: Inline upcallHandle method to reduce shared code across multiple generations
by Nizar Benalla 11 Apr '25

11 Apr '25

Please review this patch to inline the upcallHandle method, reducing the amount of shared items across multiple jextract generations. TIA ------------- Commit messages: - remove whitespace - inline method Changes: https://git.openjdk.org/jextract/pull/279/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=279&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903984 Stats: 18 lines in 2 files changed: 8 ins; 8 del; 2 mod Patch: https://git.openjdk.org/jextract/pull/279.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/279/head:pull/279 PR: https://git.openjdk.org/jextract/pull/279

3 8

RFR: 7903983: Remove redundant findOrThrow method
by Nizar Benalla 03 Apr '25

03 Apr '25

`SymbolLookup::FindOrThrow` was introduced in JDK 23, making this method in the generated code redundant: static MemorySegment findOrThrow(String symbol) { return SYMBOL_LOOKUP.findOrThrow(symbol); } The generated method should have been dropped in https://github.com/openjdk/jextract/commit/a53f5c05e3ee2cca057cadb78b2e381c… but I didn't cleanup all uses of it. A small additional cleanup in PR is that the newly added option for framworks now uses `--` rather than `-` TIA ------------- Commit messages: - remove rendundant method - longer cmd option should use -- rather than - Changes: https://git.openjdk.org/jextract/pull/280/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=280&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903983 Stats: 27 lines in 5 files changed: 3 ins; 4 del; 20 mod Patch: https://git.openjdk.org/jextract/pull/280.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/280/head:pull/280 PR: https://git.openjdk.org/jextract/pull/280

3 3