jextract-dev

Download

jextract-dev@openjdk.org

May 2025

4 participants
2 discussions

RFR: 7903933: Move sharable items from different generations to a common file
by Nizar Benalla 08 May '25

08 May '25

Please review this patch to move the `C_*` layouts and the static utility methods into separate classes: `LayoutUtils.java` and `FFMUtils.java`, respectively. - The names could later be personalized through a JSON configuration. - We can use static imports if the `-t` option is no used and the files are generated into the default package, in that case we use the classname to call the static methods or use the `C_*` constants. Some tests had to be modified slightly, either by adding new static imports or replacing classnames. ------------- Commit messages: - move sharable items to a common class Changes: https://git.openjdk.org/jextract/pull/278/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=278&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903933 Stats: 411 lines in 21 files changed: 233 ins; 106 del; 72 mod Patch: https://git.openjdk.org/jextract/pull/278.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/278/head:pull/278 PR: https://git.openjdk.org/jextract/pull/278

4 35

git: openjdk/jextract: 7903933: Move sharable items from different generations to a common file
by Jorn Vernee 08 May '25

08 May '25

Changeset: ab6b30fd Branch: master Author: Nizar Benalla <nbenalla(a)openjdk.org> Committer: Jorn Vernee <jvernee(a)openjdk.org> Date: 2025-05-08 15:12:44 +0000 URL: https://git.openjdk.org/jextract/commit/ab6b30fd189e33a52d366846202f2e9b9b2… 7903933: Move sharable items from different generations to a common file Reviewed-by: mcimadamore, jvernee ! doc/GUIDE.md ! src/main/java/org/openjdk/jextract/JextractTool.java ! src/main/java/org/openjdk/jextract/impl/ClassSourceBuilder.java ! src/main/java/org/openjdk/jextract/impl/FunctionalInterfaceBuilder.java ! src/main/java/org/openjdk/jextract/impl/HeaderFileBuilder.java ! src/main/java/org/openjdk/jextract/impl/Options.java ! src/main/java/org/openjdk/jextract/impl/OutputFactory.java ! src/main/java/org/openjdk/jextract/impl/ToplevelBuilder.java ! src/main/resources/org/openjdk/jextract/impl/resources/Messages.properties + test/jtreg/generator/sharedSymbolsHeader/TestSharedSymbolsHeader.java = test/jtreg/generator/sharedSymbolsHeader/sharedSymbolsHeader.h ! test/testng/org/openjdk/jextract/test/toolprovider/TestClassGeneration.java

1 0