On Fri, 19 Jan 2024 16:51:02 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> wrote:
In my previous PR, I forgot to also make the method handle accessor (for native downcalls) `private`.
This was discovered when manually eyeballing at jextracted code for windows.h.
Marked as reviewed by jvernee (Committer). My comment got dropped it seems. What do you think about `MEMBER_MODS`? This is not something that is variable WRT the template text. I think I'd personally rather see the expanded code in the template, so that it's easier to see what is being generated. Though, theoretically, this makes it harder to bulk update all the access modifiers. But, that seems pretty rare any way? P.S. and, in this case I don't think the variable name `MEMBER_MODS` adds any clarity to the code. ------------- PR Review: https://git.openjdk.org/jextract/pull/188#pullrequestreview-1833739260 PR Comment: https://git.openjdk.org/jextract/pull/188#issuecomment-1901124954