RFR: Fix jextract GHA
There are a couple of issue with the jextract GHA: * the action does not ignore pr/* branches, which seems to be the norm in JDK * the build is still referring to the old variable name `libclang_home` instead of `llvm_home` ------------- Commit messages: - Fix jextract GHA Changes: https://git.openjdk.java.net/jextract/pull/28/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=28&range=00 Stats: 3 lines in 1 file changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/jextract/pull/28.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/28/head:pull/28 PR: https://git.openjdk.java.net/jextract/pull/28
On Fri, 29 Apr 2022 11:14:39 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> wrote:
the action does not ignore pr/* branches, which seems to be the norm in JDK
I left that one out since the jextract repo doesn't seem to have `pr/*` branches (as opposed to the jdk repo), so it didn't seem needed. But, it doesn't hurt to have that exclusion rule either I think. ------------- PR: https://git.openjdk.java.net/jextract/pull/28
There are a couple of issue with the jextract GHA: * the action does not ignore pr/* branches, which seems to be the norm in JDK * the build is still referring to the old variable name `libclang_home` instead of `llvm_home`
Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision: Fix broken `ifOnly` ------------- Changes: - all: https://git.openjdk.java.net/jextract/pull/28/files - new: https://git.openjdk.java.net/jextract/pull/28/files/32135042..f4e3c74d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jextract&pr=28&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jextract&pr=28&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/jextract/pull/28.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/28/head:pull/28 PR: https://git.openjdk.java.net/jextract/pull/28
On Fri, 29 Apr 2022 11:33:39 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> wrote:
There are a couple of issue with the jextract GHA: * the action does not ignore pr/* branches, which seems to be the norm in JDK * the build is still referring to the old variable name `libclang_home` instead of `llvm_home`
Maurizio Cimadamore has updated the pull request incrementally with one additional commit since the last revision:
Fix broken `ifOnly`
Marked as reviewed by jvernee (no project role). ------------- PR: https://git.openjdk.java.net/jextract/pull/28
On Fri, 29 Apr 2022 11:14:39 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> wrote:
There are a couple of issue with the jextract GHA: * the action does not ignore pr/* branches, which seems to be the norm in JDK * the build is still referring to the old variable name `libclang_home` instead of `llvm_home`
This pull request has now been integrated. Changeset: 2b29fa50 Author: Maurizio Cimadamore <mcimadamore@openjdk.org> URL: https://git.openjdk.java.net/jextract/commit/2b29fa50890eb7132308a19b4b8b124... Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod Fix jextract GHA Reviewed-by: jvernee ------------- PR: https://git.openjdk.java.net/jextract/pull/28
participants (2)
-
Jorn Vernee
-
Maurizio Cimadamore