RFR: 7903201: README.md referes to old API and old generated code pattern
* fixed README.md for new API usage and new generated code pattern * --version uses module version rather than java.version * fixed makefile --module-version to be 19 ------------- Commit messages: - 7903201: README.md referes to old API and old generated code pattern Changes: https://git.openjdk.java.net/jextract/pull/42/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=42&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903201 Stats: 17 lines in 3 files changed: 1 ins; 2 del; 14 mod Patch: https://git.openjdk.java.net/jextract/pull/42.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/42/head:pull/42 PR: https://git.openjdk.java.net/jextract/pull/42
On Fri, 27 May 2022 07:17:35 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
* fixed README.md for new API usage and new generated code pattern * --version uses module version rather than java.version * fixed makefile --module-version to be 19
Looks good README.md line 97:
95: 96: ```java 97: static final FunctionDescriptor distance$FUNC = FunctionDescriptor.of(Constants$root.C_DOUBLE$LAYOUT,
Nothing changed here right? Just indent? ------------- Marked as reviewed by mcimadamore (Committer). PR: https://git.openjdk.java.net/jextract/pull/42
On Fri, 27 May 2022 08:07:23 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> wrote:
* fixed README.md for new API usage and new generated code pattern * --version uses module version rather than java.version * fixed makefile --module-version to be 19
README.md line 97:
95: 96: ```java 97: static final FunctionDescriptor distance$FUNC = FunctionDescriptor.of(Constants$root.C_DOUBLE$LAYOUT,
Nothing changed here right? Just indent?
Yes. I cut-pasted the new output from latest jextract. May have changed alignment in the process. ------------- PR: https://git.openjdk.java.net/jextract/pull/42
On Fri, 27 May 2022 07:17:35 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
* fixed README.md for new API usage and new generated code pattern * --version uses module version rather than java.version * fixed makefile --module-version to be 19
This pull request has now been integrated. Changeset: 244e42a7 Author: Athijegannathan Sundararajan <sundar@openjdk.org> URL: https://git.openjdk.java.net/jextract/commit/244e42a73abbd978201ec5fab20445d... Stats: 17 lines in 3 files changed: 1 ins; 2 del; 14 mod 7903201: README.md referes to old API and old generated code pattern Reviewed-by: mcimadamore ------------- PR: https://git.openjdk.java.net/jextract/pull/42
participants (2)
-
Athijegannathan Sundararajan
-
Maurizio Cimadamore