RFR: 7903928: update build.gradle to use JDK 23
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22". The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html). This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`. This PR has been obtained through a `git merge --squash` of #271. TIA ------------- Commit messages: - Updates based on review comment in pr/271 - jextract PR #271 Changes: https://git.openjdk.org/jextract/pull/275/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=275&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903928 Stats: 14 lines in 4 files changed: 2 ins; 0 del; 12 mod Patch: https://git.openjdk.org/jextract/pull/275.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/275/head:pull/275 PR: https://git.openjdk.org/jextract/pull/275
On Tue, 21 Jan 2025 18:53:33 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
README.md line 17:
15: ### Building 16: 17: `jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454), so a suitable [jdk 22+ distribution](https://jdk.java.net/23/) is also required.
This is the only change that wasn't based on review comments, I thought the download page should point to JDK 23 ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/275#discussion_r1924228123
On Tue, 21 Jan 2025 18:57:45 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
README.md line 17:
15: ### Building 16: 17: `jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454), so a suitable [jdk 22+ distribution](https://jdk.java.net/23/) is also required.
This is the only change that wasn't based on review comments, I thought the download page should point to JDK 23
The nominal text should refer to 23, now that gradle passes `--release 23` which is not supported by javac for 22. ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/275#discussion_r1924234713
On Tue, 21 Jan 2025 19:03:52 GMT, Chen Liang <liach@openjdk.org> wrote:
README.md line 17:
15: ### Building 16: 17: `jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454), so a suitable [jdk 22+ distribution](https://jdk.java.net/23/) is also required.
This is the only change that wasn't based on review comments, I thought the download page should point to JDK 23
The nominal text should refer to 23, now that gradle passes `--release 23` which is not supported by javac for 22.
Correct. jextract generated code uses JDK 23 specific API => jextract from master build can only be used with JDK 23+ ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/275#discussion_r1924679441
On Tue, 21 Jan 2025 19:03:52 GMT, Chen Liang <liach@openjdk.org> wrote:
README.md line 17:
15: ### Building 16: 17: `jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454), so a suitable [jdk 22+ distribution](https://jdk.java.net/23/) is also required.
This is the only change that wasn't based on review comments, I thought the download page should point to JDK 23
The nominal text should refer to 23, now that gradle passes `--release 23` which is not supported by javac for 22.
Yes, the jextract generated code uses JDK 23 specific API and hence jextract tests fail when jextract repo is built with JDK 22. We should stick using/mentioning JDK 23+ everywhere in the "master" branch. ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/275#discussion_r1924692840
On Tue, 21 Jan 2025 18:53:33 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
build.gradle line 63:
61: 62: compileJava { 63: options.release = 23
Same as above: with this set, users now must use JDK 23 or higher. ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/275#discussion_r1924235323
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision: - refer to JDK 23 - Merge remote-tracking branch 'upstream/master' into pull/271 - Updates based on review comment in pr/271 - jextract PR #271 ------------- Changes: - all: https://git.openjdk.org/jextract/pull/275/files - new: https://git.openjdk.org/jextract/pull/275/files/f0e4b1ab..703b3d8a Webrevs: - full: https://webrevs.openjdk.org/?repo=jextract&pr=275&range=01 - incr: https://webrevs.openjdk.org/?repo=jextract&pr=275&range=00-01 Stats: 103 lines in 70 files changed: 8 ins; 1 del; 94 mod Patch: https://git.openjdk.org/jextract/pull/275.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/275/head:pull/275 PR: https://git.openjdk.org/jextract/pull/275
On Tue, 21 Jan 2025 19:16:31 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- refer to JDK 23 - Merge remote-tracking branch 'upstream/master' into pull/271 - Updates based on review comment in pr/271 - jextract PR #271
README.md line 17:
15: ### Building 16: 17: `jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454), a suitable [jdk 23 or higher distribution](https://jdk.java.net/23/) is also required.
Suggestion: `jextract` depends on the [C libclang API](https://clang.llvm.org/doxygen/group__CINDEX.html). To build the jextract sources, the easiest option is to download LLVM binaries for your platform, which can be found [here](https://releases.llvm.org/download.html) (version 13.0.0 is recommended). Both the `jextract` tool and the bindings it generates depend heavily on the [Foreign Function & Memory API](https://openjdk.java.net/jeps/454). A suitable [JDK 23 or higher distribution](https://jdk.java.net/23/) is also required. nitpick ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/275#discussion_r1924648651
On Tue, 21 Jan 2025 19:16:31 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
Nizar Benalla has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
- refer to JDK 23 - Merge remote-tracking branch 'upstream/master' into pull/271 - Updates based on review comment in pr/271 - jextract PR #271
LGTM ------------- Marked as reviewed by sundar (Committer). PR Review: https://git.openjdk.org/jextract/pull/275#pullrequestreview-2566190927
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision: nit Co-authored-by: Chen Liang <liach@openjdk.org> ------------- Changes: - all: https://git.openjdk.org/jextract/pull/275/files - new: https://git.openjdk.org/jextract/pull/275/files/703b3d8a..259c417a Webrevs: - full: https://webrevs.openjdk.org/?repo=jextract&pr=275&range=02 - incr: https://webrevs.openjdk.org/?repo=jextract&pr=275&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/275.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/275/head:pull/275 PR: https://git.openjdk.org/jextract/pull/275
On Wed, 22 Jan 2025 11:33:26 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
nit
Co-authored-by: Chen Liang <liach@openjdk.org>
Thanks for the review Sundar, I committed a trivial change after it. ------------- PR Comment: https://git.openjdk.org/jextract/pull/275#issuecomment-2607036573
On Wed, 22 Jan 2025 11:33:26 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
Nizar Benalla has updated the pull request incrementally with one additional commit since the last revision:
nit
Co-authored-by: Chen Liang <liach@openjdk.org>
@nizarbenalla Your change (at version 259c417a54e752e80c570b0df8ea1d491f307184) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/jextract/pull/275#issuecomment-2607037408
On Tue, 21 Jan 2025 18:53:33 GMT, Nizar Benalla <nbenalla@openjdk.org> wrote:
We've updated native makefile to use JDK 23 (https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46...), build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
The mismatch has caused [some confusion](https://mail.openjdk.org/pipermail/panama-dev/2025-January/020915.html).
This patch to rename references to `jdk22_home` to `jdk_home`, the jextract version has now been bumped to `23`.
This PR has been obtained through a `git merge --squash` of #271.
TIA
This pull request has now been integrated. Changeset: 7ed79ecd Author: Nizar Benalla <nbenalla@openjdk.org> Committer: Jorn Vernee <jvernee@openjdk.org> URL: https://git.openjdk.org/jextract/commit/7ed79ecdf678db804f40b3494b6f1dafa760... Stats: 14 lines in 4 files changed: 2 ins; 0 del; 12 mod 7903928: update build.gradle to use JDK 23 Co-authored-by: Athijegannathan Sundararajan <sundar@openjdk.org> Reviewed-by: sundar ------------- PR: https://git.openjdk.org/jextract/pull/275
participants (4)
-
Athijegannathan Sundararajan
-
Chen Liang
-
duke
-
Nizar Benalla