RFR: 7903928: update build.gradle to use JDK 23
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... ) While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22". ------------- Commit messages: - 7903928: update build.gradle to use JDK 23 Changes: https://git.openjdk.org/jextract/pull/271/files Webrev: https://webrevs.openjdk.org/?repo=jextract&pr=271&range=00 Issue: https://bugs.openjdk.org/browse/CODETOOLS-7903928 Stats: 8 lines in 1 file changed: 1 ins; 0 del; 7 mod Patch: https://git.openjdk.org/jextract/pull/271.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/271/head:pull/271 PR: https://git.openjdk.org/jextract/pull/271
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... )
While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision: fixed jdk23_home in github test.yml. changed Python sample so that it does not fail with unsupported type _Float16 ------------- Changes: - all: https://git.openjdk.org/jextract/pull/271/files - new: https://git.openjdk.org/jextract/pull/271/files/d39ed3c7..d44a111c Webrevs: - full: https://webrevs.openjdk.org/?repo=jextract&pr=271&range=01 - incr: https://webrevs.openjdk.org/?repo=jextract&pr=271&range=00-01 Stats: 2 lines in 2 files changed: 1 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/271.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/271/head:pull/271 PR: https://git.openjdk.org/jextract/pull/271
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... )
While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision: missed jdk23_home in test line ------------- Changes: - all: https://git.openjdk.org/jextract/pull/271/files - new: https://git.openjdk.org/jextract/pull/271/files/d44a111c..309d83d3 Webrevs: - full: https://webrevs.openjdk.org/?repo=jextract&pr=271&range=02 - incr: https://webrevs.openjdk.org/?repo=jextract&pr=271&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.org/jextract/pull/271.diff Fetch: git fetch https://git.openjdk.org/jextract.git pull/271/head:pull/271 PR: https://git.openjdk.org/jextract/pull/271
On Thu, 9 Jan 2025 13:35:14 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... )
While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
missed jdk23_home in test line
Marked as reviewed by jvernee (Committer). ------------- PR Review: https://git.openjdk.org/jextract/pull/271#pullrequestreview-2540127886
On Thu, 9 Jan 2025 13:35:14 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... )
While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
missed jdk23_home in test line
build.gradle line 32:
30: 31: def llvm_home = project.property("llvm_home") 32: def jdk_home = project.property("jdk23_home")
We should rename this property simply to `jdk_home`. ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/271#discussion_r1909445824
On Thu, 9 Jan 2025 21:20:35 GMT, Chen Liang <liach@openjdk.org> wrote:
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
missed jdk23_home in test line
build.gradle line 32:
30: 31: def llvm_home = project.property("llvm_home") 32: def jdk_home = project.property("jdk23_home")
We should rename this property simply to `jdk_home`.
I agree. Especially now that we only have one "master" (tip) version. ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/271#discussion_r1916221595
On Wed, 15 Jan 2025 09:24:55 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> wrote:
build.gradle line 32:
30: 31: def llvm_home = project.property("llvm_home") 32: def jdk_home = project.property("jdk23_home")
We should rename this property simply to `jdk_home`.
I agree. Especially now that we only have one "master" (tip) version.
Gradle's jdk is set via JAVA_HOME. It is usual have gradle support for the latest JDK to come bit "late". If we call JDK needed for jextract to be "jdk_Home" and the one needed for gradle as "JAVA_HOME", we may be in a situation where jdk_home points latest JDK (say JDK 25) and JAVA_HOME points whatever then latest Gradle supports. Can we keep jextract use specific JDK version for its build/test as a separately distinctly named variable? ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/271#discussion_r1916256236
On Wed, 15 Jan 2025 09:48:30 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
I agree. Especially now that we only have one "master" (tip) version.
Gradle's jdk is set via JAVA_HOME. It is usual have gradle support for the latest JDK to come bit "late". If we call JDK needed for jextract to be "jdk_Home" and the one needed for gradle as "JAVA_HOME", we may be in a situation where jdk_home points latest JDK (say JDK 25) and JAVA_HOME points whatever then latest Gradle supports. Can we keep jextract use specific JDK version for its build/test as a separately distinctly named variable?
I think you can run gradle's Java compilation and the gradle tool with different JDKs; my previous strategy for running JMH through gradle was to define my local openjdk build as `org.gradle.java.home` project property, either set in gradle.properties or passed as `-Porg.gradle.java.home=xx` on command line. `JAVA_HOME` is used to launch the gradle tool, so it cannot be the local openjdk build, which uses a class file format too new for gradle to generate abstract method implementations. ------------- PR Review Comment: https://git.openjdk.org/jextract/pull/271#discussion_r1916876368
On Thu, 9 Jan 2025 13:35:14 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... )
While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
missed jdk23_home in test line
The `README.md` mentions `jdk22_home` as well and probably needs to be adjusted too. ------------- PR Comment: https://git.openjdk.org/jextract/pull/271#issuecomment-2581455821
On Thu, 9 Jan 2025 13:35:14 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... )
While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
missed jdk23_home in test line
This PR has been superseded by #275. Please continue the discussion and review there. ------------- PR Comment: https://git.openjdk.org/jextract/pull/271#issuecomment-2605509402
On Thu, 9 Jan 2025 06:54:02 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
We've updated native makefile to use JDK 23 ( https://github.com/openjdk/jextract/commit/0b89a462146940a2ec90e34eeb5df3d46... )
While build.gradle works & expects jdk 23, it still refers to JDK var as "jdk22_home" and passes --release to be 22. Also jextract version is "22".
This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.org/jextract/pull/271
participants (7)
-
Athijegannathan Sundararajan
-
Chen Liang
-
duke
-
Jorn Vernee
-
Marcono1234
-
Maurizio Cimadamore
-
Nizar Benalla