RFR: 7903164: cleanup jextract options
* added -D option for preprocessor macros * renamed -d as --output * added support for ./compile_flags.txt to pass extra clang options to jextract * removed -C option ------------- Commit messages: - added test for -D option. - 7903164: cleanup jextract options Changes: https://git.openjdk.java.net/jextract/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=jextract&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/CODETOOLS-7903164 Stats: 207 lines in 50 files changed: 120 ins; 9 del; 78 mod Patch: https://git.openjdk.java.net/jextract/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/23/head:pull/23 PR: https://git.openjdk.java.net/jextract/pull/23
* added -D option for preprocessor macros * renamed -d as --output * added support for ./compile_flags.txt to pass extra clang options to jextract * removed -C option
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision: argValue check for starting with '-' was in wrong place. ------------- Changes: - all: https://git.openjdk.java.net/jextract/pull/23/files - new: https://git.openjdk.java.net/jextract/pull/23/files/c430de91..eded0d1f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jextract&pr=23&range=01 - incr: https://webrevs.openjdk.java.net/?repo=jextract&pr=23&range=00-01 Stats: 10 lines in 1 file changed: 5 ins; 5 del; 0 mod Patch: https://git.openjdk.java.net/jextract/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/23/head:pull/23 PR: https://git.openjdk.java.net/jextract/pull/23
On Fri, 15 Apr 2022 11:46:46 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
* added -D option for preprocessor macros * renamed -d as --output * added support for ./compile_flags.txt to pass extra clang options to jextract * removed -C option
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
argValue check for starting with '-' was in wrong place.
Looks good - added a comment on the md file README.md line 134:
132: 133: If you want to pass extra options to clang compiler, you can create a file named _compile_flags.txt_ in the current directory. 134: That text file can contain clang compiler options one per each line.
Suggestion: #### Additional clang options Users can specify additional clang compiler options, by creating a file named `compile_flags.txt` in the current folder, as described [here](https://clang.llvm.org/docs/JSONCompilationDatabase.html#alternatives). ------------- Marked as reviewed by mcimadamore (Committer). PR: https://git.openjdk.java.net/jextract/pull/23
On Fri, 15 Apr 2022 11:56:03 GMT, Maurizio Cimadamore <mcimadamore@openjdk.org> wrote:
Athijegannathan Sundararajan has updated the pull request incrementally with one additional commit since the last revision:
argValue check for starting with '-' was in wrong place.
README.md line 134:
132: 133: If you want to pass extra options to clang compiler, you can create a file named _compile_flags.txt_ in the current directory. 134: That text file can contain clang compiler options one per each line.
Suggestion:
#### Additional clang options
Users can specify additional clang compiler options, by creating a file named `compile_flags.txt` in the current folder, as described [here](https://clang.llvm.org/docs/JSONCompilationDatabase.html#alternatives).
changed as suggested ------------- PR: https://git.openjdk.java.net/jextract/pull/23
* added -D option for preprocessor macros * renamed -d as --output * added support for ./compile_flags.txt to pass extra clang options to jextract * removed -C option
Athijegannathan Sundararajan has updated the pull request incrementally with two additional commits since the last revision: - deleted newline in README.md - README.md change for additional clang options (review suggestion) ------------- Changes: - all: https://git.openjdk.java.net/jextract/pull/23/files - new: https://git.openjdk.java.net/jextract/pull/23/files/eded0d1f..d3448912 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=jextract&pr=23&range=02 - incr: https://webrevs.openjdk.java.net/?repo=jextract&pr=23&range=01-02 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/jextract/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/jextract pull/23/head:pull/23 PR: https://git.openjdk.java.net/jextract/pull/23
On Thu, 14 Apr 2022 17:15:35 GMT, Athijegannathan Sundararajan <sundar@openjdk.org> wrote:
* added -D option for preprocessor macros * renamed -d as --output * added support for ./compile_flags.txt to pass extra clang options to jextract * removed -C option
This pull request has now been integrated. Changeset: 3cacab03 Author: Athijegannathan Sundararajan <sundar@openjdk.org> Committer: Maurizio Cimadamore <mcimadamore@openjdk.org> URL: https://git.openjdk.java.net/jextract/commit/3cacab03cb26f7dcd7fb72ce9f73bf4... Stats: 207 lines in 50 files changed: 120 ins; 9 del; 78 mod 7903164: cleanup jextract options Reviewed-by: mcimadamore ------------- PR: https://git.openjdk.java.net/jextract/pull/23
participants (2)
-
Athijegannathan Sundararajan
-
Maurizio Cimadamore