August 2023 - leyden-dev

Computed Constants API question
by - 02 Sep '23

02 Sep '23

Hello Per and Leyden subscribers, First, I am glad that we are finally adding an API that exposes one of core libraries' favorite feature, `@Stable`, to common users! For the API design, however, I have a request: Can we have a ComputedConstant factory that creates a List<V> in addition to one that creates a List<ComputedConstant<V>>? I think using the List<ComputedConstant<V>> is confusing. The example usages in the JEP [1] and in the API specification [2] are already wrong: we need an extra ConputedConstant.get() call to unwrap the ComputedConstant after List.get(index) call, which currently returns a computed constant than the actual value. The current List<ComputedConstant<V>> is to be kept in case users want fine-grained control over each constant's resolution failure, etc. and covers the new factory's functionality. But I believe the new factory will see wider usage: 1. None of the 2 old patterns in the "Motivation" section uses any of these exception handling or initialization state detection. 2. Returning a List<V> allows users to conveniently pass the list in usages instead of using streams or writing custom wrappers. A follow up to a previous request [3], I believe having a map (of type Map<K, V> instead of Map<K, ComputedConstant<V>>) would be feasible too. Finally, a side comment about the current OnDemandComputedConstantList: it computes ComputedConstant wrappers in addition to the actual constants on demand, which... seems a bit overkill, when ComputedConstant itself is already a lightweight wrapper of a heavy computation? Best, Chen Liang [1]: https://openjdk.org/jeps/8312611 "var kbd = lbl.labels.get(3);" [2]: https://cr.openjdk.org/~pminborg/computed-constant/api/java.base/java/lang/… "return PO2_CACHE.get(n);" [3]: https://mail.openjdk.org/pipermail/leyden-dev/2023-August/000277.html

6 15

git: openjdk/leyden: premain: 8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion
by duke 31 Aug '23

31 Aug '23

Changeset: d1b61107 Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-30 21:38:22 +0000 URL: https://git.openjdk.org/leyden/commit/d1b611071a8a0b57d6f193c6dd339f19e6df7… 8315431: ArchiveHeapWriter::get_filler_size_at() cannot handle buffer expansion ! src/hotspot/share/cds/archiveHeapWriter.cpp ! test/hotspot/jtreg/runtime/cds/CDSMapReader.java

1 0

git: openjdk/leyden: premain: removed unused SystemDictionaryShared::init_dumptime_info(Method* m)
by duke 31 Aug '23

31 Aug '23

Changeset: 9b92dfc2 Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-30 21:04:58 +0000 URL: https://git.openjdk.org/leyden/commit/9b92dfc207a631f952bb7b227663d6aad6eef… removed unused SystemDictionaryShared::init_dumptime_info(Method* m) ! src/hotspot/share/classfile/systemDictionaryShared.cpp ! src/hotspot/share/classfile/systemDictionaryShared.hpp

1 0

git: openjdk/leyden: premain: Fix MethodTrainingData::make
by duke 29 Aug '23

29 Aug '23

Changeset: 38387c5b Author: Vladimir Kozlov <vladimir.kozlov(a)oracle.com> Date: 2023-08-29 14:53:22 +0000 URL: https://git.openjdk.org/leyden/commit/38387c5b6f8d64ac4e83df201ee2679a728f6… Fix MethodTrainingData::make ! src/hotspot/share/oops/trainingData.cpp

1 0

git: openjdk/leyden: premain: 2 new changesets
by duke 29 Aug '23

29 Aug '23

Changeset: 3ed4a9e3 Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-24 19:42:29 +0000 URL: https://git.openjdk.org/leyden/commit/3ed4a9e3ec7e4976957ead4216051a97e9290… ConstantPool::remove_unshareable_info() clean up ! src/hotspot/share/cds/archiveBuilder.cpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/instanceKlass.cpp Changeset: 3910f790 Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-28 17:41:17 +0000 URL: https://git.openjdk.org/leyden/commit/3910f79047fab03fa20e3aba16443ccc0256f… Fixed premain docs ! test/hotspot/jtreg/premain/InvokeDynamic.md ! test/hotspot/jtreg/premain/README.md ! test/hotspot/jtreg/premain/javac_helloworld/run.sh

1 0

I don't understand the wording here.
by David Alayachew 28 Aug '23

28 Aug '23

Hello Leyden Dev Team, I was reading the Leyden doc Brian Goetz put out this month called "Condensing Indy Bootstraps". https://openjdk.org/projects/leyden/notes/04-condensing-bootstraps Here is a quote from the last sentence of the first paragraph. > However, the bootstraps used by javac generally avoid runtime dependencies the most dynamic features of method handles, and therefore are likely candidates for such re-shifting. I don't understand the wording here. Mistype? Thank you for your time and help! David Alayachew

3 4

git: openjdk/leyden: premain: Check recompilation schedule existence to avoid potential crashes if the
by duke 25 Aug '23

25 Aug '23

Changeset: e1a591e7 Author: Igor Veresov <igor.veresov(a)oracle.com> Date: 2023-08-25 09:01:00 +0000 URL: https://git.openjdk.org/leyden/commit/e1a591e79983ba3527183de78dab3290242a5… Check recompilation schedule existence to avoid potential crashes if the CDS archive doesn't contain it. ! src/hotspot/share/compiler/compilationPolicy.cpp ! src/hotspot/share/oops/trainingData.hpp

1 0

git: openjdk/leyden: premain: 3 new changesets
by duke 24 Aug '23

24 Aug '23

Changeset: 631e2f0f Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-23 12:28:29 +0000 URL: https://git.openjdk.org/leyden/commit/631e2f0fa9f82fa1a3a36470922b6ab473c13… improve logging of (cds+resolve) ! src/hotspot/share/oops/constantPool.cpp Changeset: 980b5d92 Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-23 16:11:44 +0000 URL: https://git.openjdk.org/leyden/commit/980b5d92f33559462dcb14b06ea00336f5afa… Updated field CP archiving to match JDK-8301996 ! src/hotspot/share/cds/classListWriter.cpp ! src/hotspot/share/cds/classPrelinker.cpp ! src/hotspot/share/cds/classPrelinker.hpp ! src/hotspot/share/cds/dumpAllocStats.cpp ! src/hotspot/share/cds/dumpAllocStats.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/oops/constantPool.hpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/resolvedFieldEntry.cpp ! src/hotspot/share/oops/resolvedFieldEntry.hpp ! test/hotspot/jtreg/premain/javac_helloworld/Makefile ! test/hotspot/jtreg/premain/jmh/Makefile Changeset: 4ef082a9 Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-24 10:24:06 +0000 URL: https://git.openjdk.org/leyden/commit/4ef082a9cc2d2252e1d23f29aae4108fd6735… 8314247: JVMCI: expected int64_t but JavaThread::_held_monitor_count is of type intx (this is temp workaround from the withdrawn https://github.com/openjdk/jdk/pull/15295) ! src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotVMConfigAccess.java ! test/hotspot/jtreg/compiler/jvmci/jdk.vm.ci.code.test/src/jdk/vm/ci/code/test/TestHotSpotVMConfig.java

1 0

git: openjdk/leyden: premain: fixed missing JvmtiExport::_should_notify_object_alloc address when AOT compiling javac with -XX:+ArchiveInvokeDynamic
by duke 23 Aug '23

23 Aug '23

Changeset: 1d1854ed Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-23 14:12:41 +0000 URL: https://git.openjdk.org/leyden/commit/1d1854edddfbcadd1ae063c33a9c49d35f158… fixed missing JvmtiExport::_should_notify_object_alloc address when AOT compiling javac with -XX:+ArchiveInvokeDynamic ! src/hotspot/share/code/SCArchive.cpp

1 0

git: openjdk/leyden: premain: 8314846: Do not store Klass::_secondary_super_cache in CDS archive
by duke 23 Aug '23

23 Aug '23

Changeset: cc41a022 Author: iklam <ilam3388(a)gmail.com> Date: 2023-08-22 20:35:17 +0000 URL: https://git.openjdk.org/leyden/commit/cc41a0227ac1dff1fcc2e5b4d8d2ef1c530bd… 8314846: Do not store Klass::_secondary_super_cache in CDS archive ! src/hotspot/share/oops/klass.cpp

1 0