July 2024 - leyden-dev

git: openjdk/leyden: premain: 8336033: [premain] assert(comp != nullptr) when using SCCache with -XX:TieredStopAtLevel=1
by duke 10 Jul '24

10 Jul '24

Changeset: f65cccf9 Branch: premain Author: Igor Veresov <igor.veresov(a)oracle.com> Date: 2024-07-10 10:30:09 +0000 URL: https://git.openjdk.org/leyden/commit/f65cccf90853d2bfb7de533bab5a3b1fc1672… 8336033: [premain] assert(comp != nullptr) when using SCCache with -XX:TieredStopAtLevel=1 ! src/hotspot/share/code/SCCache.cpp ! src/hotspot/share/compiler/compilationPolicy.cpp

1 0

Hello from JRuby and here's another crash
by Charles Oliver Nutter 09 Jul '24

09 Jul '24

Hello friends! Long time lurker, first time poster. Like others I was excited to hear that the first EA of Leyden had dropped. Sadly, I have another crash to report. I see there are two other crashes reported, but mine appears different (ClassPrelinker::is_indy_resolution_deterministic): https://gist.github.com/headius/79c6460ed55c1d80c82e1c0209897e24 Perhaps unsurprisingly, the additional flags provided by Vladimir Kozlov (-XX:+UnlockDiagnosticVMOptions -XX:-ReduceAllocationMerges) did not appear to change the result. This is with JRuby's minimally invokedynamic-based mode, which has given us the shortest startup time in the past (second only to disabling tiers 2-4 and staying in C1). I am on MacOS AArch64 Sonoma 14.5, testing against JRuby master, but reproduction should be as easy as downloading the JRuby binary tarball, unpacking, and running bin/jruby with the command line above. https://www.jruby.org/download I am eager to work with Leyden folks to investigate issues, and I am planning to be at JVMLS this year to discuss collaborating more! - Charlie

3 4

git: openjdk/leyden: premain: 2 new changesets
by duke 09 Jul '24

09 Jul '24

Changeset: 5fdfef1d Branch: premain Author: iklam <ilam3388(a)gmail.com> Date: 2024-07-03 15:53:35 +0000 URL: https://git.openjdk.org/leyden/commit/5fdfef1df3bbcded1001fd1f0be8cce46d3bb… Added more test case for JDK-8317269: Archive old classes in verified state when CDSLoadedClasses is enabled ! test/hotspot/jtreg/runtime/cds/appcds/preloadedClasses/PreloadedClassesVerification.java Changeset: dbdccb37 Branch: premain Author: iklam <ilam3388(a)gmail.com> Date: 2024-07-09 11:05:44 +0000 URL: https://git.openjdk.org/leyden/commit/dbdccb376f3b535736dc4054c36b2159dbdb5… 8335790: Store protection domains into CDS archive ! src/hotspot/share/cds/archiveBuilder.cpp ! src/hotspot/share/cds/archiveHeapWriter.cpp ! src/hotspot/share/cds/cdsConfig.cpp ! src/hotspot/share/cds/cdsConfig.hpp ! src/hotspot/share/cds/cdsProtectionDomain.cpp ! src/hotspot/share/cds/cdsProtectionDomain.hpp ! src/hotspot/share/cds/cds_globals.hpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/javaClasses.hpp ! src/java.base/share/classes/java/security/SecureClassLoader.java ! src/java.base/share/classes/jdk/internal/misc/CDS.java + test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedProtectionDomains.java

1 0

git: openjdk/leyden: premain-ea: 2 new changesets
by duke 08 Jul '24

08 Jul '24

Changeset: f519a8a9 Author: iklam <ilam3388(a)gmail.com> Date: 2024-06-24 12:23:47 +0000 URL: https://git.openjdk.org/leyden/commit/f519a8a9a17c077a192dc16893e63d9a832a4… Removed incorrect message "Cannot dump shared archive while using shared archive" ! src/hotspot/share/cds/cdsConfig.cpp Changeset: c2a5c9ac Author: iklam <ilam3388(a)gmail.com> Date: 2024-07-06 09:36:41 +0000 URL: https://git.openjdk.org/leyden/commit/c2a5c9acf0b45f852ec885d2ace0247a2b62a… 8335804: ArchiveInvokeDynamic causes BootstrapMethodError ! src/java.base/share/classes/java/lang/invoke/MethodType.java

1 0

Build fails when disabling jvmti
by Sanne Grinovero 08 Jul '24

08 Jul '24

Hello all, I'm experimenting building Leyden locally with non-default configurations, with the intent of comparing its potential as an alternative to GraalVM native-images, and one of my goals would be to produce a minimal JVM build which exclusively includes the components that our applications are going to need at runtime. This implies being very selective with the JVM features I choose at configuration time; I've already opened some minor issues identified during such experiments. Today I noticed today that if I exclude the "jvmti" feature, the premain branch of Leyden doesn't compile: === Output from failing command(s) repeated here === * For target hotspot_variant-custom_libjvm_objs_SCCache.o: /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp: In member function ‘void SCAddressTable::init_opto()’: /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3815:39: error: ‘notify_jvmti_vthread_start’ is not a member of ‘OptoRuntime’ 3815 | SET_ADDRESS(_C2_blobs, OptoRuntime::notify_jvmti_vthread_start()); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3511:47: note: in definition of macro ‘SET_ADDRESS’ 3511 | type##_addr[type##_length++] = (address) (addr); \ | ^~~~ /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3816:39: error: ‘notify_jvmti_vthread_end’ is not a member of ‘OptoRuntime’ 3816 | SET_ADDRESS(_C2_blobs, OptoRuntime::notify_jvmti_vthread_end()); | ^~~~~~~~~~~~~~~~~~~~~~~~ /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3511:47: note: in definition of macro ‘SET_ADDRESS’ 3511 | type##_addr[type##_length++] = (address) (addr); \ | ^~~~ /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3817:39: error: ‘notify_jvmti_vthread_mount’ is not a member of ‘OptoRuntime’ 3817 | SET_ADDRESS(_C2_blobs, OptoRuntime::notify_jvmti_vthread_mount()); | ^~~~~~~~~~~~~~~~~~~~~~~~~~ /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3511:47: note: in definition of macro ‘SET_ADDRESS’ 3511 | type##_addr[type##_length++] = (address) (addr); \ | ^~~~ /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3818:39: error: ‘notify_jvmti_vthread_unmount’ is not a member of ‘OptoRuntime’ 3818 | SET_ADDRESS(_C2_blobs, OptoRuntime::notify_jvmti_vthread_unmount()); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/sanne/sources/leyden/src/hotspot/share/code/SCCache.cpp:3511:47: note: in definition of macro ‘SET_ADDRESS’ 3511 | type##_addr[type##_length++] = (address) (addr); \ | ^~~~ ... (rest of output omitted) I'm wondering if I should open an issue for this case? I appreciate it's early days and that such aspects might not be a priority currently! Thanks, Sanne

3 5

git: openjdk/leyden: premain: Guard JVMTI related code with INCLUDE_JVMTI
by duke 08 Jul '24

08 Jul '24

Changeset: c49bd56b Author: Ashutosh Mehra <asmehra(a)redhat.com> Date: 2024-07-08 15:01:40 +0000 URL: https://git.openjdk.org/leyden/commit/c49bd56b3599da6f1f9d5fffeea4d1887aa92… Guard JVMTI related code with INCLUDE_JVMTI Signed-off-by: Ashutosh Mehra <asmehra(a)redhat.com> ! src/hotspot/share/code/SCCache.cpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp

1 0

git: openjdk/leyden: premain: 3 new changesets
by duke 07 Jul '24

07 Jul '24

Changeset: 43e77c8e Author: iklam <ilam3388(a)gmail.com> Date: 2024-07-06 09:29:15 +0000 URL: https://git.openjdk.org/leyden/commit/43e77c8e62631d94e44cb017707917b7e2d6a… Added test case for 8328563: Store java.lang.ClassLoader::{packages, package2certs} into CDS archive ! src/java.base/share/classes/java/lang/ClassLoader.java ! test/hotspot/jtreg/premain/spring-petclinic/Makefile ! test/hotspot/jtreg/premain/spring-petclinic/WarmupMakefile + test/hotspot/jtreg/runtime/cds/appcds/cacheObject/ArchivedPackages.java = test/hotspot/jtreg/runtime/cds/appcds/test-classes/pkg3/Package3A.java = test/hotspot/jtreg/runtime/cds/appcds/test-classes/pkg3/Package3B.java Changeset: d9e3e5fe Author: iklam <ilam3388(a)gmail.com> Date: 2024-07-06 09:36:41 +0000 URL: https://git.openjdk.org/leyden/commit/d9e3e5fe69a430567c7ac4d91f2e064d594b4… 8335804: ArchiveInvokeDynamic causes BootstrapMethodError ! src/java.base/share/classes/java/lang/invoke/MethodType.java Changeset: 77e9f24c Author: iklam <ilam3388(a)gmail.com> Date: 2024-07-06 10:45:26 +0000 URL: https://git.openjdk.org/leyden/commit/77e9f24c8fb60e5ad741482c58ba83d19a34c… Print more info about command-line to help debugging the dumping process ! src/hotspot/share/cds/metaspaceShared.cpp

1 0

Crash when dumping cds map file
by Ashutosh Mehra 06 Jul '24

06 Jul '24

I encountered a crash when dumping the cds map with 1-step workflow. The crash happens in the forked JVM during the assembly phase of the training run. To recreate the crash, execute the training run with -Xlog:cds+map=trace:file=cds.map:none:filesize=0 option. # # A fatal error has been detected by the Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x00007f4e8a209cb6, pid=152509, tid=152510 # # JRE version: OpenJDK Runtime Environment (23.0) (slowdebug build 23-internal-adhoc.asmehra.leyden) # Java VM: OpenJDK 64-Bit Server VM (slowdebug 23-internal-adhoc.asmehra.leyden, mixed mode, sharing, tiered, compressed oops, compressed class ptrs, g1 gc, linux-amd64) # Problematic frame: # V [libjvm.so+0x409cb6] Klass::is_instance_klass() const+0x10 # # Core dump will be written. Default location: /home/asmehra/data/ashu-mehra/leyden/test/hotspot/jtreg/premain/quarkus-getting-started/core.152509 # # An error report file with more information is saved as: # /home/asmehra/data/ashu-mehra/leyden/test/hotspot/jtreg/premain/quarkus-getting-started/hs_err_pid152509.log # # If you would like to submit a bug report, please visit: # https://bugreport.java.com/bugreport/crash.jsp # [75.250s][error ][cds] Child process finished; status = 134 Backtrace for the crashing thread: #11 0x00007f4e8a209cb6 in Klass::is_instance_klass (this=0x0) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/oops/klass.hpp:683 #12 0x00007f4e8afa8894 in Klass::external_name (this=0x0) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/oops/klass.cpp:905 #13 0x00007f4e8b126447 in Method::print_external_name (os=0x7f4e89dfd130, klass=0x0, method_name=0x8011e8588, signature=0x8011ab858) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/oops/method.cpp:228 #14 0x00007f4e8b1263b6 in Method::external_name (klass=0x0, method_name=0x8011e8588, signature=0x8011ab858) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/oops/method.cpp:222 #15 0x00007f4e8b1262e1 in Method::external_name (this=0x800fd1920) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/oops/method.cpp:213 #16 0x00007f4e8a492b0d in ArchiveBuilder::CDSMapLogger::log_method (m=0x800fd1920, runtime_dest=0x801039cd8 "", type_name=0x7f4e8b7d40fc "Method", bytes=128, current=0x7f4e8401d900) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/archiveBuilder.cpp:1194 #17 0x00007f4e8a492d66 in ArchiveBuilder::CDSMapLogger::log_metaspace_objects (region=0x7f4e89dfe740, src_objs=0x7f4e89dfe860) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/archiveBuilder.cpp:1228 #18 0x00007f4e8a492a2b in ArchiveBuilder::CDSMapLogger::log_metaspace_region (name=0x7f4e8b7d8af0 "rw region", region=0x7f4e89dfe740, src_objs=0x7f4e89dfe860) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/archiveBuilder.cpp:1182 #19 0x00007f4e8a4940f4 in ArchiveBuilder::CDSMapLogger::log (builder=0x7f4e89dfe630, mapinfo=0x7f4e85017bb0, heap_info=0x7f4e89dfd4f0, bitmap=0x7f4e857bf850 "\t\222\004I\222$\t\210\210\210\001\b\200", bitmap_size_in_bytes=655824) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/archiveBuilder.cpp:1502 #20 0x00007f4e8a48f2a5 in ArchiveBuilder::write_archive (this=0x7f4e89dfe630, mapinfo=0x7f4e85017bb0, heap_info=0x7f4e89dfd4f0) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/archiveBuilder.cpp:1560 #21 0x00007f4e8b11d249 in MetaspaceShared::write_static_archive (builder=0x7f4e89dfe630, mapinfo=0x7f4e85017bb0, heap_info=0x7f4e89dfd4f0) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/metaspaceShared.cpp:988 #22 0x00007f4e8b11d1ac in MetaspaceShared::preload_and_dump_impl (builder=..., __the_thread__=0x7f4e8401d900) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/metaspaceShared.cpp:976 #23 0x00007f4e8b11c5fd in MetaspaceShared::preload_and_dump () at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/cds/metaspaceShared.cpp:767 #24 0x00007f4e8b53bca2 in Threads::create_vm (args=0x7f4e89dfedd0, canTryAgain=0x7f4e89dfecd3) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/runtime/threads.cpp:900 #25 0x00007f4e8ada2821 in JNI_CreateJavaVM_inner (vm=0x7f4e89dfee20, penv=0x7f4e89dfee28, args=0x7f4e89dfedd0) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/prims/jni.cpp:3581 #26 0x00007f4e8ada2c81 in JNI_CreateJavaVM (vm=0x7f4e89dfee20, penv=0x7f4e89dfee28, args=0x7f4e89dfedd0) at /home/asmehra/data/ashu-mehra/leyden/src/hotspot/share/prims/jni.cpp:3672 #27 0x00007f4e8ce0f84f in InitializeJVM (pvm=0x7f4e89dfee20, penv=0x7f4e89dfee28, ifn=0x7f4e89dfee70) at /home/asmehra/data/ashu-mehra/leyden/src/java.base/share/native/libjli/java.c:1550 Checking up the CDS map generated for the cds preimage shows some methods for which their InstanceKlass is null. This results in the crash seen above when such methods are printed as part of the CDS map file during the assembly phase. These methods are of the form: java.lang.Object java.lang.invoke.LambdaForm$MH/0x800000090.invoke(java.lang.Object, java.lang.Object) Interestingly -Xlog:cds=info shows such classes are skipped when generating the preimage as they are hidden classes: Skipping java/lang/invoke/LambdaForm$MH+0x800000090: Hidden class In the CDS map file for the preimage I also noticed that such methods are only referenced through MethodTrainingData -> _final_profile -> _method. So it looks like although we excluded such classes from the CDS archive, we don't exclude their training data. There is code for cleaning up the training data [0] , but it doesn't remove the training data for classes that have been excluded, unless I misunderstood the code. Not sure if it is intentional or a bug. If we do need to keep the training data for such methods, then we would need to handle the case of null InstanceKlass in the CDSMapLogger to avoid crashing. [0] https://github.com/openjdk/leyden/blob/8716f47ef49c829e2384474577ff468a732b… Thanks, - Ashutosh Mehra

4 6

git: openjdk/leyden: premain: fixed windows build
by duke 02 Jul '24

02 Jul '24

Changeset: d2446866 Author: iklam <ilam3388(a)gmail.com> Date: 2024-07-02 15:25:22 +0000 URL: https://git.openjdk.org/leyden/commit/d24468666c5aeb653caaf802c1af7ea4f487c… fixed windows build ! src/hotspot/share/cds/heapShared.hpp

1 0

git: openjdk/leyden: premain: 8309634: Resolve CONSTANT_MethodRef at CDS dump time
by duke 02 Jul '24

02 Jul '24

Changeset: bd601c50 Author: Ioi Lam <iklam(a)openjdk.org> Committer: iklam <ilam3388(a)gmail.com> Date: 2024-07-02 10:14:51 +0000 URL: https://git.openjdk.org/leyden/commit/bd601c509a001217ff25ba308458b52e3ad3d… 8309634: Resolve CONSTANT_MethodRef at CDS dump time Reviewed-by: matsaave, ccheung ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/interpreter/interpreterRuntime.hpp ! src/hotspot/share/interpreter/linkResolver.cpp ! src/hotspot/share/interpreter/linkResolver.hpp ! src/hotspot/share/oops/cpCache.cpp ! src/hotspot/share/oops/resolvedMethodEntry.hpp ! test/hotspot/jtreg/runtime/cds/appcds/resolvedConstants/ResolvedConstants.java

1 0