August 2024 - leyden-dev

git: openjdk/leyden: premain: Fix various build configs for clean PRs and happy CIs
by duke 28 Aug '24

28 Aug '24

Changeset: b96c5113 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Committer: iklam <ilam3388(a)gmail.com> Date: 2024-08-28 07:37:28 +0000 URL: https://git.openjdk.org/leyden/commit/b96c511323aea6ffb2fc972817c779b4bacaf… Fix various build configs for clean PRs and happy CIs ! src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp ! src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp ! src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp ! src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp ! src/hotspot/share/cds/archiveBuilder.hpp ! src/hotspot/share/cds/cdsConfig.cpp ! src/hotspot/share/ci/ciMethod.cpp ! src/hotspot/share/code/SCCache.cpp ! src/hotspot/share/interpreter/bytecodeHistogram.cpp ! src/hotspot/share/interpreter/bytecodeTracer.cpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/memory/virtualspace.cpp ! src/hotspot/share/oops/instanceKlass.cpp ! src/hotspot/share/oops/recompilationSchedule.cpp ! src/hotspot/share/oops/trainingData.cpp ! src/hotspot/share/oops/trainingData.hpp ! src/hotspot/share/opto/runtime.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/prims/methodHandles.cpp ! src/hotspot/share/prims/methodHandles.hpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/java.cpp ! src/hotspot/share/runtime/mutexLocker.cpp ! src/hotspot/share/runtime/perfData.hpp ! src/hotspot/share/runtime/perfData.inline.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/threads.cpp ! src/hotspot/share/runtime/vmThread.cpp

1 0

Some offhand questions
by Cesar Soares Lucas 27 Aug '24

27 Aug '24

Hello! I've a few questions that I'd like to ask your opinion about. - Signed Jars: As far as I understand, we currently don't include classes from signed jars in the CDS archive. What is the reason for that? I had the impression that being able to archive such classes would be important given that many .jars are signed?! - Profile/Archive score: I've been thinking that maybe a profile/archive score would be something useful to have at some point. The goal with such a "score" would be to report back to the user how much information from the archive was effectively used during a production run so that they have some insight about how "good" was the training run used to create the archive. The score for an archive could be an [weighted] aggregate of the scores of specific parts of the archive. We could also use the scores, in the future, if we choose to work on something to "merge" or "combine" multiple archives. - Condensers: I've been asked recently about the idea of condensers. As far as I understand there is nothing implemented on the lines of that idea. Is this something that we still plan to work in the future? - Recompilation: I've been reviewing the changes in the @premain branch, and I came across this piece of code [1] and was puzzled by it. Why do we recompile the code at every compilation level? There is a lot I still don't understand about the implementation in premain, but what I was expecting was that at some point in the code we would just "dump" the code cache and that would be our "AOT compiled code". Thanks, Cesar [1] https://github.com/openjdk/leyden/blob/premain/src/hotspot/share/compiler/p…

7 8

Re: Encapsulating JVM Options
by John Rose 27 Aug '24

27 Aug '24

[CC-ing leyden-dev for this reply. We are talking about ways to wire up dependencies on JVM options in globals.hpp and elsewhere to the AOT cache as a whole, and/or to individually compiled nmethods.] On 23 Aug 2024, at 10:21, Cesar Soares Lucas wrote: > Hi, Igor, John. > > Some questions: > >> From John Rose >> This should probably turn into a >> dependency record (of some sort) on the particular AOT nmethod, so that >> when we load AOT code in production, we can ensure we are not loading >> a method that “doesn’t fit” into the current JVM. > > John, you mentioned above adding the "dependency record" to a particular _nmethod_. I was under the impression that the record would be the same for all HotSpot components (or a single record for the whole CDS archive). Do you think we might need (or want) different records (or parts of it) for different HotSpot components, compilation tasks, or nmethods? I have been using the term “dependency record” loosely, because such a thing can be appropriate on the AOT cache as a whole, or on specific “assets” that are optionally loadable within the AOT cache, and specifically nmethods or other code blobs. (As you know, code blobs reside in the “code cache”, aka the code heap. An nmethod is a code blob that compiles the entry point of some Java/JVM method.) Nmethods in the AOT code cache are by nature optionally adoptable, since you can always ignore it and use some other mode for executing the corresponding Java/JVM method. (Note: AOT cache is the new name for the CDS archive, as expanded by the new features we are working on. In our EA, the AOT cache contains AOT klasses and methods, AOT method profiles, AOT Java objects like interned strings, and AOT nmethods. All of these things have been generated in the past mainly on a just-in-time basis.) Some nmethods have dependencies which are more demanding than the dependencies on the overall AOT cache. That is, even if the AOT cache is “cleared for takeoff” (matching flags like narrow oops, etc.), an individual nmethod within its AOT code cache might be impossible to adopt as the compilation of its method. In our premain EA this can happen because an nmethod X demands that some klass Foo be initialized, and Foo has not yet been initialized; only when Foo is fully initialized is the nmethod X (in the code cache) a candidate for connecting to its Java/JVM method. Also in this case, there is often another nmethod X0 (also in the AOT code cache) for the same Java/JVM method, which does NOT require Foo to be initialized; this nmethod is adopted ASAP during startup, and only gets replaced when Foo (and every other klass that X “cares about”) comes to be initialized. I think if we make other kinds of individual dependencies on AOT nmethods, such as “platform must support AVX-512”, we might also think about generating two versions, one with the demanding dependency, and one without. A dependency, if asserted, creates a sort of “debt” to say what should happen when the dependency fails (or is not yet true, as in the case of class initialization). That “debt” can be satisfied by having two versions of some individual AOT cache asset, or of the AOT cache as a whole. There could possibly be a use case for storing dependencies on other kinds of assets in the AOT Cache. For example, suppose a klass K is somehow optionally loadable. (Old CDS does just-in-time loading, so this is physically possible in the AOT cache as well.) We are emphasizing AOT loading and linking, in the premain phase, but perhaps klass K must be loaded “the old fashioned way” by processing its pre-parsed representation. I can imagine there could be some dependency-like information attached to klass K that says “do not adopt this asset unless XYZ is true”, and XYZ is something more specific than the overall dependencies written into the AOT cache. But here I am just speculating about something that might be useful in thefuture. Again, the current work focuses on profiting from the decision to load and link as many classes as possible in the premain phase, the startup moments before application main is invoked. And all classes loaded in premain phase are loaded as a block, so they either stand together or fall together, based on whatever dependencies are written into the AOT cache as a whole. > I'll for sure have more questions and things to discuss once I start working on this, which I'm planning to do next Monday. > My first step will be trying to get an overview of all sorts of "flags" that I'll have to add to the record. > > > I'm glad to start working on this! > Cesar Thanks! — John P.S. I’d like to invite anyone working on “dependencies” (in the broad sense) to think about how there might be a “dependency API” that applies in multiple places, and perhaps could be encoded (in multiple places) in ways that are somehow uniform in our C++ code. Currently, dependencies.hpp is only for nmethods, since those are the key optionally useable items in the JVM. (You can always discard an nmethod, but you can't discard most other items in the JVM, until the GC gives you permission. Something which is optionally discardable is also optionally usable, and can be coupled to side conditions that are unpredictable. So an nmethod can depend on the fact some particular method has no overrides, because it can be transparently discarded when a new class with an override is suddenly loaded. In Leyden, a cached AOT nmethod can also depend on some granular platform feature like AVX-512 that the rest of the AOT cache ignores. The common thread is an optionally adoptable and/or optionally discardable asset of some sort.) In the AOT cache, there are potentially many kinds of optionally adoptable assets, since the JVM in many cases can decide to regenerate an item it needs from scratch, just in time, rather than adopting a cached AOT asset. I can’t imagine a dependency on an AOT klass asset (other than a useless one the duplicates a dependency on the whole AOT cache) but maybe there is one. (Note: the term “klass” is the JVM-internal name for a metadata object that represents a loaded classfile. When I say “class” I might be referring to many things in source code or elsewhere, and I don’t always mean “or interface”. But “klass” means “metadata for a loaded classfile”. It also sometimes means metadata for something else like /new int[0].getClass()/.) OK, here is one very simple dependency, which probably does not need an individual call-out: Some optionally adoptable klass asset K might “bake in” stabilized pointers into the block of premain klasses. In that case, it would be a mistake to load and link K before Object, String, and all the premain classes were loaded and linked. I suppose if we (in the far future) ever organized multiple blocks of klass assets in layers the layers themselves could have load-sequence dependencies. A layer would be like a shared library that requires resolved references to previously loaded shared libraries; the OS must load those previous ones first and then load the shared library that depends on it. I say “far future” because this idea (klass layers) is the sort of thing that comes up routinely, and is routinely put on the list of things to examine later. Maybe there are somehow concepts in dependencies.hpp that could be teased out for use in other places. Or perhaps there is no cross-application, and logical dependencies look completely different when applied to the AOT cache as a whole, and again applied to nmethods, and perhaps later applied to some other optionally adoptable asset within the AOT cache. Still, it would be nice to have a common API, especially there is parallel growth of complexity at the level of nmethods and on the whole cache (e.g., of dependencies on flags). Or if there is a third location for dependencies (optional klass assets?) it might be nice to make a new use of an existing API instead of building out new dependency logic (in the new place) from scratch.

1 1

git: openjdk/leyden: premain: Cleanup AOT runtime constants code
by duke 26 Aug '24

26 Aug '24

Changeset: cc111760 Branch: premain Author: Vladimir Kozlov <vladimir.kozlov(a)oracle.com> Date: 2024-08-26 14:21:28 +0000 URL: https://git.openjdk.org/leyden/commit/cc111760a0dd123935e039feb19eaac742f86… Cleanup AOT runtime constants code ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/adlc/main.cpp ! src/hotspot/share/ci/ciUtilities.cpp ! src/hotspot/share/ci/ciUtilities.hpp ! src/hotspot/share/code/SCCache.hpp ! src/hotspot/share/gc/g1/c1/g1BarrierSetC1.cpp ! src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/runtime/stubRoutines.hpp

1 0

git: openjdk/leyden: premain: Keep cached strings longer. Fix ExternalsRecorder::print_statistics()
by duke 23 Aug '24

23 Aug '24

Changeset: 7f633b95 Branch: premain Author: Vladimir Kozlov <vladimir.kozlov(a)oracle.com> Date: 2024-08-23 12:41:39 +0000 URL: https://git.openjdk.org/leyden/commit/7f633b95c03ff824fbb243f5b463a25682d06… Keep cached strings longer. Fix ExternalsRecorder::print_statistics() ! src/hotspot/share/code/SCCache.cpp ! src/hotspot/share/code/oopRecorder.cpp

1 0

git: openjdk/leyden: premain: 93 new changesets
by duke 23 Aug '24

23 Aug '24

Changeset: f132b347 Branch: premain Author: SendaoYan <syan(a)openjdk.org> Committer: Rajan Halade <rhalade(a)openjdk.org> Date: 2024-08-13 22:59:13 +0000 URL: https://git.openjdk.org/leyden/commit/f132b347e13a57d9654f0ab11db0636999576… 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout Reviewed-by: rhalade ! test/jdk/security/infra/java/security/cert/CertPathValidator/certification/CAInterop.java Changeset: 720b4464 Branch: premain Author: Jaikiran Pai <jpai(a)openjdk.org> Date: 2024-08-14 05:42:14 +0000 URL: https://git.openjdk.org/leyden/commit/720b44648bcff997278af92746f942b242529… 8335181: Incorrect handling of HTTP/2 GOAWAY frames in HttpClient Reviewed-by: dfuchs ! src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java ! src/java.net.http/share/classes/jdk/internal/net/http/MultiExchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/Stream.java ! src/java.net.http/share/classes/jdk/internal/net/http/WindowController.java ! src/java.net.http/share/classes/jdk/internal/net/http/frame/GoAwayFrame.java + test/jdk/java/net/httpclient/http2/H2GoAwayTest.java ! test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/common/HttpServerAdapters.java ! test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchange.java ! test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestExchangeImpl.java ! test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServer.java ! test/jdk/java/net/httpclient/lib/jdk/httpclient/test/lib/http2/Http2TestServerConnection.java Changeset: 3dd07b91 Branch: premain Author: Qizheng Xing <qxing(a)openjdk.org> Committer: Eric Liu <eliu(a)openjdk.org> Date: 2024-08-14 06:28:34 +0000 URL: https://git.openjdk.org/leyden/commit/3dd07b91bbf644aa867452806e9388089fa97… 8336163: Remove declarations of some debug-only methods in release build Reviewed-by: dholmes, eliu, kvn ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/compiler/compilationPolicy.hpp ! src/hotspot/share/opto/node.hpp ! src/hotspot/share/runtime/frame.hpp ! src/hotspot/share/runtime/registerMap.hpp Changeset: 66bee253 Branch: premain Author: Ivan Walulya <iwalulya(a)openjdk.org> Date: 2024-08-14 09:13:21 +0000 URL: https://git.openjdk.org/leyden/commit/66bee2532f849cfb7ab63857ecd7d773c2566… 8338315: G1: G1CardTableEntryClosure:do_card_ptr remove unused parameter worker_id Reviewed-by: tschatzl ! src/hotspot/share/gc/g1/g1CardTableEntryClosure.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp Changeset: 9fe1777f Branch: premain Author: Albert Mingkun Yang <ayang(a)openjdk.org> Date: 2024-08-14 09:16:02 +0000 URL: https://git.openjdk.org/leyden/commit/9fe1777fafca30cf60acb5402c7c708001371… 8338280: Parallel: Inline ParallelCompactData::verify_clear Reviewed-by: tschatzl ! src/hotspot/share/gc/parallel/psParallelCompact.cpp ! src/hotspot/share/gc/parallel/psParallelCompact.hpp Changeset: 38bd8a36 Branch: premain Author: Matthias Baesken <mbaesken(a)openjdk.org> Date: 2024-08-14 09:52:23 +0000 URL: https://git.openjdk.org/leyden/commit/38bd8a36704a962f0ad1052fd2ec150a61663… 8338236: Compile error in cgroup code on Linux when using clang Reviewed-by: mdoerr, sgehwolf ! src/hotspot/os/linux/cgroupV1Subsystem_linux.hpp ! src/hotspot/os/linux/cgroupV2Subsystem_linux.hpp Changeset: fbe4f056 Branch: premain Author: Jan Lahoda <jlahoda(a)openjdk.org> Date: 2024-08-14 12:20:17 +0000 URL: https://git.openjdk.org/leyden/commit/fbe4f05636c8f692bd40bbe11fb5bb8b77b77… 8337976: Insufficient error recovery in parser for switch inside class body Reviewed-by: vromero ! src/jdk.compiler/share/classes/com/sun/tools/javac/comp/Attr.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/parser/VirtualParser.java ! src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler.properties = test/langtools/tools/javac/diags/examples/StatementNotExpected.java ! test/langtools/tools/javac/parser/JavacParserTest.java ! test/langtools/tools/javac/records/RecordCompilationTests.java + test/langtools/tools/javac/recovery/T8337976.java + test/langtools/tools/javac/recovery/T8337976.out Changeset: a5d948fb Branch: premain Author: John Engebretson <jengebr(a)amazon.com> Committer: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-14 14:11:53 +0000 URL: https://git.openjdk.org/leyden/commit/a5d948fb9841f654cccc9567c60e8d28e7d71… 8332842: Optimize empty CopyOnWriteArrayList allocations Reviewed-by: shade, alanb ! src/java.base/share/classes/java/util/concurrent/CopyOnWriteArrayList.java + test/micro/org/openjdk/bench/java/util/concurrent/CopyOnWriteArrayListBenchmark.java Changeset: d8e4d3f2 Branch: premain Author: Zdenek Zambersky <zzambers(a)openjdk.org> Committer: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-14 15:20:07 +0000 URL: https://git.openjdk.org/leyden/commit/d8e4d3f2d6c187f2487acd390a4e5fa2a9901… 8338402: GHA: some of bundles may not get removed Reviewed-by: ihse, shade ! .github/workflows/main.yml Changeset: 0e3903f2 Branch: premain Author: Albert Mingkun Yang <ayang(a)openjdk.org> Date: 2024-08-14 16:49:11 +0000 URL: https://git.openjdk.org/leyden/commit/0e3903f2eb854715acee92cfc5ee2d4a2e800… 8338393: Parallel: Remove unused ParallelCompactData::clear_range Reviewed-by: tschatzl ! src/hotspot/share/gc/parallel/psParallelCompact.hpp Changeset: 6a390147 Branch: premain Author: Matthias Baesken <mbaesken(a)openjdk.org> Date: 2024-08-14 16:56:28 +0000 URL: https://git.openjdk.org/leyden/commit/6a390147959e0fb88de6ee13204cff72cd910… 8338110: Exclude Fingerprinter::do_type from ubsan checks Reviewed-by: jwaters, rrich ! src/hotspot/share/runtime/signature.hpp Changeset: c0384b6f Branch: premain Author: Phil Race <prr(a)openjdk.org> Date: 2024-08-14 17:58:24 +0000 URL: https://git.openjdk.org/leyden/commit/c0384b6f3584501fb3bd93854734eeacf6620… 8337237: Use FFM instead of Unsafe for Java 2D RenderBuffer class Reviewed-by: jvernee, jdv ! src/java.desktop/share/classes/sun/java2d/pipe/RenderBuffer.java Changeset: 723ac576 Branch: premain Author: Chris Plummer <cjplummer(a)openjdk.org> Date: 2024-08-14 18:41:24 +0000 URL: https://git.openjdk.org/leyden/commit/723ac5763aed0d67516c6746f39a066efc412… 8332488: Add JVMTI DataDumpRequest to the debug agent Reviewed-by: sspitsyn, lmesnik ! src/jdk.jdwp.agent/share/native/libjdwp/debugInit.c ! src/jdk.jdwp.agent/share/native/libjdwp/eventFilter.c ! src/jdk.jdwp.agent/share/native/libjdwp/eventFilter.h ! src/jdk.jdwp.agent/share/native/libjdwp/eventHandler.c ! src/jdk.jdwp.agent/share/native/libjdwp/eventHandler.h ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.c ! src/jdk.jdwp.agent/share/native/libjdwp/threadControl.h ! src/jdk.jdwp.agent/share/native/libjdwp/util.c ! src/jdk.jdwp.agent/share/native/libjdwp/util.h + test/jdk/com/sun/jdi/DataDumpTest.java Changeset: aff7936f Branch: premain Author: Joe Darcy <darcy(a)openjdk.org> Date: 2024-08-14 18:42:59 +0000 URL: https://git.openjdk.org/leyden/commit/aff7936ff088249d1fc787a9f9ef687f987f5… 8338333: Add jls links to javax.lang.model.element.Modifier Reviewed-by: liach, iris, prappo, vromero, jlahoda ! src/java.compiler/share/classes/javax/lang/model/element/Modifier.java Changeset: e3a5e265 Branch: premain Author: SendaoYan <syan(a)openjdk.org> Committer: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-14 18:55:58 +0000 URL: https://git.openjdk.org/leyden/commit/e3a5e265a7747b02b8f828fbedea0dda7246f… 8338344: Test TestPrivilegedMode.java intermittent fails java.lang.NoClassDefFoundError: jdk/test/lib/Platform Reviewed-by: chagedorn, shade ! test/hotspot/jtreg/compiler/lib/ir_framework/driver/TestVMProcess.java Changeset: 4669e7b7 Branch: premain Author: Evgeny Nikitin <enikitin(a)openjdk.org> Committer: Tobias Hartmann <thartmann(a)openjdk.org> Date: 2024-08-15 05:36:11 +0000 URL: https://git.openjdk.org/leyden/commit/4669e7b7b02636a8bd7381a9d401aaaf0c1d7… 8337102: JITTester: Fix breaks in static initialization blocks Reviewed-by: kvn, iveresov ! test/hotspot/jtreg/testlibrary/jittester/conf/default.properties ! test/hotspot/jtreg/testlibrary/jittester/src/jdk/test/lib/jittester/factories/StaticConstructorDefinitionFactory.java Changeset: 4c344335 Branch: premain Author: Matthias Baesken <mbaesken(a)openjdk.org> Date: 2024-08-15 07:39:31 +0000 URL: https://git.openjdk.org/leyden/commit/4c344335fe0abc04308f4bfc62c6b3afc1102… 8338304: clang on Linux - check for lld presence after JDK-8333189 Reviewed-by: erikj, ihse ! make/autoconf/flags-ldflags.m4 Changeset: f536f5ab Branch: premain Author: Ivan Walulya <iwalulya(a)openjdk.org> Date: 2024-08-15 08:26:22 +0000 URL: https://git.openjdk.org/leyden/commit/f536f5ab68235d27e9708674f707bcbff7840… 8336086: G1: Use one G1CardSet instance for all young regions Reviewed-by: tschatzl, ayang ! src/hotspot/share/gc/g1/g1CardSet.cpp ! src/hotspot/share/gc/g1/g1CardSet.hpp ! src/hotspot/share/gc/g1/g1CollectedHeap.cpp ! src/hotspot/share/gc/g1/g1CollectedHeap.hpp ! src/hotspot/share/gc/g1/g1CollectionSet.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.cpp ! src/hotspot/share/gc/g1/g1ConcurrentMark.hpp ! src/hotspot/share/gc/g1/g1ConcurrentRefine.cpp ! src/hotspot/share/gc/g1/g1FullCollector.cpp ! src/hotspot/share/gc/g1/g1HeapRegion.cpp ! src/hotspot/share/gc/g1/g1HeapRegion.hpp ! src/hotspot/share/gc/g1/g1HeapRegion.inline.hpp ! src/hotspot/share/gc/g1/g1HeapRegionRemSet.cpp ! src/hotspot/share/gc/g1/g1HeapRegionRemSet.hpp ! src/hotspot/share/gc/g1/g1HeapRegionRemSet.inline.hpp ! src/hotspot/share/gc/g1/g1Policy.cpp ! src/hotspot/share/gc/g1/g1Policy.hpp ! src/hotspot/share/gc/g1/g1RemSet.cpp ! src/hotspot/share/gc/g1/g1RemSetSummary.cpp ! src/hotspot/share/gc/g1/g1YoungCollector.cpp ! src/hotspot/share/gc/g1/g1YoungGCPostEvacuateTasks.cpp Changeset: da7311bb Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-15 08:50:29 +0000 URL: https://git.openjdk.org/leyden/commit/da7311bbe37c2b9632b117d52a77c65904782… 8338286: GHA: Demote x86_32 to hotspot build only Reviewed-by: ihse ! .github/workflows/main.yml Changeset: 74fdd686 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-15 11:24:22 +0000 URL: https://git.openjdk.org/leyden/commit/74fdd6868d3f71d44ef9f71a0ca9506c04d39… 8333791: Fix memory barriers for @Stable fields Reviewed-by: liach, vlivanov ! src/hotspot/share/c1/c1_GraphBuilder.cpp ! src/hotspot/share/c1/c1_IR.cpp ! src/hotspot/share/c1/c1_IR.hpp ! src/hotspot/share/opto/parse.hpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/opto/parse3.cpp + test/hotspot/jtreg/compiler/c2/irTests/stable/StablePrimArrayTest.java + test/hotspot/jtreg/compiler/c2/irTests/stable/StablePrimFinalTest.java + test/hotspot/jtreg/compiler/c2/irTests/stable/StablePrimPlainTest.java + test/hotspot/jtreg/compiler/c2/irTests/stable/StablePrimVolatileTest.java + test/hotspot/jtreg/compiler/c2/irTests/stable/StableRefArrayTest.java + test/hotspot/jtreg/compiler/c2/irTests/stable/StableRefFinalTest.java + test/hotspot/jtreg/compiler/c2/irTests/stable/StableRefPlainTest.java + test/hotspot/jtreg/compiler/c2/irTests/stable/StableRefVolatileTest.java Changeset: 56dec215 Branch: premain Author: Sonia Zaldana Calles <szaldana(a)openjdk.org> Date: 2024-08-15 13:28:25 +0000 URL: https://git.openjdk.org/leyden/commit/56dec215b0d056fc23137372ecb3376af2a7b… 8338014: Improve usage of @jvms tags in class file API Reviewed-by: darcy, liach, asotona ! src/java.base/share/classes/java/lang/classfile/AnnotationValue.java ! src/java.base/share/classes/java/lang/classfile/Attribute.java ! src/java.base/share/classes/java/lang/classfile/ClassSignature.java ! src/java.base/share/classes/java/lang/classfile/MethodSignature.java ! src/java.base/share/classes/java/lang/classfile/Opcode.java ! src/java.base/share/classes/java/lang/classfile/Signature.java ! src/java.base/share/classes/java/lang/classfile/TypeAnnotation.java ! src/java.base/share/classes/java/lang/classfile/attribute/AnnotationDefaultAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/BootstrapMethodsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/CodeAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/ConstantValueAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/DeprecatedAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/EnclosingMethodAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/ExceptionsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/InnerClassesAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/LineNumberTableAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableTableAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/LocalVariableTypeTableAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/MethodParametersAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/ModuleAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/ModuleMainClassAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/ModulePackagesAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/NestHostAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/NestMembersAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/PermittedSubclassesAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/RecordAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/RuntimeInvisibleAnnotationsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/RuntimeInvisibleParameterAnnotationsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/RuntimeInvisibleTypeAnnotationsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/RuntimeVisibleAnnotationsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/RuntimeVisibleParameterAnnotationsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/RuntimeVisibleTypeAnnotationsAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/SignatureAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/SourceFileAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/StackMapFrameInfo.java ! src/java.base/share/classes/java/lang/classfile/attribute/StackMapTableAttribute.java ! src/java.base/share/classes/java/lang/classfile/attribute/SyntheticAttribute.java ! src/java.base/share/classes/java/lang/classfile/constantpool/ConstantPoolBuilder.java ! src/java.base/share/classes/java/lang/classfile/constantpool/MethodHandleEntry.java ! src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java Changeset: 38591315 Branch: premain Author: Fei Gao <fgao(a)openjdk.org> Date: 2024-08-15 15:16:14 +0000 URL: https://git.openjdk.org/leyden/commit/38591315058e6d3b764ca325facc5bf46bf7b… 8338442: AArch64: Clean up IndOffXX type and let legitimize_address() fix out-of-range operands Reviewed-by: aph, dlong ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/aarch64_vector.ad ! src/hotspot/cpu/aarch64/aarch64_vector_ad.m4 ! src/hotspot/cpu/aarch64/ad_encode.m4 ! src/hotspot/cpu/aarch64/gc/x/x_aarch64.ad ! src/hotspot/cpu/aarch64/gc/z/z_aarch64.ad ! test/hotspot/jtreg/compiler/c2/TestUnalignedAccess.java Changeset: 6169613d Branch: premain Author: Daniel Fuchs <dfuchs(a)openjdk.org> Date: 2024-08-15 15:34:08 +0000 URL: https://git.openjdk.org/leyden/commit/6169613d9f3f0bf019d04a37a1d8f28f1463c… 8336655: java/net/httpclient/DigestEchoClient.java IOException: HTTP/1.1 header parser received no bytes Reviewed-by: jpai ! src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java ! src/java.net.http/share/classes/jdk/internal/net/http/SocketTube.java ! test/jdk/java/net/httpclient/DigestEchoClient.java Changeset: 7d1bbff0 Branch: premain Author: lawrence.andrews <lawrence.andrews(a)oracle.com> Committer: Harshitha Onkar <honkar(a)openjdk.org> Date: 2024-08-15 16:36:15 +0000 URL: https://git.openjdk.org/leyden/commit/7d1bbff076c063d066951eedb21de7e694e58… 8328553: Get rid of JApplet in test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java Reviewed-by: honkar, prr ! test/jdk/sanity/client/lib/SwingSet2/src/DemoModule.java Changeset: ef54af39 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-15 16:45:43 +0000 URL: https://git.openjdk.org/leyden/commit/ef54af39883e76c80a3e012ed91b90973da51… 8338444: Shenandoah: Remove ShenandoahHumongousThreshold tunable Reviewed-by: rkennke, wkemper, ysr ! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp ! src/hotspot/share/gc/shenandoah/shenandoahController.cpp ! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp ! src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.hpp ! src/hotspot/share/gc/shenandoah/shenandoahInitLogger.cpp ! src/hotspot/share/gc/shenandoah/shenandoah_globals.hpp - test/hotspot/jtreg/gc/shenandoah/TestHumongousThreshold.java - test/hotspot/jtreg/gc/shenandoah/options/TestHumongousThresholdArgs.java Changeset: e51e40c2 Branch: premain Author: Satyen Subramaniam <satyenme(a)amazon.com> Committer: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-15 16:47:08 +0000 URL: https://git.openjdk.org/leyden/commit/e51e40c2b9f51d012c01407e0b8dadaab4647… 8336914: Shenandoah: Missing verification steps after JDK-8255765 Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp Changeset: f308b2d5 Branch: premain Author: Satyen Subramaniam <satyenme(a)amazon.com> Committer: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-15 16:47:45 +0000 URL: https://git.openjdk.org/leyden/commit/f308b2d59672b39ddca502baff50ab20ab781… 8336915: Shenandoah: Remove unused ShenandoahVerifier::verify_after_evacuation Reviewed-by: shade ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp Changeset: 96550827 Branch: premain Author: Kim Barrett <kbarrett(a)openjdk.org> Date: 2024-08-15 17:43:09 +0000 URL: https://git.openjdk.org/leyden/commit/965508270ecd092019f7bea3a1605c5d9f19d… 8338330: Fix -Wzero-as-null-pointer-constant warnings from THROW_XXX_0 Reviewed-by: dlong, dholmes, shade ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/reflection.cpp ! src/hotspot/share/utilities/exceptions.hpp Changeset: ace49651 Branch: premain Author: Chen Liang <liach(a)openjdk.org> Date: 2024-08-15 17:50:34 +0000 URL: https://git.openjdk.org/leyden/commit/ace496515f4f91e802a51cec43d387eed61bd… 8338406: BytecodeHelpers using wrong bootstrap method descriptor for condy Reviewed-by: asotona ! src/java.base/share/classes/jdk/internal/classfile/impl/BytecodeHelpers.java + test/jdk/jdk/classfile/ConstantDescSymbolsTest.java - test/jdk/jdk/classfile/PrimitiveClassConstantTest.java Changeset: 52d9d69d Branch: premain Author: Kim Barrett <kbarrett(a)openjdk.org> Date: 2024-08-15 17:50:44 +0000 URL: https://git.openjdk.org/leyden/commit/52d9d69db5c1853445a95794c5bf21243aefa… 8338331: Fix -Wzero-as-null-pointer-constant warnings from CHECK_0 in jni.cpp Reviewed-by: dholmes, shade ! src/hotspot/share/prims/jni.cpp Changeset: 1cd48843 Branch: premain Author: Coleen Phillimore <coleenp(a)openjdk.org> Date: 2024-08-15 18:20:20 +0000 URL: https://git.openjdk.org/leyden/commit/1cd488436880b00c55fa91f44c115999cf686… 8338447: Remove InstanceKlass::_is_marked_dependent Reviewed-by: shade ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: d86e99c3 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-15 20:52:07 +0000 URL: https://git.openjdk.org/leyden/commit/d86e99c3ca94ee8705e44fe2830edd3ceb0a7… 8293650: Shenandoah: Support archived heap objects Reviewed-by: rkennke, wkemper, iklam ! src/hotspot/share/cds/archiveHeapWriter.hpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeapRegion.cpp + test/hotspot/jtreg/runtime/cds/appcds/TestShenandoahWithCDS.java Changeset: 74066bcc Branch: premain Author: Shaojin Wen <shaojin.wensj(a)alibaba-inc.com> Committer: Claes Redestad <redestad(a)openjdk.org> Date: 2024-08-15 22:57:33 +0000 URL: https://git.openjdk.org/leyden/commit/74066bcca82749722e6fee57469520d418bf3… 8338409: Use record to simplify code Reviewed-by: redestad, liach ! src/java.base/share/classes/java/util/Formatter.java Changeset: bd4160ce Branch: premain Author: Axel Boldt-Christmas <aboldtch(a)openjdk.org> Date: 2024-08-16 06:20:17 +0000 URL: https://git.openjdk.org/leyden/commit/bd4160cea8b6b0fcf0507199ed76a12f5d0aa… 8315884: New Object to ObjectMonitor mapping Co-authored-by: Erik Österlund <eosterlund(a)openjdk.org> Co-authored-by: Stefan Karlsson <stefank(a)openjdk.org> Co-authored-by: Coleen Phillimore <coleenp(a)openjdk.org> Reviewed-by: rkennke, coleenp, dcubed ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/c1_MacroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/c2_MacroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/arm/interp_masm_arm.cpp ! src/hotspot/cpu/ppc/interp_masm_ppc_64.cpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp ! src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/interp_masm_riscv.cpp ! src/hotspot/cpu/s390/interp_masm_s390.cpp ! src/hotspot/cpu/s390/macroAssembler_s390.cpp ! src/hotspot/cpu/x86/c1_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/c2_CodeStubs_x86.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/interp_masm_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/sharedRuntime_x86.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/zero/zeroInterpreter_zero.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/interpreter/zero/bytecodeInterpreter.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/oops/markWord.cpp ! src/hotspot/share/oops/markWord.hpp ! src/hotspot/share/opto/c2_CodeStubs.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/prims/jvmtiEnvBase.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/basicLock.cpp ! src/hotspot/share/runtime/basicLock.hpp + src/hotspot/share/runtime/basicLock.inline.hpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/javaThread.cpp ! src/hotspot/share/runtime/javaThread.hpp ! src/hotspot/share/runtime/javaThread.inline.hpp + src/hotspot/share/runtime/lightweightSynchronizer.cpp + src/hotspot/share/runtime/lightweightSynchronizer.hpp ! src/hotspot/share/runtime/lockStack.cpp ! src/hotspot/share/runtime/lockStack.hpp ! src/hotspot/share/runtime/lockStack.inline.hpp ! src/hotspot/share/runtime/objectMonitor.cpp ! src/hotspot/share/runtime/objectMonitor.hpp ! src/hotspot/share/runtime/objectMonitor.inline.hpp ! src/hotspot/share/runtime/safepoint.cpp ! src/hotspot/share/runtime/serviceThread.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/synchronizer.cpp ! src/hotspot/share/runtime/synchronizer.hpp + src/hotspot/share/runtime/synchronizer.inline.hpp ! src/hotspot/share/runtime/vframe.cpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/Mark.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/BasicLock.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectMonitor.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ObjectSynchronizer.java ! test/hotspot/gtest/runtime/test_objectMonitor.cpp + test/hotspot/jtreg/runtime/Monitor/UseObjectMonitorTableTest.java ! test/hotspot/jtreg/runtime/logging/MonitorInflationTest.java ! test/micro/org/openjdk/bench/vm/lang/LockUnlock.java Changeset: 60c9b5cd Branch: premain Author: Andrey Turbanov <aturbanov(a)openjdk.org> Date: 2024-08-16 08:49:18 +0000 URL: https://git.openjdk.org/leyden/commit/60c9b5cd9f18830f0fb1aea6cb3dc43af3908… 8337839: Make a few fields in MergeCollation static Reviewed-by: jpai, naoto ! src/java.base/share/classes/java/text/MergeCollation.java Changeset: ddbc0b6a Branch: premain Author: Daniel Fuchs <dfuchs(a)openjdk.org> Date: 2024-08-16 11:24:40 +0000 URL: https://git.openjdk.org/leyden/commit/ddbc0b6a39148cb30a8fda80fa7290e90e2a7… 8338495: Revert "8336655: java/net/httpclient/DigestEchoClient.java IOException: HTTP/1.1 header parser received no bytes" Reviewed-by: jpai ! src/java.net.http/share/classes/jdk/internal/net/http/ConnectionPool.java ! src/java.net.http/share/classes/jdk/internal/net/http/SocketTube.java ! test/jdk/java/net/httpclient/DigestEchoClient.java Changeset: 5022109b Branch: premain Author: Shaojin Wen <shaojin.wensj(a)alibaba-inc.com> Committer: Claes Redestad <redestad(a)openjdk.org> Date: 2024-08-16 13:18:02 +0000 URL: https://git.openjdk.org/leyden/commit/5022109b2a33a8cf2608eb829098b27641b73… 8336856: Efficient hidden class-based string concatenation strategy Co-authored-by: Claes Redestad <redestad(a)openjdk.org> Reviewed-by: redestad, liach ! src/java.base/share/classes/java/lang/StringConcatHelper.java ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java ! src/java.base/share/classes/jdk/internal/util/ClassFileDumper.java + test/jdk/java/lang/String/concat/HiddenClassUnloading.java ! test/micro/org/openjdk/bench/java/lang/StringConcat.java ! test/micro/org/openjdk/bench/java/lang/StringConcatStartup.java Changeset: 07352c67 Branch: premain Author: Pavel Rappo <prappo(a)openjdk.org> Date: 2024-08-16 14:06:10 +0000 URL: https://git.openjdk.org/leyden/commit/07352c67448f3f35827395c83ac95e3ca0e4c… 8338398: Trivially fix grammar and typos Reviewed-by: aivanov ! src/java.base/share/classes/java/util/concurrent/CompletableFuture.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinTask.java Changeset: 961e944f Branch: premain Author: Chen Liang <liach(a)openjdk.org> Date: 2024-08-16 15:48:54 +0000 URL: https://git.openjdk.org/leyden/commit/961e944fa731dc84be2764c01e4b326187474… 8336754: Remodel TypeAnnotation to "has" instead of "be" an Annotation Co-authored-by: Alex Buckley <abuckley(a)openjdk.org> Reviewed-by: asotona ! src/java.base/share/classes/java/lang/classfile/Annotation.java ! src/java.base/share/classes/java/lang/classfile/AnnotationElement.java ! src/java.base/share/classes/java/lang/classfile/AnnotationValue.java ! src/java.base/share/classes/java/lang/classfile/TypeAnnotation.java ! src/java.base/share/classes/jdk/internal/classfile/impl/AbstractAttributeMapper.java ! src/java.base/share/classes/jdk/internal/classfile/impl/AnnotationReader.java ! src/java.base/share/classes/jdk/internal/classfile/impl/ClassPrinterImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/ClassRemapperImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/UnboundAttribute.java ! src/java.base/share/classes/jdk/internal/classfile/impl/verifier/ParserVerifier.java ! src/jdk.jdeps/share/classes/com/sun/tools/javap/AnnotationWriter.java ! test/jdk/jdk/classfile/ClassPrinterTest.java ! test/jdk/jdk/classfile/TransformTests.java ! test/jdk/jdk/classfile/helpers/ClassRecord.java ! test/jdk/jdk/classfile/helpers/RebuildingTransformation.java ! test/langtools/lib/annotations/annotations/classfile/ClassfileInspector.java ! test/langtools/tools/javac/annotations/typeAnnotations/classfile/AnonymousClassTest.java ! test/langtools/tools/javac/annotations/typeAnnotations/referenceinfos/ReferenceInfoUtil.java ! test/langtools/tools/javac/patterns/Annotations.java ! test/langtools/tools/javac/records/RecordCompilationTests.java Changeset: 8635642d Branch: premain Author: Chris Plummer <cjplummer(a)openjdk.org> Date: 2024-08-16 16:39:36 +0000 URL: https://git.openjdk.org/leyden/commit/8635642dbdfb74d2ae50a51611fd2c5980fe6… 8338469: com/sun/jdi/DataDumpTest.java failed with Not a debuggee, or not listening for debugger to attach Reviewed-by: dcubed ! test/jdk/com/sun/jdi/DataDumpTest.java Changeset: 2f7ba781 Branch: premain Author: SendaoYan <syan(a)openjdk.org> Committer: Jaikiran Pai <jpai(a)openjdk.org> Date: 2024-08-19 04:44:24 +0000 URL: https://git.openjdk.org/leyden/commit/2f7ba781bf2e4e6d0fa658c19f86c6c05d603… 8335150: Test LogGeneratedClassesTest.java fails on rpmbuild mock enviroment Reviewed-by: jpai ! test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java Changeset: 56a007dd Branch: premain Author: Tejesh R <tr(a)openjdk.org> Date: 2024-08-19 06:42:51 +0000 URL: https://git.openjdk.org/leyden/commit/56a007dd32061695d7bb0faf47e1793728e86… 8338488: Add screen capture for failure case Reviewed-by: azvegint ! test/jdk/java/awt/Checkbox/CheckboxCheckerScalingTest.java Changeset: 15b20cb1 Branch: premain Author: Manukumar V S <mvs(a)openjdk.org> Committer: Tejesh R <tr(a)openjdk.org> Date: 2024-08-19 07:17:37 +0000 URL: https://git.openjdk.org/leyden/commit/15b20cb1fd18b849e49c175737dd3826c8d0c… 8337886: java/awt/Frame/MaximizeUndecoratedTest.java fails in OEL due to a slight color difference Reviewed-by: dnguyen, honkar, serb ! test/jdk/java/awt/Frame/MaximizeUndecoratedTest.java Changeset: f0374a0b Branch: premain Author: Andrew Dinn <adinn(a)openjdk.org> Date: 2024-08-19 09:00:19 +0000 URL: https://git.openjdk.org/leyden/commit/f0374a0bc181d0f2a8c0aa9aa032b07998ffa… 8337987: Relocate jfr and throw_exception stubs from StubGenerator to SharedRuntime Reviewed-by: fyang, kvn, yzheng ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/methodHandles_aarch64.cpp ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/arm/methodHandles_arm.cpp ! src/hotspot/cpu/arm/sharedRuntime_arm.cpp ! src/hotspot/cpu/arm/stubGenerator_arm.cpp ! src/hotspot/cpu/arm/templateInterpreterGenerator_arm.cpp ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp ! src/hotspot/cpu/ppc/methodHandles_ppc.cpp ! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp ! src/hotspot/cpu/ppc/stubGenerator_ppc.cpp ! src/hotspot/cpu/ppc/templateInterpreterGenerator_ppc.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/methodHandles_riscv.cpp ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp ! src/hotspot/cpu/riscv/stubGenerator_riscv.cpp ! src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp ! src/hotspot/cpu/s390/macroAssembler_s390.cpp ! src/hotspot/cpu/s390/methodHandles_s390.cpp ! src/hotspot/cpu/s390/sharedRuntime_s390.cpp ! src/hotspot/cpu/s390/stubGenerator_s390.cpp ! src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/methodHandles_x86.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_32.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.hpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/cpu/zero/sharedRuntime_zero.cpp ! src/hotspot/cpu/zero/stubGenerator_zero.cpp ! src/hotspot/share/jvmci/jvmciCompilerToVM.hpp ! src/hotspot/share/jvmci/jvmciCompilerToVMInit.cpp ! src/hotspot/share/jvmci/vmStructs_jvmci.cpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/hotspot/share/runtime/stubRoutines.hpp Changeset: 6d430f24 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-19 09:08:54 +0000 URL: https://git.openjdk.org/leyden/commit/6d430f24df9d599fe1e12c6b65117c02773ae… 8338314: JFR: Split JFRCheckpoint VM operation Reviewed-by: mgronlun, egahlin ! src/hotspot/share/jfr/recorder/service/jfrRecorderService.cpp ! src/hotspot/share/jfr/recorder/service/jfrRecorderService.hpp ! src/hotspot/share/runtime/vmOperation.hpp Changeset: e07a5b66 Branch: premain Author: Erik Gahlin <egahlin(a)openjdk.org> Date: 2024-08-19 10:42:58 +0000 URL: https://git.openjdk.org/leyden/commit/e07a5b66267156f55ee1c28579382990e58f1… 8338512: JFR: Revert changes to TestCodeSweeper Reviewed-by: mgronlun ! test/jdk/ProblemList.txt ! test/jdk/jdk/jfr/event/compiler/TestCodeSweeper.java Changeset: 6ff6b099 Branch: premain Author: Renjith Kannath Pariyangad <rkannathpari(a)openjdk.org> Date: 2024-08-19 12:40:35 +0000 URL: https://git.openjdk.org/leyden/commit/6ff6b0994380276e0096f7b55a0d659803344… 8290501: Typo in javax.swing.BoundedRangeModel documentation Reviewed-by: aivanov, prr, honkar ! src/java.desktop/share/classes/javax/swing/BoundedRangeModel.java Changeset: f0fe3138 Branch: premain Author: Adam Sotona <asotona(a)openjdk.org> Date: 2024-08-19 12:57:17 +0000 URL: https://git.openjdk.org/leyden/commit/f0fe31383aec652ad4e3cc4873cd3ff9b918f… 8338564: Remove obsolete AbstractNamedEntry::equals method Reviewed-by: liach ! src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java Changeset: 2766b09e Branch: premain Author: Alan Bateman <alanb(a)openjdk.org> Committer: Jaikiran Pai <jpai(a)openjdk.org> Date: 2024-08-19 12:57:29 +0000 URL: https://git.openjdk.org/leyden/commit/2766b09e29d7c1c31fdef20f016a181eedb2d… 8338452: (dc) DatagramChannelImpl.blockingReceive with timeout may block indefinitely if all datagrams blocked by SecurityManager Reviewed-by: dfuchs ! src/java.base/share/classes/sun/nio/ch/DatagramChannelImpl.java Changeset: 3ca359ad Branch: premain Author: Daniel Fuchs <dfuchs(a)openjdk.org> Date: 2024-08-19 13:47:40 +0000 URL: https://git.openjdk.org/leyden/commit/3ca359ad224b07f283c99eb43bed02eb93ef2… 8335771: Improve stability of java/nio/channels/DatagramChannel tests Reviewed-by: alanb ! test/jdk/java/nio/channels/DatagramChannel/AdaptorMulticasting.java ! test/jdk/java/nio/channels/DatagramChannel/AfterDisconnect.java ! test/jdk/java/nio/channels/DatagramChannel/Connect.java ! test/jdk/java/nio/channels/DatagramChannel/ManySourcesAndTargets.java ! test/jdk/java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java ! test/jdk/java/nio/channels/DatagramChannel/NotBound.java ! test/jdk/java/nio/channels/DatagramChannel/Promiscuous.java ! test/jdk/java/nio/channels/DatagramChannel/ReceiveISA.java ! test/jdk/java/nio/channels/DatagramChannel/SelectWhenRefused.java ! test/jdk/java/nio/channels/DatagramChannel/SendReceiveMaxSize.java ! test/jdk/java/nio/channels/DatagramChannel/Sender.java Changeset: 6460b300 Branch: premain Author: Damon Nguyen <dnguyen(a)openjdk.org> Date: 2024-08-19 16:43:43 +0000 URL: https://git.openjdk.org/leyden/commit/6460b300487071bcf98f5ac70d9c0a6fd6b94… 8321140: Add comment to note difference in Metal's JButton margins Reviewed-by: honkar, aivanov ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicLookAndFeel.java ! src/java.desktop/share/classes/javax/swing/plaf/metal/MetalLookAndFeel.java Changeset: c7690c34 Branch: premain Author: Hannes Wallnöfer <hannesw(a)openjdk.org> Date: 2024-08-19 17:47:25 +0000 URL: https://git.openjdk.org/leyden/commit/c7690c34c2d7bff11501188266b7be7a486c1… 8338190: TOC vertical offsets not updated when document size changes Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/script.js.template Changeset: 55851a31 Branch: premain Author: Hannes Wallnöfer <hannesw(a)openjdk.org> Date: 2024-08-19 18:05:37 +0000 URL: https://git.openjdk.org/leyden/commit/55851a312baaea5af14c04fb1b436313fe0de… 8281533: Odd "preview" label in link/linkplain Reviewed-by: jjg ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlLinkFactory.java ! src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/taglets/LinkTaglet.java ! test/langtools/jdk/javadoc/doclet/testPreview/TestPreview.java ! test/langtools/jdk/javadoc/doclet/testPreview/api/preview/Core.java Changeset: 68d1f5c3 Branch: premain Author: Chen Liang <liach(a)openjdk.org> Date: 2024-08-20 05:43:04 +0000 URL: https://git.openjdk.org/leyden/commit/68d1f5c33bf3f64f44f8a10c2f9e4007cfd07… 8338543: ClassBuilder withMethod builders should cache the method type symbol Reviewed-by: asotona ! src/java.base/share/classes/java/lang/classfile/ClassBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/ChainedClassBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/DirectClassBuilder.java Changeset: 9775d571 Branch: premain Author: Stefan Karlsson <stefank(a)openjdk.org> Date: 2024-08-20 06:15:56 +0000 URL: https://git.openjdk.org/leyden/commit/9775d57168695dc0d758e017fe5069d93d593… 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods Co-authored-by: David Holmes <dholmes(a)openjdk.org> Reviewed-by: lmesnik, dcubed, dholmes ! src/hotspot/share/services/classLoadingService.cpp ! src/hotspot/share/services/classLoadingService.hpp ! src/hotspot/share/services/memoryService.cpp ! src/hotspot/share/services/memoryService.hpp + test/jdk/java/lang/management/ClassLoadingMXBean/TestVerboseClassLoading.java + test/jdk/java/lang/management/MemoryMXBean/TestVerboseMemory.java Changeset: b9d49dce Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-20 08:40:45 +0000 URL: https://git.openjdk.org/leyden/commit/b9d49dcef22ab81a087d890bbac0329a5244a… 8337981: ShenandoahHeap::is_in should check for alive regions Reviewed-by: rkennke, wkemper ! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp ! src/hotspot/share/gc/shenandoah/shenandoahAsserts.hpp ! src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahForwarding.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkBitMap.cpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.hpp ! src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.inline.hpp ! src/hotspot/share/gc/shenandoah/shenandoahReferenceProcessor.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Changeset: 89ca5b6f Branch: premain Author: Amit Kumar <amitkumar(a)openjdk.org> Date: 2024-08-20 09:54:20 +0000 URL: https://git.openjdk.org/leyden/commit/89ca5b6fbd82f00375b4f96b2f3526078088d… 8338365: [PPC64, s390] Out-of-bounds array access in secondary_super_cache Reviewed-by: mdoerr, aph, rrich ! src/hotspot/cpu/ppc/macroAssembler_ppc.cpp ! src/hotspot/cpu/s390/macroAssembler_s390.cpp Changeset: 7933e45c Branch: premain Author: Matthias Baesken <mbaesken(a)openjdk.org> Date: 2024-08-20 10:43:16 +0000 URL: https://git.openjdk.org/leyden/commit/7933e45cda7e3eaeabd3b3fa81492ade8e1cc… 8338550: Do libubsan1 installation in test container only if requested Reviewed-by: sgehwolf ! test/lib/jdk/test/lib/containers/docker/DockerTestUtils.java ! test/lib/jdk/test/lib/containers/docker/DockerfileConfig.java Changeset: 01d03e07 Branch: premain Author: Darragh Clarke <dclarke(a)openjdk.org> Date: 2024-08-20 11:10:18 +0000 URL: https://git.openjdk.org/leyden/commit/01d03e07c7642e148e4e17848d28686858ea3… 8324209: Check implementation of Expect: 100-continue in the java.net.http.HttpClient Reviewed-by: dfuchs, jpai ! src/java.net.http/share/classes/jdk/internal/net/http/Exchange.java ! src/java.net.http/share/classes/jdk/internal/net/http/ExchangeImpl.java ! src/java.net.http/share/classes/jdk/internal/net/http/Stream.java ! test/jdk/java/net/httpclient/ExpectContinueTest.java Changeset: 686eb233 Branch: premain Author: Jaikiran Pai <jpai(a)openjdk.org> Date: 2024-08-20 12:28:56 +0000 URL: https://git.openjdk.org/leyden/commit/686eb233d59ab72e872b8dc32cb14bf74519e… 8336817: Several methods on DatagramSocket and MulticastSocket do not specify behaviour when already closed or connected Reviewed-by: dfuchs, alanb ! src/java.base/share/classes/java/net/DatagramSocket.java ! src/java.base/share/classes/java/net/MulticastSocket.java Changeset: bc2700b7 Branch: premain Author: George Adams <gdams(a)openjdk.org> Committer: Magnus Ihse Bursie <ihse(a)openjdk.org> Date: 2024-08-20 14:38:31 +0000 URL: https://git.openjdk.org/leyden/commit/bc2700b7dc6039e2a17124a0ca32780383c4a… 8282944: GHA: Add Alpine Linux x86_64 pre-integration check Reviewed-by: ihse ! .github/actions/config/action.yml + .github/workflows/build-alpine-linux.yml ! .github/workflows/main.yml ! make/conf/github-actions.conf Changeset: b4420030 Branch: premain Author: Chen Liang <liach(a)openjdk.org> Date: 2024-08-20 14:44:37 +0000 URL: https://git.openjdk.org/leyden/commit/b442003048559fc35cafddb62885d3ba75b70… 8338623: StackCounter adding extraneous slots for receiver invoke instructions Reviewed-by: asotona ! src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java ! test/jdk/jdk/classfile/StackMapsTest.java Changeset: 55a97ec8 Branch: premain Author: Christian Hagedorn <chagedorn(a)openjdk.org> Date: 2024-08-20 15:47:16 +0000 URL: https://git.openjdk.org/leyden/commit/55a97ec8793242c0cacbafd3a4fead25cdce2… 8336729: C2: Div/Mod nodes without zero check could be split through iv phi of outer loop of long counted loop nest resulting in SIGFPE Co-authored-by: Emanuel Peter <epeter(a)openjdk.org> Reviewed-by: epeter, kvn, thartmann ! src/hotspot/share/opto/loopnode.hpp ! src/hotspot/share/opto/loopopts.cpp ! test/hotspot/jtreg/compiler/splitif/TestSplitDivisionThroughPhi.java Changeset: 285ceb9e Branch: premain Author: Vladimir Petko <vpetko(a)openjdk.org> Date: 2024-08-20 15:51:40 +0000 URL: https://git.openjdk.org/leyden/commit/285ceb9ee51e064687da6fc3fbed984e34cf0… 8336529: (fs) UnixFileAttributeViews setTimes() failing on armhf, Ubuntu noble Reviewed-by: bpb, alanb ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Changeset: c646efc3 Branch: premain Author: Leonid Mesnik <lmesnik(a)openjdk.org> Date: 2024-08-20 18:41:15 +0000 URL: https://git.openjdk.org/leyden/commit/c646efc366342564baebd2f17133e14780abc… 8205957: setfldw001/TestDescription.java fails with bad field value Reviewed-by: sspitsyn, dlong ! src/hotspot/share/runtime/javaCalls.cpp ! test/hotspot/jtreg/ProblemList-Xcomp.txt ! test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetFieldModificationWatch/setfmodw001/TestDescription.java Changeset: 0267284c Branch: premain Author: Mark Reinhold <mr(a)openjdk.org> Date: 2024-08-20 18:50:17 +0000 URL: https://git.openjdk.org/leyden/commit/0267284c52a450afaec78a542910381f5bff5… 8338611: java.lang.module specification wording not aligned with JEP 261 Reviewed-by: alanb ! src/java.base/share/classes/java/lang/module/package-info.java Changeset: 1ebf2cf6 Branch: premain Author: Chen Liang <liach(a)openjdk.org> Date: 2024-08-20 19:02:38 +0000 URL: https://git.openjdk.org/leyden/commit/1ebf2cf639300728ffc024784f5dc1704317b… 8336756: Improve ClassFile Annotation writing Reviewed-by: asotona ! src/java.base/share/classes/java/lang/classfile/AnnotationValue.java ! src/java.base/share/classes/jdk/internal/classfile/impl/AnnotationImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/AnnotationReader.java Changeset: d7281079 Branch: premain Author: Chris Plummer <cjplummer(a)openjdk.org> Date: 2024-08-20 23:34:31 +0000 URL: https://git.openjdk.org/leyden/commit/d72810794bf70f82e46f7220698e4d27d5973… 8338482: com/sun/jdi/ThreadMemoryLeakTest.java requires that compressed oops are enabled Reviewed-by: amenkov, kevinw ! test/jdk/com/sun/jdi/ThreadMemoryLeakTest.java Changeset: 88ccbb60 Branch: premain Author: Chen Liang <liach(a)openjdk.org> Date: 2024-08-21 01:05:41 +0000 URL: https://git.openjdk.org/leyden/commit/88ccbb60919e4523064b0da17184eedcd9efa… 8336934: Clean up JavaLangReflectAccess Reviewed-by: rriggs, darcy ! src/java.base/share/classes/java/lang/reflect/Constructor.java ! src/java.base/share/classes/java/lang/reflect/Method.java ! src/java.base/share/classes/java/lang/reflect/ReflectAccess.java ! src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java ! src/java.base/share/classes/jdk/internal/access/SharedSecrets.java ! src/java.base/share/classes/jdk/internal/reflect/ReflectionFactory.java Changeset: cafb3dc4 Branch: premain Author: Prasanta Sadhukhan <psadhukhan(a)openjdk.org> Date: 2024-08-21 07:04:05 +0000 URL: https://git.openjdk.org/leyden/commit/cafb3dc49157daf12c1a0e5d78acca8188c56… 6318027: BasicScrollBarUI does not disable timer when enclosing frame is disabled. Reviewed-by: abhiscxk, tr ! src/java.desktop/macosx/classes/com/apple/laf/AquaScrollBarUI.java ! src/java.desktop/share/classes/javax/swing/plaf/basic/BasicScrollBarUI.java + test/jdk/javax/swing/JScrollBar/DisableFrameFromScrollBar.java Changeset: 59816975 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-21 08:17:01 +0000 URL: https://git.openjdk.org/leyden/commit/598169756c903bb1f77e35ea32717043bc166… 8337828: CDS: Trim down minimum GC region alignment Reviewed-by: iklam, phh ! src/hotspot/share/cds/archiveHeapWriter.hpp Changeset: e88a3b05 Branch: premain Author: Adam Sotona <asotona(a)openjdk.org> Date: 2024-08-21 08:19:35 +0000 URL: https://git.openjdk.org/leyden/commit/e88a3b0574c0a6c6acb5faf7b67674d5b7f07… 8338661: StackMapTable is invalid if frames appear in dead code Reviewed-by: liach ! src/java.base/share/classes/jdk/internal/classfile/impl/AttributeHolder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java ! test/jdk/jdk/classfile/StackMapsTest.java ! test/micro/org/openjdk/bench/jdk/classfile/CodeAttributeTools.java Changeset: 715fa8f9 Branch: premain Author: Lutz Schmidt <lucy(a)openjdk.org> Date: 2024-08-21 08:23:31 +0000 URL: https://git.openjdk.org/leyden/commit/715fa8f9fe7242e86b985aece3d078b226f53… 8336498: [macos] [build]: install-file macro may run into permission denied error Reviewed-by: clanger, erikj ! make/common/FileUtils.gmk Changeset: c4cf1e93 Branch: premain Author: Gui Cao <gcao(a)openjdk.org> Committer: Hamlin Li <mli(a)openjdk.org> Date: 2024-08-21 08:58:40 +0000 URL: https://git.openjdk.org/leyden/commit/c4cf1e93bb22bf7c65ce1943fff91f7483943… 8338539: New Object to ObjectMonitor mapping: riscv64 implementation Reviewed-by: fyang, rehn, mli ! src/hotspot/cpu/riscv/c1_MacroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/c2_MacroAssembler_riscv.hpp ! src/hotspot/cpu/riscv/interp_masm_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.cpp ! src/hotspot/cpu/riscv/macroAssembler_riscv.hpp ! src/hotspot/cpu/riscv/riscv.ad ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp ! src/hotspot/share/runtime/basicLock.inline.hpp Changeset: 7458952d Branch: premain Author: Hamlin Li <mli(a)openjdk.org> Date: 2024-08-21 10:17:51 +0000 URL: https://git.openjdk.org/leyden/commit/7458952dedc0a34b5c7f3e9e228f9b18e08f1… 8338595: Add more linesize for MIME decoder in macro bench test Base64Decode Reviewed-by: rehn ! test/micro/org/openjdk/bench/java/util/Base64Decode.java Changeset: 80adea8e Branch: premain Author: Chen Liang <liach(a)openjdk.org> Date: 2024-08-21 11:58:21 +0000 URL: https://git.openjdk.org/leyden/commit/80adea8e0ab3753c3623267c6a2bd3eaed69a… 8338545: Functional interface implementations for common pre-boot ClassFile operations Reviewed-by: asotona ! src/java.base/share/classes/java/lang/classfile/ClassBuilder.java ! src/java.base/share/classes/java/lang/invoke/ClassSpecializer.java ! src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/java.base/share/classes/jdk/internal/classfile/impl/BufferedCodeBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/BufferedFieldBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/BufferedMethodBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/CodeImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/FieldImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/MethodImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/Util.java Changeset: 918cf114 Branch: premain Author: Albert Mingkun Yang <ayang(a)openjdk.org> Date: 2024-08-21 12:01:57 +0000 URL: https://git.openjdk.org/leyden/commit/918cf114548d0098cf6a8a50032b78ee04d45… 8338490: Serial: Move Generation::print_on to subclasses Reviewed-by: gli ! src/hotspot/share/gc/serial/defNewGeneration.cpp ! src/hotspot/share/gc/serial/defNewGeneration.hpp ! src/hotspot/share/gc/serial/generation.cpp ! src/hotspot/share/gc/serial/generation.hpp ! src/hotspot/share/gc/serial/serialHeap.cpp ! src/hotspot/share/gc/serial/tenuredGeneration.cpp ! src/hotspot/share/gc/serial/tenuredGeneration.hpp Changeset: 3aeb6733 Branch: premain Author: Shaojin Wen <shaojin.wensj(a)alibaba-inc.com> Committer: Chen Liang <liach(a)openjdk.org> Date: 2024-08-21 14:56:30 +0000 URL: https://git.openjdk.org/leyden/commit/3aeb6733f958bc2b0132494b8ac51a4cfa6b9… 8338532: Speed up the ClassFile API MethodTypeDesc#ofDescriptor Reviewed-by: redestad, liach ! src/java.base/share/classes/java/lang/constant/ClassDesc.java ! src/java.base/share/classes/java/lang/constant/ConstantDescs.java ! src/java.base/share/classes/java/lang/invoke/ConstantBootstraps.java ! src/java.base/share/classes/jdk/internal/constant/ConstantUtils.java ! src/java.base/share/classes/jdk/internal/constant/MethodTypeDescImpl.java ! src/java.base/share/classes/jdk/internal/constant/PrimitiveClassDescImpl.java ! src/java.base/share/classes/jdk/internal/constant/ReferenceClassDescImpl.java ! src/java.base/share/classes/sun/invoke/util/Wrapper.java ! test/jdk/java/lang/constant/boottest/java.base/jdk/internal/constant/ConstantUtilsTest.java ! test/micro/org/openjdk/bench/java/lang/constant/MethodTypeDescFactories.java ! test/micro/org/openjdk/bench/java/lang/invoke/Wrappers.java Changeset: 0e8fe355 Branch: premain Author: Maurizio Cimadamore <mcimadamore(a)openjdk.org> Date: 2024-08-21 15:11:32 +0000 URL: https://git.openjdk.org/leyden/commit/0e8fe3550b628c6617ac7593d7e17ef7d9bc0… 8338677: Improve startup of memory access var handles by simplifying combinator chains Reviewed-by: redestad ! src/java.base/share/classes/java/lang/invoke/X-VarHandleSegmentView.java.template ! src/java.base/share/classes/jdk/internal/foreign/AbstractMemorySegmentImpl.java ! src/java.base/share/classes/jdk/internal/foreign/LayoutPath.java ! src/java.base/share/classes/jdk/internal/foreign/Utils.java Changeset: e297e881 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-21 16:10:41 +0000 URL: https://git.openjdk.org/leyden/commit/e297e8817f486e4af850c97fcff859c3e9a9e… 8338688: Shenandoah: Avoid calling java_lang_Class accessors in asserts/verifier Reviewed-by: rkennke, wkemper ! src/hotspot/share/gc/shenandoah/shenandoahAsserts.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp Changeset: ab8071d2 Branch: premain Author: Doug Lea <dl(a)openjdk.org> Date: 2024-08-21 18:22:24 +0000 URL: https://git.openjdk.org/leyden/commit/ab8071d28027ecbf5e8984c30b35fa1c2d934… 8338146: Improve Exchanger performance with VirtualThreads Reviewed-by: alanb ! src/java.base/share/classes/java/util/concurrent/Exchanger.java ! src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java ! src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java Changeset: 47c8a6a8 Branch: premain Author: Claes Redestad <redestad(a)openjdk.org> Date: 2024-08-21 22:10:06 +0000 URL: https://git.openjdk.org/leyden/commit/47c8a6a8db979fe862be876008feb76cdc9dc… 8333265: De-duplicate method references in java.util.stream.FindOps Reviewed-by: liach ! src/java.base/share/classes/java/util/stream/FindOps.java ! test/micro/org/openjdk/bench/java/util/stream/ops/ref/FindAny.java Changeset: 1d05989b Branch: premain Author: Axel Boldt-Christmas <aboldtch(a)openjdk.org> Date: 2024-08-22 06:23:06 +0000 URL: https://git.openjdk.org/leyden/commit/1d05989bb4bcc08ef6f7c408ec987ea43995e… 8334357: Use NonInterleavingLogStream for report_metadata_oome Reviewed-by: jsjolen, stuefe ! src/hotspot/share/memory/metaspace.cpp Changeset: 6644dd33 Branch: premain Author: Hamlin Li <mli(a)openjdk.org> Date: 2024-08-22 07:22:35 +0000 URL: https://git.openjdk.org/leyden/commit/6644dd33f6f4b440105d84ef187a0ff6b1d60… 8338760: Adjust the comment after UseObjectMonitorTable Reviewed-by: coleenp, dcubed ! src/hotspot/share/oops/markWord.hpp Changeset: 129f527f Branch: premain Author: Magnus Ihse Bursie <ihse(a)openjdk.org> Date: 2024-08-22 10:31:34 +0000 URL: https://git.openjdk.org/leyden/commit/129f527f4f6de04897440a11f0be024f1a378… 8338290: Xcode project generator for hotspot Co-authored-by: Gerard Ziemski <gziemski(a)openjdk.org> Co-authored-by: Magnus Ihse Bursie <ihse(a)openjdk.org> Reviewed-by: azafari, erikj ! make/Main.gmk ! make/common/FileUtils.gmk ! make/common/NativeCompilation.gmk ! make/common/native/Link.gmk ! make/ide/visualstudio/hotspot/CreateVSProject.gmk + make/ide/xcode/hotspot/CreateXcodeProject.gmk + make/ide/xcode/hotspot/data/Breakpoints_v2.xcbkptlist.template + make/ide/xcode/hotspot/data/jvm.xcscheme.template + make/ide/xcode/hotspot/data/project.pbxproj.template + make/ide/xcode/hotspot/data/runJ2Demo.xcscheme.template + make/ide/xcode/hotspot/data/script_after.sh + make/ide/xcode/hotspot/data/script_before.sh + make/ide/xcode/hotspot/src/classes/DiskFile.java + make/ide/xcode/hotspot/src/classes/XcodeProjectMaker.java ! make/modules/java.base/Copy.gmk Changeset: 6cf7f9c4 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-22 11:39:47 +0000 URL: https://git.openjdk.org/leyden/commit/6cf7f9c4a76b99ed7aa4dc7ee54692331fc73… 8338662: Shenandoah: Remove excessive ShenandoahVerifier::verify_during_evacuation Reviewed-by: wkemper, ysr ! src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahDegeneratedGC.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.cpp ! src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp Changeset: 6041c936 Branch: premain Author: Matias Saavedra Silva <matsaave(a)openjdk.org> Date: 2024-08-22 15:55:02 +0000 URL: https://git.openjdk.org/leyden/commit/6041c936d6dd39c5b3a89ed2823b25a8aef42… 8335664: Parsing jsr broken: assert(bci>= 0 && bci < c->method()->code_size()) failed: index out of bounds Co-authored-by: Emanuel Peter <epeter(a)openjdk.org> Reviewed-by: dlong, thartmann ! src/hotspot/share/oops/generateOopMap.cpp + test/hotspot/jtreg/runtime/interpreter/LastJsr.jasm + test/hotspot/jtreg/runtime/interpreter/LastJsrReachable.jasm + test/hotspot/jtreg/runtime/interpreter/LastJsrTest.java Changeset: 0b5c8870 Branch: premain Author: Matthew Donovan <mdonovan(a)openjdk.org> Date: 2024-08-22 17:58:08 +0000 URL: https://git.openjdk.org/leyden/commit/0b5c8870e5aa4fd0889d60faa9b1f65a9c338… 8338380: Update TLSCommon/interop/AbstractServer to specify an interface to listen for connections Reviewed-by: rhalade ! test/jdk/javax/net/ssl/TLSCommon/interop/AbstractServer.java ! test/jdk/javax/net/ssl/TLSCommon/interop/JdkServer.java Changeset: 813546f9 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Date: 2024-08-22 19:48:25 +0000 URL: https://git.openjdk.org/leyden/commit/813546f9236d278c380888f1f90cd49b23792… 8338856: [BACKOUT] JDK-8337828: CDS: Trim down minimum GC region alignment Reviewed-by: dcubed ! src/hotspot/share/cds/archiveHeapWriter.hpp Changeset: c89a1c35 Branch: premain Author: Brian Burkhalter <bpb(a)openjdk.org> Date: 2024-08-22 21:41:25 +0000 URL: https://git.openjdk.org/leyden/commit/c89a1c35bda9002ee687b3fa267f3ef9cba78… 8338696: (fs) BasicFileAttributes.creationTime() falls back to epoch if birth time is unavailable (Linux) Reviewed-by: sgehwolf, alanb ! src/java.base/unix/native/libnio/fs/UnixNativeDispatcher.c Changeset: 06f6f57b Branch: premain Author: iklam <ilam3388(a)gmail.com> Date: 2024-08-22 15:20:14 +0000 URL: https://git.openjdk.org/leyden/commit/06f6f57b85a7fc0a5af2041dfa9f5760e50eb… Merge branch 'master' of https://github.com/openjdk/leyden into premain ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/s390/stubGenerator_s390.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/cds/archiveHeapWriter.hpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/code/SCCache.cpp ! src/hotspot/share/compiler/compilationPolicy.hpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/parse.hpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/javaThread.cpp ! src/hotspot/share/runtime/javaThread.hpp ! src/hotspot/share/runtime/javaThread.inline.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/hotspot/share/runtime/stubRoutines.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/interp_masm_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/aarch64/templateInterpreterGenerator_aarch64.cpp ! src/hotspot/cpu/s390/stubGenerator_s390.cpp ! src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/stubGenerator_x86_64.cpp ! src/hotspot/cpu/x86/templateInterpreterGenerator_x86.cpp ! src/hotspot/share/c1/c1_Runtime1.cpp ! src/hotspot/share/cds/archiveHeapWriter.hpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/heapShared.hpp + src/hotspot/share/code/SCCache.cpp ! src/hotspot/share/compiler/compilationPolicy.hpp ! src/hotspot/share/interpreter/interpreterRuntime.cpp ! src/hotspot/share/logging/logTag.hpp ! src/hotspot/share/memory/metaspace.cpp ! src/hotspot/share/oops/instanceKlass.hpp ! src/hotspot/share/opto/library_call.cpp ! src/hotspot/share/opto/parse.hpp ! src/hotspot/share/opto/parse1.cpp ! src/hotspot/share/prims/jni.cpp ! src/hotspot/share/prims/jvm.cpp ! src/hotspot/share/runtime/arguments.cpp ! src/hotspot/share/runtime/deoptimization.cpp ! src/hotspot/share/runtime/globals.hpp ! src/hotspot/share/runtime/init.cpp ! src/hotspot/share/runtime/javaThread.cpp ! src/hotspot/share/runtime/javaThread.hpp ! src/hotspot/share/runtime/javaThread.inline.hpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/hotspot/share/runtime/stubRoutines.hpp ! src/hotspot/share/runtime/vmStructs.cpp Changeset: 2d15c193 Branch: premain Author: iklam <ilam3388(a)gmail.com> Date: 2024-08-22 18:32:20 +0000 URL: https://git.openjdk.org/leyden/commit/2d15c1933b36efc78aa3ffc31aca52e7317ef… temp work-around to get premain to work with JDK-8338532 and JDK-8336856; todo -- fix this more properly ! src/hotspot/share/cds/aotLinkedClassBulkLoader.cpp ! src/hotspot/share/cds/classPreinitializer.cpp ! src/hotspot/share/cds/lambdaFormInvokers.cpp ! src/hotspot/share/classfile/systemDictionaryShared.cpp Changeset: a371fddb Branch: premain Author: iklam <ilam3388(a)gmail.com> Date: 2024-08-22 18:32:26 +0000 URL: https://git.openjdk.org/leyden/commit/a371fddb74dd1fbf10da5ead2584723e083cb… Merge branch 'premain' of https://github.com/openjdk/leyden into premain ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/cds/heapShared.hpp

1 0

git: openjdk/leyden: premain: Enable 1-step workflow with Epsilon GC
by duke 22 Aug '24

22 Aug '24

Changeset: 126461c0 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Committer: iklam <ilam3388(a)gmail.com> Date: 2024-08-22 16:07:47 +0000 URL: https://git.openjdk.org/leyden/commit/126461c0ece1fde43799d669d541e1ca254f0… Enable 1-step workflow with Epsilon GC ! README.md ! src/hotspot/share/cds/heapShared.hpp ! src/hotspot/share/cds/metaspaceShared.cpp ! test/hotspot/jtreg/runtime/cds/appcds/leyden/LeydenGCFlags.java

1 0

git: openjdk/leyden: premain: AOT G1 barrier loads region grain and card shifts via runtime constants data area
by duke 21 Aug '24

21 Aug '24

Changeset: c319a3ee Branch: premain Author: Andrew Dinn <adinn(a)redhat.com> Date: 2024-08-21 14:48:22 +0000 URL: https://git.openjdk.org/leyden/commit/c319a3ee2be0236feab88c9be66d71e6e93b5… AOT G1 barrier loads region grain and card shifts via runtime constants data area ! src/hotspot/cpu/aarch64/aarch64.ad ! src/hotspot/cpu/aarch64/c1_LIRAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.cpp ! src/hotspot/cpu/aarch64/macroAssembler_aarch64.hpp ! src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp ! src/hotspot/cpu/x86/c1_LIRAssembler_x86.cpp ! src/hotspot/cpu/x86/gc/g1/g1BarrierSetAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.cpp ! src/hotspot/cpu/x86/macroAssembler_x86.hpp ! src/hotspot/cpu/x86/x86_64.ad ! src/hotspot/share/ci/ciUtilities.cpp ! src/hotspot/share/ci/ciUtilities.hpp ! src/hotspot/share/code/SCCache.cpp ! src/hotspot/share/code/SCCache.hpp ! src/hotspot/share/gc/g1/c1/g1BarrierSetC1.cpp ! src/hotspot/share/gc/g1/c2/g1BarrierSetC2.cpp ! src/hotspot/share/gc/g1/g1BarrierSet.hpp ! src/hotspot/share/gc/shared/barrierSet.hpp ! src/hotspot/share/gc/shared/cardTableBarrierSet.hpp ! src/hotspot/share/runtime/stubRoutines.cpp ! src/hotspot/share/runtime/stubRoutines.hpp

1 0

git: openjdk/leyden: premain: 2 new changesets
by duke 21 Aug '24

21 Aug '24

Changeset: cb30dfbb Branch: premain Author: iklam <ilam3388(a)gmail.com> Date: 2024-08-20 14:10:00 +0000 URL: https://git.openjdk.org/leyden/commit/cb30dfbb8809647dc0b86612b09d3a320e7fd… Renamed -XX:+ArchiveInvokeDynamic to -XX:+AOTInvokeDynamicLinking, and changed to a diagnostic flag ! README.md ! src/hotspot/share/cds/cdsConfig.cpp ! src/hotspot/share/cds/cdsConfig.hpp ! src/hotspot/share/cds/cds_globals.hpp ! src/hotspot/share/cds/filemap.cpp ! src/hotspot/share/cds/filemap.hpp ! test/hotspot/jtreg/premain/InvokeDynamic.md ! test/hotspot/jtreg/premain/javac_new_workflow/README.md ! test/hotspot/jtreg/premain/javac_new_workflow/run.sh ! test/hotspot/jtreg/premain/lib/bench-lib-new-workflow.sh ! test/hotspot/jtreg/premain/lib/bench-lib.sh ! test/hotspot/jtreg/premain/spring-petclinic/Makefile ! test/hotspot/jtreg/premain/spring-petclinic/WarmupMakefile ! test/hotspot/jtreg/runtime/cds/appcds/aotClassLinking/BulkLoaderTest.java ! test/hotspot/jtreg/runtime/cds/appcds/indy/IndyTestBase.java ! test/hotspot/jtreg/runtime/cds/appcds/indy/StringConcatStress2.java ! test/lib/jdk/test/lib/cds/CDSAppTester.java Changeset: 641fdabf Branch: premain Author: iklam <ilam3388(a)gmail.com> Date: 2024-08-20 22:16:58 +0000 URL: https://git.openjdk.org/leyden/commit/641fdabf083ea8b9a46fcd92191482e29cf9d… More clean up of -XX:+AOTInvokeDynamicLinking before upstreaming to mainline ! src/hotspot/share/cds/cdsConfig.cpp ! src/hotspot/share/cds/cdsConfig.hpp ! src/hotspot/share/cds/cdsHeapVerifier.cpp ! src/hotspot/share/cds/dumpTimeClassInfo.cpp ! src/hotspot/share/cds/heapShared.cpp ! src/hotspot/share/cds/metaspaceShared.cpp ! src/hotspot/share/classfile/javaClasses.cpp ! src/hotspot/share/classfile/vmSymbols.hpp ! src/hotspot/share/interpreter/interpreterRuntime.hpp ! src/hotspot/share/oops/constantPool.cpp ! src/hotspot/share/prims/jvm.cpp ! src/java.base/share/classes/java/lang/invoke/DirectMethodHandle.java ! src/java.base/share/classes/java/lang/invoke/LambdaForm.java ! src/java.base/share/classes/java/lang/invoke/MethodHandleStatics.java ! src/java.base/share/classes/java/lang/invoke/MethodType.java ! src/java.base/share/classes/java/lang/invoke/MethodTypeForm.java

1 0

premain: Possible solutions to use runtime G1 region grain size in AOT code (JDK-8335440)
by Andrew Dinn 21 Aug '24

21 Aug '24

I have prototyped two (aarch64-specific) solutions for JDK-8335440 both of which fix the G1 write barrier in AOT code to use the runtime region grain size. Both solutions make AOT code resilient to any change in max heap between assembly and production runs. The problem arises because ergonomics uses the heap size to derive a G1 region size and the latter size determines what shift is needed to convert a store address to a card table index. In currently generated nmethod and *stub* code) the shift count is installed as an immediate operand of a generated shift instruction. In AOT code the shift counts needs to be appropriate to the current runtime region size. AOT code can resolve this requirement in two ways. It can load the shift from a well known location and supply the shift count as a register operand. Alternatively, it can employ load-time rewriting of the instruction stream to update the immediate operand. Both current solutions rely on loading rather than instruction rewriting. The first solution installs the shift count in a (byte) field added to every Java thread. It modifies barrier generation when the SCCache is open for writing to load the shift count from the thread field. This solution requires no relocation when the AOT stub/nmethod is loaded from the cache since the load is always at a fixed offset from the thread register. If the SCCache is not open for writing the count is generated as normal i.e. as an immediate operand. https://github.com/adinn/leyden/compare/premain...adinn:leyden:JDK-8335440-… The second solution modifies barrier generation when the SCCache is open for writing to load the shift count from a runtime field, G1HeapRegion::LogHRGrainSize i.e. the same field that determines the immediate count used for normal generation. In order to make this visible to the compilers and SCC address table the address of this field is exported via the card table. This solution requires the AOT code to reference the target address using a runtime address relocation. Once again, if the SCCache is not open for writing the count is generated as normal i.e. as an immediate operand. https://github.com/adinn/leyden/compare/premain...adinn:leyden:JDK-8335440-… I ran the javac benchmark with each of these solutions compared against the equivalent premain build. Neither indicated any noticeable change in execution time -- at least not within the margins of error of the test runs (which, on my M2 machine were +/- 5 msecs in a 95 msec run). A better test might be to take a long running app and see if the change to the AOT barrier code introduced any change in overall execution time. I implemented these two solutions first because neither of them requires implementing any new relocations. There are two alternatives which would require new relocations that may still be worth investigating. Option three is to mark the shift instruction with a new relocation. Patching of the relocation address would simply require regenerating it with an immediate that matches (log2 of the) current region size. The fourth option is to load the shift count from a data area associated with the current blob. In the case of an nmethod this would be the nmethod constants section. In the case of a generated stub this would have to be a dedicated memory address in its associated blob. Either way the data location would need to be marked with a new relocation. Patching of the relocation address would simply require copying the (log2 of the) current region size ito the data area. I'll hold off on adding these solutions (also on implementing the x86 versions -- well, more likely, letting Ashu provide them ;-) until I get some feedback on these first two. I'll also see if I can get any better indication of whether the performance of the first two solutions is an issue. I think solution one is by far the simplest, resolving the immediate issue with least fuss (note that I poked the necessary data byte into a hole in the thread record so it has no space implications). However, if we end up having to tweak generated code to deal with other config changes the alternatives may be worth investing in as they might scale better. regards, Andrew Dinn -----------

4 22