September 2024 - leyden-dev

RFR: 8293187: Store initialized Enum classes in AOTCache
by ioi.lam＠oracle.com 12 Sep '24

12 Sep '24

Hi, this is the 4th PR for JEP 483 - Ahead-of-Time Class Loading & Linking [1] The PR is https://github.com/openjdk/jdk/pull/20958 The following are added in this PR - support for archiving sun.invoke.util.Wrapper enums. This is a preliminary step for archiving LambdaForms. - the ability to store classes in initialized state. This PR does it for enums and a few other classes. More classes will be added to the aot-init list in subsequent PRs. The plan [2] is to break down JEP 483 in a series of 7 PRs to make it easier to review. I will post the other PRs soon. Thanks - Ioi === [1] https://openjdk.org/jeps/483 [2] https://bugs.openjdk.org/browse/JDK-8331497

1 0

premain: CGLIB error during the training run with Petclinic
by Sebastien Deleuze 11 Sep '24

11 Sep '24

Hi, I may have hit a premain bug using the latest https://github.com/openjdk/leyden/tree/premain that triggers a CGLIB error during the training run with Petclinic, and am looking for feedback. The premain branch of https://github.com/sdeleuze/petclinic-efficient-container currently performs a training run of Petclinic where the application exits early since -Dspring.context.exit=onRefresh is set, no workload is applied, the application then starts again in the production and run faster as expected. All good. In the premain-training-run branch, I directly start Petclinic with -XX:CacheDataStore=/tmp/application.cds in order to have the opportunity to apply some workload to exercise the warm-up improvement capabilities later in the production run. On simple pages like http://localhost:8080/, it works as expected, but when I try more complex pages like http://localhost:8080/owners, It get the following error: Request processing failed: java.lang.RuntimeException: java.lang.IllegalStateException: org.springframework.cglib.core.ReflectUtils$2: No compatible defineClass mechanism detected: JVM should be started with --add-opens=java.base/java.lang=ALL-UNNAMED for ClassLoader.defineClass to be accessible. On the module path, you may not be able to define this CGLIB-generated class at all.] with root cause java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @d5c1bc at java.base/java.lang.reflect.AccessibleObject.throwInaccessibleObjectException(AccessibleObject.java:388) ~[na:na] at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:364) ~[na:na] at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:312) ~[na:na] at java.base/java.lang.reflect.Method.checkCanSetAccessible(Method.java:190) ~[na:na] at java.base/java.lang.reflect.Method.setAccessible(Method.java:184) ~[na:na] at org.springframework.cglib.core.ReflectUtils.defineClass(ReflectUtils.java:505) ~[spring-core-6.2.0-M7.jar:6.2.0-M7] This application does not involve JPMS, it is just a regular Spring Boot application. If I send more requests to the same endpoint, I see the following error: java.lang.VerifyError: Bad local variable type Exception Details: Location: org/springframework/samples/petclinic/owner/Owner_Accessor_82dqis.getProperty(Lorg/springframework/data/mapping/PersistentProperty;)Ljava/lang/Object; @83: aload_2 Reason: Type top (current frame, locals[2]) is not assignable to reference type Current Frame: bci: @83 flags: { } locals: { 'org/springframework/samples/petclinic/owner/Owner_Accessor_82dqis', 'org/springframework/data/mapping/PersistentProperty' } stack: { 'java/lang/invoke/MethodHandle' } To summarize, what I observe in my tests: - http://localhost:8080/owners without -XX:CacheDataStore=/tmp/application.cds works - http://localhost:8080/owners with -XX:CacheDataStore=/tmp/application.cds with an existing /tmp/application.cds file works - http://localhost:8080/owners with -XX:CacheDataStore=/tmp/application.cds with no existing /tmp/application.cds file fails with the error mentioned above Any thoughts? Best regards, Sébastien Deleuze -- This electronic communication and the information and any files transmitted with it, or attached to it, are confidential and are intended solely for the use of the individual or entity to whom it is addressed and may contain information that is confidential, legally privileged, protected by privacy laws, or otherwise restricted from disclosure to anyone else. If you are not the intended recipient or the person responsible for delivering the e-mail to the intended recipient, you are hereby notified that any use, copying, distributing, dissemination, forwarding, printing, or copying of this e-mail is strictly prohibited. If you received this e-mail in error, please return the e-mail to the sender, delete it from your computer, and destroy any printed copy of it.

2 1

RFR: Mark Leyden tests that require artifacts with "external-dep"
by Aleksey Shipilev 10 Sep '24

10 Sep '24

[JDK-8323717](https://bugs.openjdk.org/browse/JDK-8323717) added a new keyword that marks tests that require external artifacts. This allows skipping the tests that would definitely fail without artifact resolution. This PR marks the new Leyden tests. Tested with: $ JTREG_KEYWORDS='!external-dep' CONF=linux-x86_64-server-fastdebug make test TEST=runtime/cds/appcds ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR jtreg:test/hotspot/jtreg/runtime/cds/appcds 288 288 0 0 ============================== ------------- Commit messages: - External-dep Changes: https://git.openjdk.org/leyden/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=leyden&pr=14&range=00 Stats: 16 lines in 4 files changed: 16 ins; 0 del; 0 mod Patch: https://git.openjdk.org/leyden/pull/14.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/14/head:pull/14 PR: https://git.openjdk.org/leyden/pull/14

3 5

git: openjdk/leyden: premain: Mark Leyden tests that require artifacts with "external-dep"
by Ioi Lam 10 Sep '24

10 Sep '24

Changeset: d23b9f2d Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Committer: Ioi Lam <iklam(a)openjdk.org> Date: 2024-09-10 09:17:33 +0000 URL: https://git.openjdk.org/leyden/commit/d23b9f2d5e3523cc547337da59327ed86a605… Mark Leyden tests that require artifacts with "external-dep" Reviewed-by: iklam ! test/hotspot/jtreg/runtime/cds/appcds/applications/HelidonQuickStartSE.java ! test/hotspot/jtreg/runtime/cds/appcds/applications/MicronautFirstApp.java ! test/hotspot/jtreg/runtime/cds/appcds/applications/QuarkusGettingStarted.java ! test/hotspot/jtreg/runtime/cds/appcds/applications/SpringPetClinic.java

1 0

"incompatible property" error when using --add-modules, --add-opens, --add-exports, etc.
by Boyce, Jeffrey 10 Sep '24

10 Sep '24

Hello, I am attempting to evaluate performance improvements afforded by the Leyden CDS enhancements for an embedded application running on aarch64. The application makes extensive use of the --add-modules, --add-opens, and --add-exports command line arguments. However, it appears that these arguments are incompatible with the -XX:CacheDataStore option, as their use results in errors similar to the following: [0.004s][warning][cds] optimized module handling/full module graph: disabled due to incompatible property: jdk.module.addopens=java.base/java.nio=org.apache.tomcat.embed.core Error occurred during initialization of VM CacheDataStore cannot be created because AOTClassLinking is enabled but full module graph is disabled Is this the expected behavior? If yes, is there a workaround or a plan to support these options in the future? Thanks, Jeff Boyce

2 1

git: openjdk/leyden: premain: Improve incapsulation
by duke 08 Sep '24

08 Sep '24

Changeset: 5fd814c0 Branch: premain Author: Igor Veresov <igor.veresov(a)oracle.com> Date: 2024-09-08 12:29:20 +0000 URL: https://git.openjdk.org/leyden/commit/5fd814c0f805f63d7920d3da34b0c6b7b5381… Improve incapsulation ! src/hotspot/share/oops/trainingData.cpp ! src/hotspot/share/oops/trainingData.hpp

1 0

RFR: Prefer to take AOT method from the SC queue faster
by Aleksey Shipilev 08 Sep '24

08 Sep '24

Probably WIP. Humor me for a second: why could not / should not we take the AOT task for "compilation" (installation, really) right away like this? I suspect when SC queues are overwhelmed with N elements, we keep walking the entire SC queue for no particular reason? This improves javac benchmark considerably (look at both wall time and user time): # BEFORE Benchmark 1: build/linux-x86_64-server-release/images/jdk/bin/java -XX:CacheDataStore=app.cds -Xmx256m -Xms256m -XX:+UnlockExperimentalVMOptions -XX:+UseEpsilonGC -cp JavacBenchApp.jar JavacBenchApp 50 Time (mean ± σ): 348.3 ms ± 2.8 ms [User: 949.0 ms, System: 101.4 ms] Range (min … max): 344.0 ms … 355.3 ms 100 runs # AFTER Benchmark 1: build/linux-x86_64-server-release/images/jdk/bin/java -XX:CacheDataStore=app.cds -Xmx256m -Xms256m -XX:+UnlockExperimentalVMOptions -XX:+UseEpsilonGC -cp JavacBenchApp.jar JavacBenchApp 50 Time (mean ± σ): 312.2 ms ± 2.6 ms [User: 577.8 ms, System: 95.4 ms] Range (min … max): 307.1 ms … 318.5 ms 100 runs ------------- Commit messages: - Fix Changes: https://git.openjdk.org/leyden/pull/17/files Webrev: https://webrevs.openjdk.org/?repo=leyden&pr=17&range=00 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.org/leyden/pull/17.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/17/head:pull/17 PR: https://git.openjdk.org/leyden/pull/17

3 9

git: openjdk/leyden: premain: Prefer to take AOT method from the SC queue faster
by Vladimir Kozlov 08 Sep '24

08 Sep '24

Changeset: 678b50d1 Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Committer: Vladimir Kozlov <kvn(a)openjdk.org> Date: 2024-09-08 02:40:48 +0000 URL: https://git.openjdk.org/leyden/commit/678b50d17a0eb3e0ac9d6476275753feecd1e… Prefer to take AOT method from the SC queue faster Reviewed-by: kvn ! src/hotspot/share/compiler/compilationPolicy.cpp

1 0

git: openjdk/leyden: hermetic-java-runtime: 16 new changesets
by duke 08 Sep '24

08 Sep '24

Changeset: 9e0ccb8b Branch: hermetic-java-runtime Author: Fei Yang <fyang(a)openjdk.org> Date: 2024-09-06 02:01:43 +0000 URL: https://git.openjdk.org/leyden/commit/9e0ccb8bbd01ffbac466288977a770dd09e35… 8339548: GHA: RISC-V: Use Debian snapshot archive for bootstrap Reviewed-by: shade, erikj ! .github/workflows/build-cross-compile.yml Changeset: 7db4d46c Branch: hermetic-java-runtime Author: nelanbu <yagmur.eren(a)oracle.com> Committer: Christian Hagedorn <chagedorn(a)openjdk.org> Date: 2024-09-06 06:44:54 +0000 URL: https://git.openjdk.org/leyden/commit/7db4d46c3904d1a6949f053e6fc5e971cd519… 8330159: [C2] Remove or clarify Compile::init_start Reviewed-by: chagedorn, dlong ! src/hotspot/share/opto/compile.cpp ! src/hotspot/share/opto/compile.hpp ! src/hotspot/share/opto/generateOptoStub.cpp Changeset: a35fd386 Branch: hermetic-java-runtime Author: Adam Sotona <asotona(a)openjdk.org> Date: 2024-09-06 07:43:38 +0000 URL: https://git.openjdk.org/leyden/commit/a35fd3861044bdb8ddae378cb666b3d2e549a… 8339368: Switch targets are not inflated in CodeModel if no StackMap Reviewed-by: liach ! src/java.base/share/classes/jdk/internal/classfile/impl/CodeImpl.java ! test/jdk/jdk/classfile/OneToOneTest.java Changeset: a1eebbdf Branch: hermetic-java-runtime Author: Chen Liang <liach(a)openjdk.org> Date: 2024-09-06 11:42:50 +0000 URL: https://git.openjdk.org/leyden/commit/a1eebbdf8a62b641b765bf4cec5066690c11a… 8339576: Speed up raw bytecode processing in ClassFile API Co-authored-by: Shaojin Wen <swen(a)openjdk.org> Reviewed-by: asotona, redestad ! src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/RawBytecodeHelper.java ! src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java ! src/java.base/share/classes/jdk/internal/classfile/impl/StackMapGenerator.java ! src/java.base/share/classes/jdk/internal/classfile/impl/Util.java ! src/java.base/share/classes/jdk/internal/classfile/impl/verifier/VerificationBytecodes.java ! src/java.base/share/classes/jdk/internal/classfile/impl/verifier/VerifierImpl.java ! test/jdk/jdk/classfile/UtilTest.java ! test/micro/org/openjdk/bench/jdk/classfile/CodeAttributeTools.java Changeset: febbd998 Branch: hermetic-java-runtime Author: Shaojin Wen <swen(a)openjdk.org> Committer: Chen Liang <liach(a)openjdk.org> Date: 2024-09-06 12:01:01 +0000 URL: https://git.openjdk.org/leyden/commit/febbd998ee72054353e816e9b7b588c9ea2c0… 8339168: Optimize ClassFile Util slotSize Reviewed-by: liach, redestad ! src/java.base/share/classes/jdk/internal/classfile/impl/DirectMethodBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/Util.java Changeset: 260908e1 Branch: hermetic-java-runtime Author: Claes Redestad <redestad(a)openjdk.org> Date: 2024-09-06 12:04:38 +0000 URL: https://git.openjdk.org/leyden/commit/260908e16ece7a0a9e6f538273b27c677db4d… 8339592: Simplify and remove unused code in ObjectMethods.<clinit> Reviewed-by: liach ! src/java.base/share/classes/java/lang/runtime/ObjectMethods.java Changeset: cb00333d Branch: hermetic-java-runtime Author: Claes Redestad <redestad(a)openjdk.org> Date: 2024-09-06 12:27:53 +0000 URL: https://git.openjdk.org/leyden/commit/cb00333d6a47760cb2ab17e867ea8dab32289… 8339640: Reduce construction overheads in StringConcatFactory$InlineHiddenClassStrategy Reviewed-by: liach ! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java Changeset: d2b36f09 Branch: hermetic-java-runtime Author: Claes Redestad <redestad(a)openjdk.org> Date: 2024-09-06 12:37:48 +0000 URL: https://git.openjdk.org/leyden/commit/d2b36f09072e03370ee02b063fcc4a1f0e6cb… 8339642: Reduce overheads in InvokerBytecodeGenerator Reviewed-by: liach ! src/java.base/share/classes/java/lang/invoke/InvokerBytecodeGenerator.java ! src/java.base/share/classes/java/lang/invoke/LambdaForm.java Changeset: 9ebc2ecb Branch: hermetic-java-runtime Author: Shaojin Wen <swen(a)openjdk.org> Committer: Chen Liang <liach(a)openjdk.org> Date: 2024-09-06 13:38:22 +0000 URL: https://git.openjdk.org/leyden/commit/9ebc2ecbf613da3bcee1dd5e8920a26d5f6d6… 8339317: Optimize ClassFile writeBuffer Reviewed-by: redestad, liach ! src/java.base/share/classes/jdk/internal/classfile/impl/AbstractAttributeMapper.java ! src/java.base/share/classes/jdk/internal/classfile/impl/AbstractPoolEntry.java ! src/java.base/share/classes/jdk/internal/classfile/impl/BufWriterImpl.java ! src/java.base/share/classes/jdk/internal/classfile/impl/DirectClassBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/DirectCodeBuilder.java ! src/java.base/share/classes/jdk/internal/classfile/impl/SplitConstantPool.java ! src/java.base/share/classes/jdk/internal/classfile/impl/UnboundAttribute.java Changeset: 0df10bbd Branch: hermetic-java-runtime Author: Andrew Dinn <adinn(a)openjdk.org> Date: 2024-09-06 13:57:13 +0000 URL: https://git.openjdk.org/leyden/commit/0df10bbd96df46f23a7f57e5b9455fea41b2b… 8339466: Enumerate shared stubs and define static fields and names via declarations Reviewed-by: kvn, fyang ! src/hotspot/cpu/aarch64/sharedRuntime_aarch64.cpp ! src/hotspot/cpu/arm/sharedRuntime_arm.cpp ! src/hotspot/cpu/ppc/sharedRuntime_ppc.cpp ! src/hotspot/cpu/riscv/sharedRuntime_riscv.cpp ! src/hotspot/cpu/s390/sharedRuntime_s390.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_32.cpp ! src/hotspot/cpu/x86/sharedRuntime_x86_64.cpp ! src/hotspot/cpu/zero/sharedRuntime_zero.cpp ! src/hotspot/share/runtime/sharedRuntime.cpp ! src/hotspot/share/runtime/sharedRuntime.hpp + src/hotspot/share/runtime/stubDeclarations.hpp Changeset: 5b72bbf9 Branch: hermetic-java-runtime Author: Chen Liang <liach(a)openjdk.org> Date: 2024-09-06 14:57:12 +0000 URL: https://git.openjdk.org/leyden/commit/5b72bbf9d4a4c9c966a665c8d48e5f6c0dcdb… 8339519: Remove size field from instructions Reviewed-by: asotona ! src/java.base/share/classes/jdk/internal/classfile/impl/AbstractInstruction.java Changeset: 8e580ec5 Branch: hermetic-java-runtime Author: Jorn Vernee <jvernee(a)openjdk.org> Date: 2024-09-06 17:32:34 +0000 URL: https://git.openjdk.org/leyden/commit/8e580ec5382af1886e1bbf2fda3bce6416ced… 8338123: Linker crash when building a downcall handle with many arguments in x64 Reviewed-by: mcimadamore ! src/hotspot/cpu/x86/downcallLinker_x86_64.cpp ! test/jdk/java/foreign/largestub/TestLargeStub.java Changeset: fbe26293 Branch: hermetic-java-runtime Author: Shaojin Wen <swen(a)openjdk.org> Committer: Chen Liang <liach(a)openjdk.org> Date: 2024-09-06 18:37:29 +0000 URL: https://git.openjdk.org/leyden/commit/fbe2629303bcee5855673b7e37d8c49f19dc9… 8339635: StringConcatFactory optimization for CompactStrings off Reviewed-by: liach ! src/java.base/share/classes/java/lang/System.java ! src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java ! src/java.base/share/classes/jdk/internal/access/JavaLangAccess.java Changeset: deeb09a6 Branch: hermetic-java-runtime Author: Yasumasa Suenaga <ysuenaga(a)openjdk.org> Date: 2024-09-07 05:46:47 +0000 URL: https://git.openjdk.org/leyden/commit/deeb09a640bf693ea130d1283fc010c22f0cf… 8339307: jhsdb jstack could not trace FFM upcall frame Reviewed-by: cjplummer, jvernee ! src/hotspot/share/code/codeBlob.hpp ! src/hotspot/share/runtime/vmStructs.cpp ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeBlob.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/CodeCache.java + src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/code/UpcallStub.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/aarch64/AARCH64Frame.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/ppc64/PPC64Frame.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/riscv64/RISCV64Frame.java ! src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/runtime/x86/X86Frame.java + test/hotspot/jtreg/serviceability/sa/LingeredAppWithFFMUpcall.java + test/hotspot/jtreg/serviceability/sa/TestJhsdbJstackUpcall.java + test/hotspot/jtreg/serviceability/sa/libupcall.c Changeset: f0e84b76 Branch: hermetic-java-runtime Author: Chris Plummer <cjplummer(a)openjdk.org> Date: 2024-09-07 22:20:37 +0000 URL: https://git.openjdk.org/leyden/commit/f0e84b7617aebc421483f36bb7d0b14d0fc39… 8339703: Problem list serviceability/sa/TestJhsdbJstackUpcall.java for generational ZGC Reviewed-by: dholmes ! test/hotspot/jtreg/ProblemList-generational-zgc.txt Changeset: 2e232b06 Branch: hermetic-java-runtime Author: Jiangli Zhou <jianglizhou(a)google.com> Date: 2024-09-07 17:33:47 +0000 URL: https://git.openjdk.org/leyden/commit/2e232b068d488a710bbf334829504d84e1c8e… Merge branch 'master' into hermetic-java-runtime

1 0

git: openjdk/leyden: premain: Rework rich PrintCompilation logs
by Vladimir Kozlov 07 Sep '24

07 Sep '24

Changeset: d7bd0ccc Branch: premain Author: Aleksey Shipilev <shade(a)openjdk.org> Committer: Vladimir Kozlov <kvn(a)openjdk.org> Date: 2024-09-06 22:26:04 +0000 URL: https://git.openjdk.org/leyden/commit/d7bd0cccea97a9cee9810f58e07a5b2d0b474… Rework rich PrintCompilation logs Reviewed-by: kvn ! src/hotspot/share/compiler/compileBroker.cpp ! src/hotspot/share/compiler/compileTask.cpp ! src/hotspot/share/compiler/compileTask.hpp

1 0