/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode(); /** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording(); /** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration(); /** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording(); ------------- Commit messages: - Add AOTMXBean test - Prototype AOTMXBean Changes: https://git.openjdk.org/leyden/pull/52/files Webrev: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=00 Stats: 499 lines in 13 files changed: 497 ins; 0 del; 2 mod Patch: https://git.openjdk.org/leyden/pull/52.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/52/head:pull/52 PR: https://git.openjdk.org/leyden/pull/52
On Wed, 2 Apr 2025 23:17:30 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
For a test case, I think you can make a copy of the following test case, but modify the MyTestApp to call the MX Bean instead. https://github.com/openjdk/leyden/blob/premain/test/hotspot/jtreg/runtime/cd... ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2776567664
On Thu, 3 Apr 2025 18:08:59 GMT, Ioi Lam <iklam@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
For a test case, I think you can make a copy of the following test case, but modify the MyTestApp to call the MX Bean instead.
https://github.com/openjdk/leyden/blob/premain/test/hotspot/jtreg/runtime/cd...
@iklam - added test, as well as testing it stops training, it also tests that all bean methods work as expected in the various aot modes ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2811345223
On Wed, 2 Apr 2025 23:17:30 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean. ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2813468787
On Thu, 17 Apr 2025 16:17:52 GMT, Alan Bateman <alanb@openjdk.org> wrote:
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build? ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2813994577
On Thu, 17 Apr 2025 20:49:41 GMT, Ioi Lam <iklam@openjdk.org> wrote:
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
Both modules export APIs so both modules will be resolved by default when the initial module is the "class path". Running with -Dcom.sun.management.jmxremote doesn't change that. They will also be resolved when the initial module is a named module, e.g. java -m app, even if app doesn't transitively depends on java.management or jdk.management. This is because of services and specifically java.management provides an implementation of JAAS LoginModule that can be used by java.base, and jdk.management provides additional platform MXBeans that can be used by java.management. So nothing here where the initial module or command line options will cause a concern. In any case, I think this MXBean is best prototyped in the jdk.management module, and in the jdk.management package. VirtualThreadSchedulerMXBean was recently added to this module. In JMX speak, that MXBean defines several attributes and an operation to control the scheduler. The proposal in this MXBean maps to 3 attributes and an operation to stop recording. ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2814915857
On Fri, 18 Apr 2025 08:27:49 GMT, Alan Bateman <alanb@openjdk.org> wrote:
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
Both modules export APIs so both modules will be resolved by default when the initial module is the "class path". Running with -Dcom.sun.management.jmxremote doesn't change that.
They will also be resolved when the initial module is a named module, e.g. java -m app, even if app doesn't transitively depends on java.management or jdk.management. This is because of services and specifically java.management provides an implementation of JAAS LoginModule that can be used by java.base, and jdk.management provides additional platform MXBeans that can be used by java.management.
So nothing here where the initial module or command line options will cause a concern.
In any case, I think this MXBean is best prototyped in the jdk.management module, and in the jdk.management package. VirtualThreadSchedulerMXBean was recently added to this module. In JMX speak, that MXBean defines several attributes and an operation to control the scheduler. The proposal in this MXBean maps to 3 attributes and an operation to stop recording.
@AlanBateman / @iklam - thank you for the review and recommendations. I've updated this PR with changes to move the MXBean from java.management to jdk.management ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2843786109
On Fri, 18 Apr 2025 08:27:49 GMT, Alan Bateman <alanb@openjdk.org> wrote:
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
Both modules export APIs so both modules will be resolved by default when the initial module is the "class path". Running with -Dcom.sun.management.jmxremote doesn't change that.
They will also be resolved when the initial module is a named module, e.g. java -m app, even if app doesn't transitively depends on java.management or jdk.management. This is because of services and specifically java.management provides an implementation of JAAS LoginModule that can be used by java.base, and jdk.management provides additional platform MXBeans that can be used by java.management.
So nothing here where the initial module or command line options will cause a concern.
In any case, I think this MXBean is best prototyped in the jdk.management module, and in the jdk.management package. VirtualThreadSchedulerMXBean was recently added to this module. In JMX speak, that MXBean defines several attributes and an operation to control the scheduler. The proposal in this MXBean maps to 3 attributes and an operation to stop recording.
The module names look good. Perhaps we can have a more descriptive name than AOTMXBean? @AlanBateman any suggestions? ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2852735914
On Fri, 18 Apr 2025 08:27:49 GMT, Alan Bateman <alanb@openjdk.org> wrote:
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
Both modules export APIs so both modules will be resolved by default when the initial module is the "class path". Running with -Dcom.sun.management.jmxremote doesn't change that.
They will also be resolved when the initial module is a named module, e.g. java -m app, even if app doesn't transitively depends on java.management or jdk.management. This is because of services and specifically java.management provides an implementation of JAAS LoginModule that can be used by java.base, and jdk.management provides additional platform MXBeans that can be used by java.management.
So nothing here where the initial module or command line options will cause a concern.
In any case, I think this MXBean is best prototyped in the jdk.management module, and in the jdk.management package. VirtualThreadSchedulerMXBean was recently added to this module. In JMX speak, that MXBean defines several attributes and an operation to control the scheduler. The proposal in this MXBean maps to 3 attributes and an operation to stop recording.
The module names look good. Perhaps we can have a more descriptive name than AOTMXBean? @AlanBateman any suggestions?
Something like "AheadOfTimeCacheMXBean", registered with the MBeanServer as "jdk.management:type=AheadOfTimeCache", might be closer to what you want. An enum could be used to model the modes and that would give you a place to specify them too. Right now the prototype uses a string "representing the current AOT mode" so you would need to search around to know what the modes are. The operation to stop the recording is currently named "endRecording" so there is a mix of "stop" and "end", pick one. The recording duration attribute (getRecordingDuration method) will need to say more. When does recording start, so it this VM uptime? ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2853536633
On Tue, 6 May 2025 07:26:53 GMT, Alan Bateman <alanb@openjdk.org> wrote:
AOT is a JDK feature rather than standard feature so you might want to think of making it JDK specific, in jdk.management, rather than as a standard MXBean.
Is there any difference in terms of visibility between java.management vs jdk.management? Aer both modules visible by default in a standard JDK build?
Both modules export APIs so both modules will be resolved by default when the initial module is the "class path". Running with -Dcom.sun.management.jmxremote doesn't change that.
They will also be resolved when the initial module is a named module, e.g. java -m app, even if app doesn't transitively depends on java.management or jdk.management. This is because of services and specifically java.management provides an implementation of JAAS LoginModule that can be used by java.base, and jdk.management provides additional platform MXBeans that can be used by java.management.
So nothing here where the initial module or command line options will cause a concern.
In any case, I think this MXBean is best prototyped in the jdk.management module, and in the jdk.management package. VirtualThreadSchedulerMXBean was recently added to this module. In JMX speak, that MXBean defines several attributes and an operation to control the scheduler. The proposal in this MXBean maps to 3 attributes and an operation to stop recording.
The module names look good. Perhaps we can have a more descriptive name than AOTMXBean? @AlanBateman any suggestions?
Something like "AheadOfTimeCacheMXBean", registered with the MBeanServer as "jdk.management:type=AheadOfTimeCache", might be closer to what you want.
An enum could be used to model the modes and that would give you a place to specify them too. Right now the prototype uses a string "representing the current AOT mode" so you would need to search around to know what the modes are.
The operation to stop the recording is currently named "endRecording" so there is a mix of "stop" and "end", pick one.
The recording duration attribute (getRecordingDuration method) will need to say more. When does recording start, so it this VM uptime?
@AlanBateman We don't use AheadOfTime in our flags or class names. We use well known acronym AOT. I think we should be consistent everywhere. ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2854952244
On Wed, 2 Apr 2025 23:17:30 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
test/hotspot/jtreg/runtime/cds/appcds/leyden/EndTrainingWithAOTMXBean.java line 77:
75: public String[] vmArgs(RunMode runMode) { 76: return new String[] { 77: "-Xlog:cds+class=debug"
For completeness, I think we should add `"--add-modules=java.management"` to here. ------------- PR Review Comment: https://git.openjdk.org/leyden/pull/52#discussion_r2049634392
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with three additional commits since the last revision: - Merge pull request #3 from macarte/macarte-aotbean-mgmt Moved AOT MXBean from java.lang.management to jdk.management - Removed local test code from previous commit - Moved the AOT bean from java.lang.management to jdk.management ------------- Changes: - all: https://git.openjdk.org/leyden/pull/52/files - new: https://git.openjdk.org/leyden/pull/52/files/bbcc8613..fb71d522 Webrevs: - full: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=01 - incr: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=00-01 Stats: 414 lines in 10 files changed: 183 ins; 228 del; 3 mod Patch: https://git.openjdk.org/leyden/pull/52.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/52/head:pull/52 PR: https://git.openjdk.org/leyden/pull/52
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision: Fixed issues from clean build ------------- Changes: - all: https://git.openjdk.org/leyden/pull/52/files - new: https://git.openjdk.org/leyden/pull/52/files/fb71d522..e6e45373 Webrevs: - full: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=02 - incr: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=01-02 Stats: 4 lines in 2 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.org/leyden/pull/52.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/52/head:pull/52 PR: https://git.openjdk.org/leyden/pull/52
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision: Fixed recording time ------------- Changes: - all: https://git.openjdk.org/leyden/pull/52/files - new: https://git.openjdk.org/leyden/pull/52/files/e6e45373..436b5901 Webrevs: - full: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=03 - incr: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=02-03 Stats: 4 lines in 1 file changed: 1 ins; 0 del; 3 mod Patch: https://git.openjdk.org/leyden/pull/52.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/52/head:pull/52 PR: https://git.openjdk.org/leyden/pull/52
On Thu, 1 May 2025 17:37:22 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Fixed recording time
Okay, but I think the issue with "AOTMXBean" is that it's a management interface AOT cache and recording status, there may be other management interfaces for other aspects to AOT in the future. ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2855155387
On Thu, 1 May 2025 17:37:22 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Fixed recording time
`AheadOfTimeCacheMXBean` is quite a mouthful. “AOT” is a reasonably standard term of art, and will be familar to anyone using the HotSpot AOT CLI options. So why not `AOTCacheMXBean`? ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2855594566
On Thu, 1 May 2025 17:37:22 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Fixed recording time
I am fine with AOTCacheMXBean. ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2856421992
On Thu, 1 May 2025 17:37:22 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Fixed recording time
I've renamed AOT* to AOTCache*; I'm sure we'll go through another round of reviews before it exits premain ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2856531944
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision: Renamed AOT* to AOTCache* ------------- Changes: - all: https://git.openjdk.org/leyden/pull/52/files - new: https://git.openjdk.org/leyden/pull/52/files/436b5901..0419c765 Webrevs: - full: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=04 - incr: https://webrevs.openjdk.org/?repo=leyden&pr=52&range=03-04 Stats: 311 lines in 6 files changed: 145 ins; 145 del; 21 mod Patch: https://git.openjdk.org/leyden/pull/52.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/52/head:pull/52 PR: https://git.openjdk.org/leyden/pull/52
On Tue, 6 May 2025 23:37:10 GMT, Mat Carter <macarte@openjdk.org> wrote:
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Renamed AOT* to AOTCache*
Please also update JBS and PR's Subject to new name. ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2863787008
On Thu, 8 May 2025 17:32:17 GMT, Vladimir Kozlov <kvn@openjdk.org> wrote:
Please also update JBS and PR's Subject to new name.
I hadn't created an issue, but I've added one now and updated the PR title to reflect that ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2864016579
On Tue, 6 May 2025 23:37:10 GMT, Mat Carter <macarte@openjdk.org> wrote:
Adding AOTCacheMXBean as per JBS issue
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Renamed AOT* to AOTCache*
Linked to new issue: https://bugs.openjdk.org/browse/JDK-8356572 ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2863975014
On Tue, 6 May 2025 23:37:10 GMT, Mat Carter <macarte@openjdk.org> wrote:
Adding AOTCacheMXBean as per JBS issue
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Renamed AOT* to AOTCache*
Good. ------------- Marked as reviewed by kvn (Committer). PR Review: https://git.openjdk.org/leyden/pull/52#pullrequestreview-2826188581
On Tue, 6 May 2025 23:37:10 GMT, Mat Carter <macarte@openjdk.org> wrote:
Adding AOTCacheMXBean as per JBS issue
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
Mat Carter has updated the pull request incrementally with one additional commit since the last revision:
Renamed AOT* to AOTCache*
@macarte Your change (at version 0419c7650e8cfcf500d4de30bcba6cc54f0f54f2) is now ready to be sponsored by a Committer. ------------- PR Comment: https://git.openjdk.org/leyden/pull/52#issuecomment-2864121301
On Wed, 2 Apr 2025 23:17:30 GMT, Mat Carter <macarte@openjdk.org> wrote:
Adding AOTCacheMXBean as per JBS issue
/** * Returns the string representing the current AOT mode of * operation. * * @return the string representing the current AOT mode. */ public String getMode();
/** * Tests if a recording is in progress. * * @return {@code true} if a recording is in progress; {@code false} otherwise. */ public boolean isRecording();
/** * If a recording is in progress or has been completed, then returns the duration in milliseconds * * @return duration of the recording in milliseconds. */ public long getRecordingDuration();
/** * If a recording is in progress, then stops the recording. * * @return {@code true} if a recording was stopped; {@code false} otherwise. */ public boolean endRecording();
This pull request has now been integrated. Changeset: fb6d97f2 Author: Mat Carter <macarte@openjdk.org> Committer: Vladimir Kozlov <kvn@openjdk.org> URL: https://git.openjdk.org/leyden/commit/fb6d97f21476bb06f6dacc4d3506105fee4c8d... Stats: 455 lines in 11 files changed: 453 ins; 0 del; 2 mod 8356572: [premain] Add management MXBean for AOT Reviewed-by: kvn ------------- PR: https://git.openjdk.org/leyden/pull/52
participants (6)
-
Alan Bateman
-
duke
-
Ioi Lam
-
Mark Reinhold
-
Mat Carter
-
Vladimir Kozlov