RFR: 8371159: [Leyden] assert(false) failed: Attempting to acquire lock
The reason for the issue is we call `dump_asm_on()` under a tty lock and it, in turn, calls into the CI to get info about klass and that does a training data lookup, which takes the `TrainingData_lock`. The solution to do that without the tty lock, I haven't found the reason on having it in the first place. ------------- Commit messages: - Don't lock tty when calling PhaseOutput::dump_asm_on() Changes: https://git.openjdk.org/leyden/pull/104/files Webrev: https://webrevs.openjdk.org/?repo=leyden&pr=104&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8371159 Stats: 7 lines in 1 file changed: 1 ins; 4 del; 2 mod Patch: https://git.openjdk.org/leyden/pull/104.diff Fetch: git fetch https://git.openjdk.org/leyden.git pull/104/head:pull/104 PR: https://git.openjdk.org/leyden/pull/104
On Wed, 12 Nov 2025 20:32:22 GMT, Igor Veresov <iveresov@openjdk.org> wrote:
The reason for the issue is we call `dump_asm_on()` under a tty lock and it, in turn, calls into the CI to get info about klass and that does a training data lookup, which takes the `TrainingData_lock`. The solution to do that without the tty lock, I haven't found the reason on having it in the first place.
Okay ------------- Marked as reviewed by kvn (Committer). PR Review: https://git.openjdk.org/leyden/pull/104#pullrequestreview-3455608171
On Wed, 12 Nov 2025 20:32:22 GMT, Igor Veresov <iveresov@openjdk.org> wrote:
The reason for the issue is we call `dump_asm_on()` under a tty lock and it, in turn, calls into the CI to get info about klass and that does a training data lookup, which takes the `TrainingData_lock`. The solution to do that without the tty lock, I haven't found the reason on having it in the first place.
This pull request has now been integrated. Changeset: faa44daa Author: Igor Veresov <iveresov@openjdk.org> URL: https://git.openjdk.org/leyden/commit/faa44daa4db53ce9512c48d138cde39fc59c22... Stats: 7 lines in 1 file changed: 1 ins; 4 del; 2 mod 8371159: [Leyden] assert(false) failed: Attempting to acquire lock Reviewed-by: kvn ------------- PR: https://git.openjdk.org/leyden/pull/104
participants (2)
-
Igor Veresov
-
Vladimir Kozlov