- ppc-aix-port-dev - openjdk.org

RFR(xs): 8202325: [aix] disable warnings-as-errors by default
by Thomas Stüfe 26 Apr '18

26 Apr '18

Hi all, may I have reviews please: https://bugs.openjdk.java.net/browse/JDK-8202325 http://cr.openjdk.java.net/~stuefe/webrevs/8202325-aix-disable-warnings-as-… We decided to disable warnings as errors by default on AIX. This is a pragmatic decision - we will never be able to fix all the many xlC warnings and the build since long only worked when disabling warnings-as-errors. So, might as well make this the default. Best regards, Thomas

4 6

RFR(XS): 8202000: AIX build broken after JDK-8195099
by Langer, Christoph 19 Apr '18

19 Apr '18

Hi, after JDK-8195099, the AIX build is broken. Please review this small fix which consists of renaming 2 macros that conflict with other macros coming in from a system header. Bug: https://bugs.openjdk.java.net/browse/JDK-8202000 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8202000.0/ Thanks, Christoph

4 4

Re: <AWT Dev> Proposal:AIX's IME support
by Ichiroh Takiguchi 18 Apr '18

18 Apr '18

Hello. Sorry I'm late. Christoph Langer helped me to put webrev file into cr.openjdk.java.net. See, http://cr.openjdk.java.net/~clanger/webrevs/8201429.0/ Actually, he found *.patch files had unexpected entries, I fixed the issue. It seemed that webrev tool could not handle "hg copy" action. It was reported by, http://mail.openjdk.java.net/pipermail/webrev-dev/2018-April/000145.html So above webrev file should be fine. Please let me know if you have any question and suggestion about webrev file for AIX's IME support. Thanks, Ichiroh Takiguchi On 2018-04-10 07:39, Sergey Bylokhov wrote: > Hi, Ichiroh. > Your contribution is welcome. Can you send the change for review as a > webrev on cr.openjdk.java.net? > > On 09/04/2018 02:09, Ichiroh Takiguchi wrote: >> Hello, >> IBM would like to propose another Input Method Framework (IMF) >> implementation against IBM AIX platform. >> Same IMF implementation was used by IBM Java8 for AIX. >> IBM would like to contribute this IMF implementation to OpenJDK >> project. >> >> AIX's Input Method Editor (IME) working behavior is not same as >> Linux's and Solaris' one. >> On OpenJDK JDK9 for AIX, users cannot input any East Asian character >> with their locale by this IME. >> We think this situation is critical. >> Put modified files under src/java.desktop/aix/* directories in order >> not to affect the other unix platform. >> >> I'd like contribute following 4 files: >> M make/lib/Awt2dLibraries.gmk >> A src/java.desktop/aix/classes/sun/awt/X11InputMethod.java >> A src/java.desktop/aix/native/libawt_xawt/awt/awt_InputMethod.c >> A src/java.desktop/aix/native/libawt_xawt/xawt/XlibWrapper.c >> >> We need to apply too many changes including JNI, so we copied >> following 3 files from unix directory to aix directory: >> * src/java.desktop/unix/classes/sun/awt/X11InputMethod.java >> * src/java.desktop/unix/native/libawt_xawt/awt/awt_InputMethod.c >> * src/java.desktop/unix/native/libawt_xawt/xawt/XlibWrapper.c >> Then, we modified them. >> >> I'd appreciate any feedback please, and how I would go about obtaining >> a sponsor and contributor? >> >> Thanks, >> Ichiroh Takiguchi >> IBM Japan, Ltd. >>

3 3

Re: Missing many locales support on AIX platform
by Volker Simonis 18 Apr '18

18 Apr '18

Hi Bhaktavatsal Reddy, thanks for addressing this long standing issue. I've opened "8201540: [AIX] Extend the set of supported charsets in java.base" [1] to track this issue. As I wrote in the bug report, this problem is the consequence of an emergency fix (JDK-8081332) I did back in 2015 to fix the build on AIX after the integration of the modularity support change (see discussion: [2]). At that time I only added the minimal set of charsets which were required to fix the build. It would be great if you can get in touch with your IBM colleagues to find out which are the default extended charsets supported by IBM J9 on AIX. I think we should try to use a similar set here in our OpenJDK port which is also used by the OpenJ9 for building OpenJ9 on AIX. Also, your IBM colleagues can help you to host a webrev which will make the further review of these changes much easier. I've but Tim from IBM on CC which should have an overview of all the IBM people involved in the OpenJDK project. Besides that I know at least the following people who might help you: Michihiro Horie: HORIE(a)jp.ibm.com Hiroshi H Horii: horii(a)jp.ibm.com Gustavo Romero: gromero(a)linux.vnet.ibm.com Matthew Brandyberyy: mbrandy(a)linux.vnet.ibm.com Thank you and best regards, Volker [1] https://bugs.openjdk.java.net/browse/JDK-8201540 [2] http://mail.openjdk.java.net/pipermail/2d-dev/2015-May/005431.html On Fri, Apr 13, 2018 at 2:42 PM, Bhaktavatsal R Maram <bhamaram(a)in.ibm.com> wrote: > Hi Alan, > > Thank you for your response. I'm happy that my patch was attached. But, I don't see attachment. So, I inlined patch which contain diffs from 2 changesets in mail text. If a Jira bug is opened for this issue, probably I can attach complete and consolidated patch there. > > At high level, I'm adding following charsets to standard charset in java.base. For this, I have to change IBM943C and IBM942C from source to template to handle java package and aliases. It is also required to add codepage 932 as alias for IBM942C because both are one and same. > > Big5, Big5_HKSCS, GB18030, IBM942, IBM942C, IBM943, IBM943C, IBM950, IBM970, IBM1124, TIS_620 > > > These are default charsets for some of locales supported by Operating System (AIX). Since these are not available in standard charset, JDK can't be used in those locale even if they are available in jdk.charset module (java -version fails). > > I've followed some of the discussions around this in community and understand that default charset of a locale should be made available in java.charset module by using stdcs-* mechanism. On Linux, they were added to java.base in similar way. As it is missing for AIX, I've added them to enable JDK support for more locales. > > > Thanks, > Bhaktavatsal Reddy > > -----Alan Bateman <Alan.Bateman(a)oracle.com> wrote: ----- > To: Bhaktavatsal R Maram <bhamaram(a)in.ibm.com>, core-libs-dev(a)openjdk.java.net > From: Alan Bateman <Alan.Bateman(a)oracle.com> > Date: 04/13/2018 03:52PM > Subject: Re: Missing many locales support on AIX platform > > On 13/04/2018 10:35, Bhaktavatsal R Maram wrote: >> Given that patch is big, I am sending patch as attachment again after changing some mail settings. Hopefully, it will make to community this time. > Your patch was attached. > > If I read it correctly, you've switched IBM943C to a template but there > aren't additional aliases so this part is effectively a no-op, is that > right? For IBM932C, you've moved it to be template and added several > aliases. > > The rest is AIX specific and I hope the SAP engineers that maintain the > AIX port can help you. It may be that you are testing with locales that > aren't supported configurations for the AIX port in OpenJDK. As a > general point, we try to keep as many of the exotic and multibyte > charsets out of java.base. They are of course still available to > applications via the API and the jdk.charsets service provider module. > > -Alan > >

4 8

RFR(XS): 8201218: PPC64: Avoid use of yield instruction on spinlock
by Gustavo Romero 10 Apr '18

10 Apr '18

Hi, Could the following change be reviewed please? bug : https://bugs.openjdk.java.net/browse/JDK-8201218 webrev: http://cr.openjdk.java.net/~gromero/8201218/v1/ It avoids the use of 'yield' ('or 27, 27, 27') supposed to yield up thread resources to another thread once, for instance, it's necessary to perform a spinlock as in the current code found in the following functions: MacroAssembler::rtm_retry_lock_on_abort() MacroAssembler::rtm_retry_lock_on_busy() because 'yield' has no effect on POWER processors, being treat as a 'nop' instruction and taking no action over the PPR (Program Priority Register). Instead of 'yield' 'or 1, 1, 1' instruction is used to set thread priority to low before entering the spin loop in rtm_retry_lock_on_busy and a proper 'or' instruction is used after leaving the spin loop in order to set thread priority back to its default value in userspace (to restore it). The default value in PPR's PRI field in userspace, unfortunately, is different on Linux and AIX: on Linux default is 0b011 (medium low) [1] whilst on AIX default is 0b100 (medium / aka normal) [2], so for each case a different 'or' is present immediately after leaving the loop. Before entering the loop, after discussing with the PPC Linux team, the recommendation is the following rule of thumb: - For known long delays (about u/mseconds) use 'very low'; - For shorter delays use just 'low' priority. So I selected 'low' priority for the spinlock in question. ISA in fact states that "if a program is waiting on a lock, it could set low priority", but it's not clear from the text if it means low in general sense or indeed 'low' (0b010), so I'm using 'low' before entering the loop based upon the rule above. Finally, 'yield' was removed from rtm_retry_lock_on_abort in order to avoid that the program execution leaves that function with PPR set as 'low' since it's possible to "escape" from that function without ever resetting the PPR back to it's default value in userspace. Thank you and best regards, Gustavo [1] https://github.com/torvalds/linux/blob/master/arch/powerpc/include/asm/proc… [2] https://www.ibm.com/support/knowledgecenter/en/ssw_aix_71/com.ibm.aix.ktech…

3 6

Re: Compile JRE for PPC 32 bit
by Rob McKenna 14 Feb '18

14 Feb '18

Hi Radu, This topic is more suited to the PowerPC port alias: ppc-aix-port-dev(a)openjdk.java.net Bcc'ing jdk8u-dev. -Rob On 25/01/18 17:16, Radu Andritoiu wrote: > Hello, > > I need to compile a working (java compatible) JRE for Power PC 32 bit. > I need the JRE to have the fix for RMI vulnerability ( > https://access.redhat.com/security/cve/cve-2017-3241) > So I thought to try compiling jdk8u162-b01 revision. > > I am building on a x86 Ubuntu and using a cross-compiler. > Do you recommend trying to do a compiling it directly on the PPC 32 machine? > > What jvm-variant should I compile? > I understood that the "zero" variant is the only one that can be > cross-compiled to run on PPC32, but it is an interpreter only and needs > this patch ( > http://bazaar.launchpad.net/~openjdk/openjdk/openjdk8/view/head:/debian/pat…) > that makes is not java compatible. > > What target should I compile? > I managed to cross-compile only "hotspot" but this only gives me the JVM. I > think in order to get the rest of the JRE I need to cross-compile "jdk" > target, and this one gives me a lot of errors. > > Do you think I should give up on cross-compiling jdk8u162 and try compiling > an older version and manually port the RMI fix? > What jdk version/revision can be compiled for PPC32 with at least the > "client" target, not only for "zero"? > > Please, can you help me. > > > Thank you very much in advance, > Radu

7 20

RFR [xxs, aix]: JDK-8196488: [aix] TOC overflow for libjvm.so in fastdebug build
by Thomas Stüfe 12 Feb '18

12 Feb '18

Hi, may I please have reviews for this tiny fix: Bug: https://bugs.openjdk.java.net/browse/JDK-8196488 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8196488-aix-toc-overflow-in-fast… Thanks and Kind Regards, Thomas

5 10

RFR : 8196578 : enhance errno_to_string function in os.cpp with some additional errno texts from AIX 7.1
by Baesken, Matthias 12 Feb '18

12 Feb '18

Hello , I enhanced the errno - to - error-text mappings in os.cpp for a few errnos we find on AIX 7.1 . Some of these added errnos are found as well on Linux (e.g. SLES 11 / 12 ). Could you please check and review ? ( btw. there is good cross platform info about the errnos at http://www.ioplex.com/~miallen/errcmp.html ) Bug : https://bugs.openjdk.java.net/browse/JDK-8196578 Webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8196578/ Best regards, Matthias

4 10

RFR(S): 8196565: AIX: Clean up os::javaTimeNanos according to AIX/PASE specification
by Langer, Christoph 07 Feb '18

07 Feb '18

Hi, please review a fix for the os::javaTimeNanos method on AIX. It implements the information we got from the AIX documentation and from the IBM folks regarding the behavior of mread_real_time on Pase. Bug: https://bugs.openjdk.java.net/browse/JDK-8196565 Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196565.0/ Thanks & Best regards Christoph

4 12

RFR(XS) JDK10: 8196678: avoid printing uninitialized buffer in os::print_memory_info on AIX
by Langer, Christoph 02 Feb '18

02 Feb '18

Hi, Arno has spotted an issue when printing hs_err files on AIX. This fix should still be done for JDK10. Please review and approve. Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196678.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196678 Thanks Christoph

3 6