I fixed (added back) the missing bracket in os_linux_s390.cpp and pushed. Thanks for the help reviewing and testing! Cheers, Mikael
On Nov 8, 2018, at 1:20 AM, Andrew Dinn <adinn@redhat.com> wrote:
Hi Mikael,
On 07/11/18 11:38, Andrew Dinn wrote:
On 06/11/18 21:00, Mikael Vidstedt wrote:
Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead.
Yes, all looks good.
* Testing
tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt.
I have built successfully on aarch64 and tier1 testing is in progress. I will let you know the results when it completes. tier1 tests showed no problems on AArch64.
Reviewed!
regards,
Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander