Hi Steve, this change breaks the Linux build, because USE_PTHREADS is defined in /usr/work/openjdk/nb/fdbg/linuxx86_64/jdk7u/jdk/make/common/Defs-linux.gmk, but it is not really exported in the CFLAGS/CPPFLAGS as this is done for AIX. So there are two possibilities here: we could either reintroduce the "superflous" __linux__ or we could export USE_PTHREADS in the CFLAGS/CPPFLAGS in the same way as this is done for AIX. Although we wanted to do as few changes as possible in shared code, I'd vote for the second option, because this is really a feature we want to use (PTHREADS) and it should be defined once in the makefile for the corresponding platform. Going that way would simplify further ports like for example HPUX. What do you think? Do you want me to do the change or do you have a Linux build yourself? Regards, Volker On Thu, Jul 12, 2012 at 2:50 PM, <spoole@linux.vnet.ibm.com> wrote:
Changeset: 5c3a27b86fd1 Author: spoole <spoole@linux.vnet.ibm.com> Date: 2012-07-12 13:50 +0100 URL: http://hg.openjdk.java.net/ppc-aix-port/jdk7u/jdk/rev/5c3a27b86fd1
Updated using pthreads in java_md_solinux.c to just rely on USE_PTHREADS. Removed the superflous __linux__ as USE_PTHREADS is already explictly turned on for linux builds
! src/solaris/bin/java_md_solinux.c