I haven't evaluated the merits of this proposal but this https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/src/java.desktop/s... is not the right place to support a flag used in all these X11 files. And why is i18n-dev on the review ? I can't see any I18N related changes. -phil. On 12/4/18 8:53 AM, Ichiroh Takiguchi wrote:
Hello again.
Could you give me review comment and/or suggestion ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/
Thanks, Ichiroh Takiguchi
On 2018-11-26 21:27, Ichiroh Takiguchi wrote:
Hello.
Could you review the fix ?
Bug: https://bugs.openjdk.java.net/browse/JDK-8212676 Change: https://cr.openjdk.java.net/~itakiguchi/8212676/webrev.00/
Test instructions and screen shots are in JDK-8212676.
GUI environment for AIX platform still needs CDE support. This fix is required to avoid unexpected working behavior on AIX platform.
I'd like to obtain a sponsor for this issue.
Thanks, Ichiroh Takiguchi IBM Japan, Ltd.
On 2018-06-18 18:57, Ichiroh Takiguchi wrote:
Hello.
This fix is really required for AIX's GUI. System color setting and window manager's working behavior are very important.
I appreciate any feedback, and how I would go about obtaining a sponsor and contributor ?
On 2018-05-25 11:02, Ichiroh Takiguchi wrote:
Hello Phil.
webrev file was extracted. Please see http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev.00/
On 2018-05-19 02:48, Ichiroh Takiguchi wrote:
Hello Phil.
Webrev.zip file is stored into http://cr.openjdk.java.net/~aleonard/AIX_GUI/webrev-aixgui.zip
Test programs are also stored: No testcase is available for FontUtilities.java and XDecoratedPeer.java.
MotifColorUtilities.java http://cr.openjdk.java.net/~aleonard/AIX_GUI/SystemColorTest2.java Run SystemColorTest2, system colors should be displayed AIX sample is http://cr.openjdk.java.net/~aleonard/AIX_GUI/aix_systemcolor.txt
XWM.java http://cr.openjdk.java.net/~aleonard/AIX_GUI/XWMTest1.java On AIX CDE, isMotif and isCDE were true. On AIX MWM, every entry is false.
XWindowPeer.java http://cr.openjdk.java.net/~aleonard/AIX_GUI/JFrameTest.java On AIX CDE, click inside of "Non-Focusable" window (not window frame). Window focus should not be changed because of "click on focus" feature. But input focus is moved to "Non-Focusable" window.
On 2018-05-18 01:00, Phil Race wrote:
I think we'd need to see the actual proposed changes and understand the implications for ongoing support as we no longer support any platform which has a CDE desktop. Solaris 11.3 uses Gnome, so we'd be more inclined to be ripping out such support rather than adding to it.
-phil.
On 05/17/2018 04:18 AM, Ichiroh Takiguchi wrote: > Hello, > IBM would like to contribute AIX's CDE (Common Desktop > Environment) DTWM (Desktop Window Manager) /MWM (Motif Window > Manager) support to OpenJDK project. > > I'd like contribute following 5 files: > > M src/java.desktop/share/classes/sun/font/FontUtilities.java > (Add isAIX flag to determine AIX platform for GUI environment) > M > src/java.desktop/unix/classes/sun/awt/X11/MotifColorUtilities.java > (Add High Color support on CDE, OpenJDK just supports Medium > Color) [1] > M src/java.desktop/unix/classes/sun/awt/X11/XDecoratedPeer.java > (Avoid miss calculation for window position under DTWM/MWM by > XMapRaised/XMapWindow) > M src/java.desktop/unix/classes/sun/awt/X11/XWM.java > (Detect MWM on AIX platform) > M src/java.desktop/unix/classes/sun/awt/X11/XWindowPeer.java > (Add non-focusable window support on DTWM/MWM for AIX, because > DTWM/MWM does not have enough features for ICCCM) > > I appreciate any feedback please, and how I would go about > obtaining a sponsor and contributor ? > > Thanks, > Ichiroh Takiguchi > IBM Japan, Ltd. > > [1] > https://docs.oracle.com/cd/E19253-01/806-7492/fontsandcolors-15233/index.htm... >