RFR(S): 8213436: Obsolete UseMembar
Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. bug: https://bugs.openjdk.java.net/browse/JDK-8213436 <https://bugs.openjdk.java.net/browse/JDK-8213436> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/> * Background (from jbs) The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. * Testing tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt. (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) Cheers, Mikael
Nice cleanup. Thanks, Vladimir On 11/6/18 1:00 PM, Mikael Vidstedt wrote:
Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead.
bug: https://bugs.openjdk.java.net/browse/JDK-8213436 <https://bugs.openjdk.java.net/browse/JDK-8213436> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/>
* Background (from jbs)
The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed.
* Testing
tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt.
(Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...)
Cheers, Mikael
Hi Mikael, It is good to see a lot of complex code removed. Reviewed. Thanks, David On 7/11/2018 7:00 AM, Mikael Vidstedt wrote:
Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead.
bug: https://bugs.openjdk.java.net/browse/JDK-8213436 <https://bugs.openjdk.java.net/browse/JDK-8213436> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/>
* Background (from jbs)
The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed.
* Testing
tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt.
(Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...)
Cheers, Mikael
Hi Mikael, looks good and builds on PPC64 and s390. Thanks, Martin -----Original Message----- From: s390x-port-dev <s390x-port-dev-bounces@openjdk.java.net> On Behalf Of Mikael Vidstedt Sent: Dienstag, 6. November 2018 22:01 To: Hotspot dev runtime <hotspot-runtime-dev@openjdk.java.net> Cc: s390x-port-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net; aarch64-port-dev@openjdk.java.net Subject: RFR(S): 8213436: Obsolete UseMembar Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. bug: https://bugs.openjdk.java.net/browse/JDK-8213436 <https://bugs.openjdk.java.net/browse/JDK-8213436> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/> * Background (from jbs) The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. * Testing tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt. (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) Cheers, Mikael
Hi again, I had started the wrong build on s390. Please fix os_linux_s390.cpp: You removed one "}" too much. (No need for a new webrev.) Best regards, Martin -----Original Message----- From: Doerr, Martin Sent: Mittwoch, 7. November 2018 08:38 To: 'Mikael Vidstedt' <mikael.vidstedt@oracle.com>; Hotspot dev runtime <hotspot-runtime-dev@openjdk.java.net> Cc: s390x-port-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net; aarch64-port-dev@openjdk.java.net Subject: RE: RFR(S): 8213436: Obsolete UseMembar Hi Mikael, looks good and builds on PPC64 and s390. Thanks, Martin -----Original Message----- From: s390x-port-dev <s390x-port-dev-bounces@openjdk.java.net> On Behalf Of Mikael Vidstedt Sent: Dienstag, 6. November 2018 22:01 To: Hotspot dev runtime <hotspot-runtime-dev@openjdk.java.net> Cc: s390x-port-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net; aarch64-port-dev@openjdk.java.net Subject: RFR(S): 8213436: Obsolete UseMembar Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead. bug: https://bugs.openjdk.java.net/browse/JDK-8213436 <https://bugs.openjdk.java.net/browse/JDK-8213436> webrev: http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8213436/webrev.00/open/webrev/> * Background (from jbs) The UseMembar flag was deprecated in JDK 10, and is default true/enabled on all platforms since that same release. It should be obsoleted and the then dead serialization page functionality it controls should be removed. * Testing tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt. (Unrelated to this change: It would be really nice to clean up some of the (mostly) duplicated code in the os/signal handling area...) Cheers, Mikael
Hi Mikael, On 06/11/18 21:00, Mikael Vidstedt wrote:
Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead.
Yes, all looks good.
* Testing
tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt.
I have built successfully on aarch64 and tier1 testing is in progress. I will let you know the results when it completes. regards, Andrew Dinn -----------
Hi Mikael, On 07/11/18 11:38, Andrew Dinn wrote:
On 06/11/18 21:00, Mikael Vidstedt wrote:
Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead.
Yes, all looks good.
* Testing
tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt.
I have built successfully on aarch64 and tier1 testing is in progress. I will let you know the results when it completes. tier1 tests showed no problems on AArch64.
Reviewed! regards, Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
I fixed (added back) the missing bracket in os_linux_s390.cpp and pushed. Thanks for the help reviewing and testing! Cheers, Mikael
On Nov 8, 2018, at 1:20 AM, Andrew Dinn <adinn@redhat.com> wrote:
Hi Mikael,
On 07/11/18 11:38, Andrew Dinn wrote:
On 06/11/18 21:00, Mikael Vidstedt wrote:
Please review this change which obsoletes the UseMembar flag and removes the code that then becomes unreachable/dead.
Yes, all looks good.
* Testing
tier1. If anybody wants to take it for a spin on aarch64/ppc/s390/x86_32 that wouldn’t hurt.
I have built successfully on aarch64 and tier1 testing is in progress. I will let you know the results when it completes. tier1 tests showed no problems on AArch64.
Reviewed!
regards,
Andrew Dinn ----------- Senior Principal Software Engineer Red Hat UK Ltd Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander
participants (5)
-
Andrew Dinn
-
David Holmes
-
Doerr, Martin
-
Mikael Vidstedt
-
Vladimir Kozlov