Hi Jonathan, thank you for the review. I've enabled the AIX night build on the weekend, but without my changes for now. This was just to check that build failures are handled and reported correctly by our build scripts. And indeed, the traffic lights for AIX are red today: http://cr.openjdk.java.net/~simonis/ppc-aix-port/ But I will now checkin the changes today and so hopefully tomorrow the traffic lights for the AIX night build () will be green. See more comments inline.. Regards, Volker On Mon, Sep 17, 2012 at 9:48 AM, Jonathan Lu <luchsh@linux.vnet.ibm.com> wrote:

Hi Volker,

On 09/14/2012 05:35 PM, Volker Simonis wrote:

...

Hi,

could you please review the following (mostly build) changes which I needed in order to build the complete OpenJDK on a 'vanilla' AIX system:

http://cr.openjdk.java.net/~simonis/aix_change_1/

My main question is if they would break your current make system.

I've tried your patch on my AIX64 and LinuxPPC64 boxes, it did not break anything for me :)

...

The second question for now is how we want to handle dependencies on non-standard libraries like zlib, freetype and Xrender: should we require that the user installs them, should we copy them into the JDK distribution (as already arranged for by the OpenJDK build system for freetype) or just statically link all these libraries?

I still would like some input here. How does the J9 links zlib and Xrender (I suppose J9 doesn't use freetype, right?)

For your changes to src/share/native/sun/font/layout/KernTable.cpp, I have not met that before, is it caused by different compiler levels? I'm using XL C/C++ compiler version 11.1.0.11.

Thats really strange, because we use: xlC_r -qversion IBM XL C/C++ for AIX, V10.1 Version: 10.01.0000.0015 I always thought compilers usually get more picky as they evolve and not the other way round. But perhaps you don't compile KernTable.cpp at all because you don't use freetype? Or do you do a real OpenJDK build?

Thanks and best regards Jonathan

...

Thank you and best regards, Volker