RFR(S): 8196487: AIX: os::get_summary_cpu_info does not need to call into libperfstat
Hi, please review an AIX only change: Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196487.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196487 The implementation of os::get_summary_cpu_info() on AIX currently calls libperfstat::get_cpuinfo() which in turn only fills the version field of struct cpuinfo_t for the purpose of os::get_summary_cpu_info. This should be decoupled. Thanks & Best regards Christoph
On Wed, Jan 31, 2018 at 10:10 AM, Langer, Christoph < christoph.langer@sap.com> wrote:
Hi,
please review an AIX only change:
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196487.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196487
The implementation of os::get_summary_cpu_info() on AIX currently calls libperfstat::get_cpuinfo() which in turn only fills the version field of struct cpuinfo_t for the purpose of os::get_summary_cpu_info. This should be decoupled.
Removal of cpuinfo_t.version: ok. Move read of _system_configuration to os_aix.cpp: ok, albeit grudgingly, would have preferred to leave reading and interpreting those AIX internals to the lowest layer, but that is a matter of taste. So, change is fine. Thanks & Regards, Thomas
Thanks & Best regards Christoph
Hi Christoph, change looks good. Thanks, Goetz.
-----Original Message----- From: hotspot-runtime-dev [mailto:hotspot-runtime-dev- bounces@openjdk.java.net] On Behalf Of Langer, Christoph Sent: Mittwoch, 31. Januar 2018 10:10 To: hotspot-runtime-dev@openjdk.java.net; ppc-aix-port- dev@openjdk.java.net Subject: RFR(S): 8196487: AIX: os::get_summary_cpu_info does not need to call into libperfstat
Hi,
please review an AIX only change:
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196487.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196487
The implementation of os::get_summary_cpu_info() on AIX currently calls libperfstat::get_cpuinfo() which in turn only fills the version field of struct cpuinfo_t for the purpose of os::get_summary_cpu_info. This should be decoupled.
Thanks & Best regards Christoph
Hi Goetz, Thomas, thanks for the review. I pushed with added defines for some power architectures that might be too new for older AIX OS versions where OpenJDK could theoretically be built: http://hg.openjdk.java.net/jdk/hs/rev/8a9808a9dd6b Best regards Christoph -----Original Message----- From: Lindenmaier, Goetz Sent: Mittwoch, 31. Januar 2018 11:13 To: Langer, Christoph <christoph.langer@sap.com>; hotspot-runtime-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: RE: RFR(S): 8196487: AIX: os::get_summary_cpu_info does not need to call into libperfstat Hi Christoph, change looks good. Thanks, Goetz.
-----Original Message----- From: hotspot-runtime-dev [mailto:hotspot-runtime-dev- bounces@openjdk.java.net] On Behalf Of Langer, Christoph Sent: Mittwoch, 31. Januar 2018 10:10 To: hotspot-runtime-dev@openjdk.java.net; ppc-aix-port- dev@openjdk.java.net Subject: RFR(S): 8196487: AIX: os::get_summary_cpu_info does not need to call into libperfstat
Hi,
please review an AIX only change:
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196487.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196487
The implementation of os::get_summary_cpu_info() on AIX currently calls libperfstat::get_cpuinfo() which in turn only fills the version field of struct cpuinfo_t for the purpose of os::get_summary_cpu_info. This should be decoupled.
Thanks & Best regards Christoph
On Wed, Jan 31, 2018 at 5:07 PM, Langer, Christoph <christoph.langer@sap.com
wrote:
Hi Goetz, Thomas,
thanks for the review. I pushed with added defines for some power architectures that might be too new for older AIX OS versions where OpenJDK could theoretically be built: http://hg.openjdk.java.net/ jdk/hs/rev/8a9808a9dd6b
Good thinking. Thank you. ..Thomas
Best regards Christoph
-----Original Message----- From: Lindenmaier, Goetz Sent: Mittwoch, 31. Januar 2018 11:13 To: Langer, Christoph <christoph.langer@sap.com>; hotspot-runtime-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: RE: RFR(S): 8196487: AIX: os::get_summary_cpu_info does not need to call into libperfstat
Hi Christoph,
change looks good.
Thanks, Goetz.
-----Original Message----- From: hotspot-runtime-dev [mailto:hotspot-runtime-dev- bounces@openjdk.java.net] On Behalf Of Langer, Christoph Sent: Mittwoch, 31. Januar 2018 10:10 To: hotspot-runtime-dev@openjdk.java.net; ppc-aix-port- dev@openjdk.java.net Subject: RFR(S): 8196487: AIX: os::get_summary_cpu_info does not need to call into libperfstat
Hi,
please review an AIX only change:
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8196487.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8196487
The implementation of os::get_summary_cpu_info() on AIX currently calls libperfstat::get_cpuinfo() which in turn only fills the version field of struct cpuinfo_t for the purpose of os::get_summary_cpu_info. This should be decoupled.
Thanks & Best regards Christoph
participants (3)
-
Langer, Christoph
-
Lindenmaier, Goetz
-
Thomas Stüfe