RFR(XS): 8214063: [AIX] Disable symbol visibility flags
Hi, can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX: http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063 Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags". Thank you and best regards, Volker [1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions >
Hello, probably you did not look correctly at my change 8202322 . It did NOT "blindly" introduce visibility flags for all xlC compilers, but Instead it ***removed*** the flags in cases where xlc 12.1 was used (because they generated a TON of warnings with xlc 12.1 , which messed up the build log and made build operations/analysis a pain). See the description : https://bugs.openjdk.java.net/browse/JDK-8202322 "For a while the OpenJDK build on AIX attempts to set symbol visibility related flags; however they are not supported on our standard xlc version 12.1 so they generate a lot of warnings." Please see : http://hg.openjdk.java.net/jdk/jdk/rev/98f57dff16f3
Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags
It was pretty clear from the beginning that with higher xlc versions than 12.1 the chance that it works "out of the box" is low . Regards, Matthias
-----Original Message----- From: ppc-aix-port-dev <ppc-aix-port-dev-bounces@openjdk.java.net> On Behalf Of Volker Simonis Sent: Dienstag, 27. November 2018 16:34 To: build-dev <build-dev@openjdk.java.net>; ppc-aix-port- dev@openjdk.java.net Cc: adam.farley@uk.ibm.com Subject: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
On Tue, Nov 27, 2018 at 4:56 PM Baesken, Matthias <matthias.baesken@sap.com> wrote:
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions >
Hello, probably you did not look correctly at my change 8202322 .
It did NOT "blindly" introduce visibility flags for all xlC compilers, but Instead it ***removed*** the flags in cases where xlc 12.1 was used (because they generated a TON of warnings with xlc 12.1 , which messed up the build log and made build operations/analysis a pain).
You're right. They were "blindly integrated" by "8200358: Remove mapfiles for JDK executables" and not completely removed by 8202322. Sorry for the confusion.
See the description : https://bugs.openjdk.java.net/browse/JDK-8202322
"For a while the OpenJDK build on AIX attempts to set symbol visibility related flags; however they are not supported on our standard xlc version 12.1 so they generate a lot of warnings."
Please see :
http://hg.openjdk.java.net/jdk/jdk/rev/98f57dff16f3
Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags
It was pretty clear from the beginning that with higher xlc versions than 12.1 the chance that it works "out of the box" is low .
Regards, Matthias
-----Original Message----- From: ppc-aix-port-dev <ppc-aix-port-dev-bounces@openjdk.java.net> On Behalf Of Volker Simonis Sent: Dienstag, 27. November 2018 16:34 To: build-dev <build-dev@openjdk.java.net>; ppc-aix-port- dev@openjdk.java.net Cc: adam.farley@uk.ibm.com Subject: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
Otherwise "8214063: [AIX] Disable symbol visibility flags" looks fine to me (not a Reviewer however) . Best regards, Matthias
-----Original Message----- From: Baesken, Matthias Sent: Dienstag, 27. November 2018 16:57 To: 'Volker Simonis' <volker.simonis@gmail.com>; build-dev <build- dev@openjdk.java.net>; ppc-aix-port-dev@openjdk.java.net Cc: adam.farley@uk.ibm.com Subject: RE: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions >
Hello, probably you did not look correctly at my change 8202322 .
It did NOT "blindly" introduce visibility flags for all xlC compilers, but Instead it ***removed*** the flags in cases where xlc 12.1 was used (because they generated a TON of warnings with xlc 12.1 , which messed up the build log and made build operations/analysis a pain).
See the description : https://bugs.openjdk.java.net/browse/JDK-8202322
"For a while the OpenJDK build on AIX attempts to set symbol visibility related flags; however they are not supported on our standard xlc version 12.1 so they generate a lot of warnings."
Please see :
http://hg.openjdk.java.net/jdk/jdk/rev/98f57dff16f3
Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags
It was pretty clear from the beginning that with higher xlc versions than 12.1 the chance that it works "out of the box" is low .
Regards, Matthias
-----Original Message----- From: ppc-aix-port-dev <ppc-aix-port-dev-bounces@openjdk.java.net> On Behalf Of Volker Simonis Sent: Dienstag, 27. November 2018 16:34 To: build-dev <build-dev@openjdk.java.net>; ppc-aix-port- dev@openjdk.java.net Cc: adam.farley@uk.ibm.com Subject: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
On Tue, Nov 27, 2018 at 4:35 PM Volker Simonis <volker.simonis@gmail.com> wrote:
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063
-# On AIX/xlc we need at least xlc 13.1 for the symbol hiding (see JDK-8214063) +# On AIX/xlc we need at least xlc 13.1 for the symbol hiding (see JDK-8214063). We do not yet support xlc 13, so lets not pass qvisibility=hidden
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened).
Dude you are off. Did you mean "8200178 - Remove mapfiles for JDK native libraries"? Matthias just removed the flag conditionally for xlc 12.1
Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
Cheers Thomas
Looks ok to me. /Erik On 2018-11-27 07:33, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
On 2018-11-27 16:33, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063 Looks good to me. I am sorry for the mess I caused by optimisically trying to fix things on a platform I could not compile on... :(
This also reminds me that the visibility flags *really* should move into configure/spec, not be sprinkled like this in the make files. /Magnus
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
On Thu, Nov 29, 2018 at 12:20 PM Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com> wrote:
On 2018-11-27 16:33, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
http://cr.openjdk.java.net/~simonis/webrevs/2018/8214063/ https://bugs.openjdk.java.net/browse/JDK-8214063 Looks good to me. I am sorry for the mess I caused by optimisically trying to fix things on a platform I could not compile on... :(
Thanks for the review and don't worry! We really appreciate your continued help. It's really us who should have tested and spotted the problems earlier :) Regards, Volker
This also reminds me that the visibility flags *really* should move into configure/spec, not be sprinkled like this in the make files.
/Magnus
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] https://bugs.openjdk.java.net/browse/JDK-8202322 [2] https://bugs.openjdk.java.net/browse/JDK-8204541
Hi All, The build passed on xlC 13.1 with the makefile patch I proposed (good catch on the comments Volkar!). With Volkar, Erik, Matthias, and Magnus all approving the change, it sounds like we're good to merge! Volkar, can you do the honours? Best Regards Adam Farley IBM Runtimes P.S. I approve the change too. ;) Volker Simonis <volker.simonis@gmail.com> wrote on 29/11/2018 11:54:33:
From: Volker Simonis <volker.simonis@gmail.com> To: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com> Cc: build-dev <build-dev@openjdk.java.net>, ppc-aix-port- dev@openjdk.java.net, adam.farley@uk.ibm.com Date: 29/11/2018 11:54 Subject: Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
On Thu, Nov 29, 2018 at 12:20 PM Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com> wrote:
On 2018-11-27 16:33, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
INVALID URI REMOVED
u=http-3A__cr.openjdk.java.net_-7Esimonis_webrevs_2018_8214063_&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=DptrWUUtJCcpUCbCWkkBOeFJCVk5im3hm9T_DcD0Jd8&e=
INVALID URI REMOVED
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8214063&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=jBFABkJb5E5W9K8pMX794-3gnpLfPyi3oASA1kizQ7A&e=
Looks good to me. I am sorry for the mess I caused by optimisically trying to fix things on a platform I could not compile on... :(
Thanks for the review and don't worry! We really appreciate your continued help. It's really us who should have tested and spotted the problems earlier :)
Regards, Volker
This also reminds me that the visibility flags *really* should move into configure/spec, not be sprinkled like this in the make files.
/Magnus
Change "8202322: AIX: symbol visibility flags not support on xlc
12.1"
[1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] INVALID URI REMOVED
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202322&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=pd7-rH7OPxeaq2g6S0dQPmb_3-8PLi8JZFKcP_Abp6Q&e=
[2] INVALID URI REMOVED
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8204541&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=q7KHUASpF-opdcLXbTTUT1bPoKrkTeaHTtd7c2jN4rc&e=
Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Hi Adam, I've just pushed the change: http://hg.openjdk.java.net/jdk/jdk/rev/fc54d27e58d8 Best regards, Volker On Thu, Nov 29, 2018 at 5:54 PM Adam Farley8 <adam.farley@uk.ibm.com> wrote:
Hi All,
The build passed on xlC 13.1 with the makefile patch I proposed (good catch on the comments Volkar!).
With Volkar, Erik, Matthias, and Magnus all approving the change, it sounds like we're good to merge!
Volkar, can you do the honours?
Best Regards
Adam Farley IBM Runtimes
P.S. I approve the change too. ;)
Volker Simonis <volker.simonis@gmail.com> wrote on 29/11/2018 11:54:33:
From: Volker Simonis <volker.simonis@gmail.com> To: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com> Cc: build-dev <build-dev@openjdk.java.net>, ppc-aix-port- dev@openjdk.java.net, adam.farley@uk.ibm.com Date: 29/11/2018 11:54 Subject: Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
On Thu, Nov 29, 2018 at 12:20 PM Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com> wrote:
On 2018-11-27 16:33, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial change which simply disables the symbol visibility flags on AIX:
u=http-3A__cr.openjdk.java.net_-7Esimonis_webrevs_2018_8214063_&d=DwIBaQ&c=jf_iaSHvJObTbx- siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=DptrWUUtJCcpUCbCWkkBOeFJCVk5im3hm9T_DcD0Jd8&e=
https://urldefense.proofpoint.com/v2/url? u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8214063&d=DwIBaQ&c=jf_iaSHvJObTbx- siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=jBFABkJb5E5W9K8pMX794-3gnpLfPyi3oASA1kizQ7A&e= Looks good to me. I am sorry for the mess I caused by optimisically trying to fix things on a platform I could not compile on... :(
Thanks for the review and don't worry! We really appreciate your continued help. It's really us who should have tested and spotted the problems earlier :)
Regards, Volker
This also reminds me that the visibility flags *really* should move into configure/spec, not be sprinkled like this in the make files.
/Magnus
Change "8202322: AIX: symbol visibility flags not support on xlc 12.1" [1] blindly introduced these flags for all xlC compiler versions > 12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202322&d=DwIBaQ&c=jf_iaSHvJObTbx- siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=pd7-rH7OPxeaq2g6S0dQPmb_3-8PLi8JZFKcP_Abp6Q&e=
[2] https://urldefense.proofpoint.com/v2/url? u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8204541&d=DwIBaQ&c=jf_iaSHvJObTbx- siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca-- YxF4UGVrVEIqu_wVvivFVUA&s=q7KHUASpF-opdcLXbTTUT1bPoKrkTeaHTtd7c2jN4rc&e=
Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Thanks Volker. :) Best Regards Adam Farley IBM Runtimes Volker Simonis <volker.simonis@gmail.com> wrote on 04/12/2018 08:30:58:
From: Volker Simonis <volker.simonis@gmail.com> To: adam.farley@uk.ibm.com Cc: build-dev <build-dev@openjdk.java.net>, Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com>, ppc-aix-port-dev@openjdk.java.net Date: 04/12/2018 08:31 Subject: Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
Hi Adam,
I've just pushed the change:
INVALID URI REMOVED
u=http-3A__hg.openjdk.java.net_jdk_jdk_rev_fc54d27e58d8&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=NhALBBoEo6HsbPIjB8bJJj30UR8DRP- PuJckMbmJvA0&s=gLabfGk2XJdLwimruwQdLAmjBXtCueO7qR01_xw5wuw&e=
Best regards, Volker On Thu, Nov 29, 2018 at 5:54 PM Adam Farley8 <adam.farley@uk.ibm.com> wrote:
Hi All,
The build passed on xlC 13.1 with the makefile patch I proposed
(good catch on the comments Volkar!).
With Volkar, Erik, Matthias, and Magnus all approving the change,
it sounds like we're good to merge!
Volkar, can you do the honours?
Best Regards
Adam Farley IBM Runtimes
P.S. I approve the change too. ;)
Volker Simonis <volker.simonis@gmail.com> wrote on 29/11/2018
11:54:33:
From: Volker Simonis <volker.simonis@gmail.com> To: Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com> Cc: build-dev <build-dev@openjdk.java.net>, ppc-aix-port- dev@openjdk.java.net, adam.farley@uk.ibm.com Date: 29/11/2018 11:54 Subject: Re: RFR(XS): 8214063: [AIX] Disable symbol visibility flags
On Thu, Nov 29, 2018 at 12:20 PM Magnus Ihse Bursie <magnus.ihse.bursie@oracle.com> wrote:
On 2018-11-27 16:33, Volker Simonis wrote:
Hi,
can I please have a review for the following trivial change
which
simply disables the symbol visibility flags on AIX:
INVALID URI REMOVED
u=http-3A__cr.openjdk.java.net_-7Esimonis_webrevs_2018_8214063_&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
YxF4UGVrVEIqu_wVvivFVUA&s=DptrWUUtJCcpUCbCWkkBOeFJCVk5im3hm9T_DcD0Jd8&e=
INVALID URI REMOVED
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8214063&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
YxF4UGVrVEIqu_wVvivFVUA&s=jBFABkJb5E5W9K8pMX794-3gnpLfPyi3oASA1kizQ7A&e=
Looks good to me. I am sorry for the mess I caused by optimisically trying to fix things on a platform I could not compile on... :(
Thanks for the review and don't worry! We really appreciate your continued help. It's really us who should have tested and spotted the problems earlier :)
Regards, Volker
This also reminds me that the visibility flags *really* shouldmove into configure/spec, not be sprinkled like this in the make files.
/Magnus
Change "8202322: AIX: symbol visibility flags not support onxlc
12.1"
[1] blindly introduced these flags for all xlC compiler versions
12.1 without ever testing it (which should not have happened). Now that people are starting to really use xlC 13 it turns out that there is more to do than just enabling the flags. This future work is covered by "8204541: Correctly support AIX xlC 13.1 symbol visibility flags".
Thank you and best regards, Volker
[1] INVALID URI REMOVED
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8202322&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
YxF4UGVrVEIqu_wVvivFVUA&s=pd7-rH7OPxeaq2g6S0dQPmb_3-8PLi8JZFKcP_Abp6Q&e=
[2] INVALID URI REMOVED
u=https-3A__bugs.openjdk.java.net_browse_JDK-2D8204541&d=DwIBaQ&c=jf_iaSHvJObTbx-
siA1ZOg&r=P5m8KWUXJf- CeVJc0hDGD9AQ2LkcXDC0PMV9ntVw5Ho&m=6y4Npxy6aG4q8E9Xca--
YxF4UGVrVEIqu_wVvivFVUA&s=q7KHUASpF-opdcLXbTTUT1bPoKrkTeaHTtd7c2jN4rc&e=
Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
participants (6)
-
Adam Farley8
-
Baesken, Matthias
-
Erik Joelsson
-
Magnus Ihse Bursie
-
Thomas Stüfe
-
Volker Simonis