8186982: [aix] Garbage output for CPU info in hs-err file
Hi, may I please have reviews for this tiny trivial change: Bug: https://bugs.openjdk.java.net/browse/JDK-8186982 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8186982-aix-cpu-info-garbage/webr... Thank you! ..Thomas
Looks good! Thanks for cleaning this up, Volker On Thu, Aug 31, 2017 at 2:20 PM, Thomas Stüfe <thomas.stuefe@gmail.com> wrote:
Hi,
may I please have reviews for this tiny trivial change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8186982 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8186982-aix-cpu-info-garbage/webr...
Thank you!
..Thomas
Thank you Volker! On Thu, Aug 31, 2017 at 2:59 PM, Volker Simonis <volker.simonis@gmail.com> wrote:
Looks good!
Thanks for cleaning this up, Volker
On Thu, Aug 31, 2017 at 2:20 PM, Thomas Stüfe <thomas.stuefe@gmail.com> wrote:
Hi,
may I please have reviews for this tiny trivial change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8186982 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8186982-aix- cpu-info-garbage/webrev.00/webrev/
Thank you!
..Thomas
Hi Thomas, looks good, thanks. Best regards, Goetz. From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Thursday, August 31, 2017 2:20 PM To: ppc-aix-port-dev@openjdk.java.net Cc: Zeller, Arno <arno.zeller@sap.com> Subject: 8186982: [aix] Garbage output for CPU info in hs-err file Hi, may I please have reviews for this tiny trivial change: Bug: https://bugs.openjdk.java.net/browse/JDK-8186982 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8186982-aix-cpu-info-garbage/webr... Thank you! ..Thomas
Thanks, Goetz! On Thu, Aug 31, 2017 at 3:30 PM, Lindenmaier, Goetz < goetz.lindenmaier@sap.com> wrote:
Hi Thomas,
looks good, thanks.
Best regards,
Goetz.
*From:* ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces@openjdk.java.net] *On Behalf Of *Thomas Stüfe *Sent:* Thursday, August 31, 2017 2:20 PM *To:* ppc-aix-port-dev@openjdk.java.net *Cc:* Zeller, Arno <arno.zeller@sap.com> *Subject:* 8186982: [aix] Garbage output for CPU info in hs-err file
Hi,
may I please have reviews for this tiny trivial change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8186982
Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/ 8186982-aix-cpu-info-garbage/webrev.00/webrev/
Thank you!
..Thomas
(Added hotspot-runtime) Hi all @hotspot-runtime, may I please have additional reviews for this AIX only patch. I already pushed this change - it was AIX only and I had two reviewers, so I thought I was fine. But I was not aware that a rule exists requiring me to run changes like these through one of the generic mailing lists in addition to the AIX-only mailing lists. Sorry for that. I usually try to avoid crossposting to keep the noise down. So, this change. It removes the AIX os::pd_print_cpu_info() implementation, which is not only broken but also superfluous since the generic one (os::print_cpu_info()) does just fine and there is nothing exciting to add at os level. Thank you! Thomas On Thu, Aug 31, 2017 at 2:20 PM, Thomas Stüfe <thomas.stuefe@gmail.com> wrote:
Hi,
may I please have reviews for this tiny trivial change:
Bug: https://bugs.openjdk.java.net/browse/JDK-8186982 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/ 8186982-aix-cpu-info-garbage/webrev.00/webrev/
Thank you!
..Thomas
Hi Thomas, looks good, thanks. Best regards, Goetz. From: Thomas Stüfe [mailto:thomas.stuefe@gmail.com] Sent: Thursday, August 31, 2017 9:06 PM To: ppc-aix-port-dev@openjdk.java.net; hotspot-runtime-dev@openjdk.java.net Cc: Lindenmaier, Goetz <goetz.lindenmaier@sap.com>; Volker Simonis <volker.simonis@gmail.com> Subject: Re: 8186982: [aix] Garbage output for CPU info in hs-err file (Added hotspot-runtime) Hi all @hotspot-runtime, may I please have additional reviews for this AIX only patch. I already pushed this change - it was AIX only and I had two reviewers, so I thought I was fine. But I was not aware that a rule exists requiring me to run changes like these through one of the generic mailing lists in addition to the AIX-only mailing lists. Sorry for that. I usually try to avoid crossposting to keep the noise down. So, this change. It removes the AIX os::pd_print_cpu_info() implementation, which is not only broken but also superfluous since the generic one (os::print_cpu_info()) does just fine and there is nothing exciting to add at os level. Thank you! Thomas On Thu, Aug 31, 2017 at 2:20 PM, Thomas Stüfe <thomas.stuefe@gmail.com<mailto:thomas.stuefe@gmail.com>> wrote: Hi, may I please have reviews for this tiny trivial change: Bug: https://bugs.openjdk.java.net/browse/JDK-8186982 Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8186982-aix-cpu-info-garbage/webr... Thank you! ..Thomas
participants (3)
-
Lindenmaier, Goetz
-
Thomas Stüfe
-
Volker Simonis