RFR(xs): 8187228: [aix] make data segment page size 64K by default
Hi all, may I please have a review for the following AIX-only patch. Issue: https://bugs.openjdk.java.net/browse/JDK-8187228 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data -segment-page-size-64K-by-default/webrev.00/webrev/ It changes the default page size for the data segment (C-heap and Posix Thread Stacks) to 64K. For completeness and simplicity sake, it also changes default page size for text segment and primordial thread stacl to 64K, but that does not matter much. For more details, please see the issue description. Thank you, Thomas
Looks good. /Erik On 2017-09-07 12:01, Thomas Stüfe wrote:
Hi all,
may I please have a review for the following AIX-only patch.
Issue: https://bugs.openjdk.java.net/browse/JDK-8187228
webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data -segment-page-size-64K-by-default/webrev.00/webrev/
It changes the default page size for the data segment (C-heap and Posix Thread Stacks) to 64K.
For completeness and simplicity sake, it also changes default page size for text segment and primordial thread stacl to 64K, but that does not matter much.
For more details, please see the issue description.
Thank you, Thomas
Thank you Eric! On Thu, Sep 7, 2017 at 1:07 PM, Erik Joelsson <erik.joelsson@oracle.com> wrote:
Looks good.
/Erik
On 2017-09-07 12:01, Thomas Stüfe wrote:
Hi all,
may I please have a review for the following AIX-only patch.
Issue: https://bugs.openjdk.java.net/browse/JDK-8187228
webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data -segment-page-size-64K-by-default/webrev.00/webrev/
It changes the default page size for the data segment (C-heap and Posix Thread Stacks) to 64K.
For completeness and simplicity sake, it also changes default page size for text segment and primordial thread stacl to 64K, but that does not matter much.
For more details, please see the issue description.
Thank you, Thomas
Hi Thomas, Looks good. Best regards, Goetz.
-----Original Message----- From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- bounces@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 7. September 2017 12:02 To: ppc-aix-port-dev@openjdk.java.net; build-dev <build- dev@openjdk.java.net> Subject: RFR(xs): 8187228: [aix] make data segment page size 64K by default
Hi all,
may I please have a review for the following AIX-only patch.
Issue: https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228>
webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data-segment- page-size-64K-by-default/webrev.00/webrev/ <http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data- segment-page-size-64K-by-default/webrev.00/webrev/>
It changes the default page size for the data segment (C-heap and Posix Thread Stacks) to 64K.
For completeness and simplicity sake, it also changes default page size for text segment and primordial thread stacl to 64K, but that does not matter much.
For more details, please see the issue description.
Thank you, Thomas
Thank you Goetz! On Thu, Sep 7, 2017 at 2:18 PM, Lindenmaier, Goetz < goetz.lindenmaier@sap.com> wrote:
Hi Thomas,
Looks good.
Best regards, Goetz.
-----Original Message----- From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- bounces@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 7. September 2017 12:02 To: ppc-aix-port-dev@openjdk.java.net; build-dev <build- dev@openjdk.java.net> Subject: RFR(xs): 8187228: [aix] make data segment page size 64K by default
Hi all,
may I please have a review for the following AIX-only patch.
Issue: https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228>
webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data-segment- page-size-64K-by-default/webrev.00/webrev/ <http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data- segment-page-size-64K-by-default/webrev.00/webrev/>
It changes the default page size for the data segment (C-heap and Posix Thread Stacks) to 64K.
For completeness and simplicity sake, it also changes default page size for text segment and primordial thread stacl to 64K, but that does not matter much.
For more details, please see the issue description.
Thank you, Thomas
Hi Goetz, Eric, I was unable to commit this patch before the jdk10 repo consolidation and would like to do so now. Last Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data-segment-page-si... Nothing changed, the webrev is just rebased to the new repo. I am unclear whether I am allowed to push this on my own? Does the build group this? Kind Regards, Thomas On Thu, Sep 7, 2017 at 2:33 PM, Thomas Stüfe <thomas.stuefe@gmail.com> wrote:
Thank you Goetz!
On Thu, Sep 7, 2017 at 2:18 PM, Lindenmaier, Goetz < goetz.lindenmaier@sap.com> wrote:
Hi Thomas,
Looks good.
Best regards, Goetz.
-----Original Message----- From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- bounces@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 7. September 2017 12:02 To: ppc-aix-port-dev@openjdk.java.net; build-dev <build- dev@openjdk.java.net> Subject: RFR(xs): 8187228: [aix] make data segment page size 64K by default
Hi all,
may I please have a review for the following AIX-only patch.
Issue: https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228>
webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data-segment- page-size-64K-by-default/webrev.00/webrev/ <http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data- segment-page-size-64K-by-default/webrev.00/webrev/>
It changes the default page size for the data segment (C-heap and Posix Thread Stacks) to 64K.
For completeness and simplicity sake, it also changes default page size for text segment and primordial thread stacl to 64K, but that does not matter much.
For more details, please see the issue description.
Thank you, Thomas
Hi Thomas, someone from Oracle must push this as they need to regenerate the generated_configure.sh file. So you need a sponsor. Best regards, Goetz.
-----Original Message----- From: Thomas Stüfe [mailto:thomas.stuefe@gmail.com] Sent: Mittwoch, 18. Oktober 2017 12:01 To: Lindenmaier, Goetz <goetz.lindenmaier@sap.com>; Erik Joelsson <erik.joelsson@oracle.com> Cc: ppc-aix-port-dev@openjdk.java.net; build-dev <build- dev@openjdk.java.net> Subject: Re: RFR(xs): 8187228: [aix] make data segment page size 64K by default
Hi Goetz, Eric,
I was unable to commit this patch before the jdk10 repo consolidation and would like to do so now.
Last Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make- data-segment-page-size-64K-by-default/webrev.01/webrev/
Nothing changed, the webrev is just rebased to the new repo.
I am unclear whether I am allowed to push this on my own? Does the build group this?
Kind Regards, Thomas
On Thu, Sep 7, 2017 at 2:33 PM, Thomas Stüfe <thomas.stuefe@gmail.com <mailto:thomas.stuefe@gmail.com> > wrote:
Thank you Goetz!
On Thu, Sep 7, 2017 at 2:18 PM, Lindenmaier, Goetz <goetz.lindenmaier@sap.com <mailto:goetz.lindenmaier@sap.com> > wrote:
Hi Thomas,
Looks good.
Best regards, Goetz.
> -----Original Message----- > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- <mailto:ppc-aix-port-dev-> > bounces@openjdk.java.net <mailto:bounces@openjdk.java.net> ] On Behalf Of Thomas Stüfe > Sent: Donnerstag, 7. September 2017 12:02 > To: ppc-aix-port-dev@openjdk.java.net <mailto:ppc-aix- port-dev@openjdk.java.net> ; build-dev <build- > dev@openjdk.java.net <mailto:dev@openjdk.java.net> > > Subject: RFR(xs): 8187228: [aix] make data segment page size 64K by default > > Hi all, > > may I please have a review for the following AIX-only patch. > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228> > <https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228> > > > > webrev: > http://cr.openjdk.java.net/~stuefe/webrevs/8187228- make-data-segment- <http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data- segment-> > page-size-64K-by-default/webrev.00/webrev/ > <http://cr.openjdk.java.net/~stuefe/webrevs/8187228- make-data- <http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make- data-> > segment-page-size-64K-by-default/webrev.00/webrev/>
> > > It changes the default page size for the data segment (C- heap and Posix > Thread Stacks) to 64K. > > > For completeness and simplicity sake, it also changes default page size for > text segment and primordial thread stacl to 64K, but that does not matter > much. > > For more details, please see the issue description. > > Thank you, Thomas
I can sponsor the change. /Erik On 2017-10-18 12:00, Thomas Stüfe wrote:
Hi Goetz, Eric,
I was unable to commit this patch before the jdk10 repo consolidation and would like to do so now.
Last Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data-segment-page-si... <http://cr.openjdk.java.net/%7Estuefe/webrevs/8187228-make-data-segment-page-size-64K-by-default/webrev.01/webrev/>
Nothing changed, the webrev is just rebased to the new repo.
I am unclear whether I am allowed to push this on my own? Does the build group this?
Kind Regards, Thomas
On Thu, Sep 7, 2017 at 2:33 PM, Thomas Stüfe <thomas.stuefe@gmail.com <mailto:thomas.stuefe@gmail.com>> wrote:
Thank you Goetz!
On Thu, Sep 7, 2017 at 2:18 PM, Lindenmaier, Goetz <goetz.lindenmaier@sap.com <mailto:goetz.lindenmaier@sap.com>> wrote:
Hi Thomas,
Looks good.
Best regards, Goetz.
> -----Original Message----- > From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- <mailto:ppc-aix-port-dev-> > bounces@openjdk.java.net <mailto:bounces@openjdk.java.net>] On Behalf Of Thomas Stüfe > Sent: Donnerstag, 7. September 2017 12:02 > To: ppc-aix-port-dev@openjdk.java.net <mailto:ppc-aix-port-dev@openjdk.java.net>; build-dev <build- > dev@openjdk.java.net <mailto:dev@openjdk.java.net>> > Subject: RFR(xs): 8187228: [aix] make data segment page size 64K by default > > Hi all, > > may I please have a review for the following AIX-only patch. > > Issue: > https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228> > <https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228>> > > > webrev: > http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data-segment- <http://cr.openjdk.java.net/%7Estuefe/webrevs/8187228-make-data-segment-> > page-size-64K-by-default/webrev.00/webrev/ > <http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data- <http://cr.openjdk.java.net/%7Estuefe/webrevs/8187228-make-data-> > segment-page-size-64K-by-default/webrev.00/webrev/> > > > It changes the default page size for the data segment (C-heap and Posix > Thread Stacks) to 64K. > > > For completeness and simplicity sake, it also changes default page size for > text segment and primordial thread stacl to 64K, but that does not matter > much. > > For more details, please see the issue description. > > Thank you, Thomas
Thank you Eric! On Wed, Oct 18, 2017 at 1:29 PM, Erik Joelsson <erik.joelsson@oracle.com> wrote:
I can sponsor the change.
/Erik
On 2017-10-18 12:00, Thomas Stüfe wrote:
Hi Goetz, Eric,
I was unable to commit this patch before the jdk10 repo consolidation and would like to do so now.
Last Webrev: http://cr.openjdk.java.net/~stuefe/webrevs/ 8187228-make-data-segment-page-size-64K-by-default/webrev.01/webrev/
Nothing changed, the webrev is just rebased to the new repo.
I am unclear whether I am allowed to push this on my own? Does the build group this?
Kind Regards, Thomas
On Thu, Sep 7, 2017 at 2:33 PM, Thomas Stüfe <thomas.stuefe@gmail.com> wrote:
Thank you Goetz!
On Thu, Sep 7, 2017 at 2:18 PM, Lindenmaier, Goetz < goetz.lindenmaier@sap.com> wrote:
Hi Thomas,
Looks good.
Best regards, Goetz.
-----Original Message----- From: ppc-aix-port-dev [mailto:ppc-aix-port-dev- bounces@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 7. September 2017 12:02 To: ppc-aix-port-dev@openjdk.java.net; build-dev <build- dev@openjdk.java.net> Subject: RFR(xs): 8187228: [aix] make data segment page size 64K by default
Hi all,
may I please have a review for the following AIX-only patch.
Issue: https://bugs.openjdk.java.net/browse/JDK-8187228 <https://bugs.openjdk.java.net/browse/JDK-8187228>
webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data-segment- page-size-64K-by-default/webrev.00/webrev/ <http://cr.openjdk.java.net/~stuefe/webrevs/8187228-make-data- segment-page-size-64K-by-default/webrev.00/webrev/>
It changes the default page size for the data segment (C-heap and Posix Thread Stacks) to 64K.
For completeness and simplicity sake, it also changes default page size for text segment and primordial thread stacl to 64K, but that does not matter much.
For more details, please see the issue description.
Thank you, Thomas
participants (3)
-
Erik Joelsson
-
Lindenmaier, Goetz
-
Thomas Stüfe