RFR: 8207404: MulticastSocket tests failing on AIX
Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8207404 First of all, I "modernized" the testcases test/jdk/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java and test/jdk/java/net/MulticastSocket/Test.java to make use of test/lib/jdk/test/lib/NetworkConfiguration.java which probes for the network configuration and returns lists of local interfaces or addresses for certain use cases. In NetworkConfiguration.java I made some cleanups and enhancements which will hopefully find some appreciation. These 3 tests will now also be executed with and without -Djava.net.preferIPv4Stack=true. The actual fixes are: test/jdk/java/net/MulticastSocket/JoinLeave.java: test/jdk/java/net/MulticastSocket/SetGetNetworkInterfaceTest.java: -> NetworkConfiguration.ip4MulticastInterfaces() will now, on AIX, in a scenario where IPv6 is available, filter out interfaces that only have IPv4 addresses (line 121ff in test/lib/jdk/test/lib/NetworkConfiguration.java) test/jdk/java/net/MulticastSocket/Test.java: -> The test for node local multicasting is only executed, when NetworkConfiguration::hasTestableIPv6Address is true. For AIX it'll be the case only if a "real" IPv6 address exists (on some interface) which is not loopback or wildcard. This is how it has already been for Solaris. For other operating systems, any IPv6 address on any interface is sufficient for running the test. The coding for the AIX/Solaris check can be found in line 66ff of test/lib/jdk/test/lib/NetworkConfiguration.java. As it is a test only fix, I request to do it in JDK12. Thanks & Best regards Christoph
On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.langer@sap.com> wrote:
Hi,
here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios):
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ <http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/> Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ).
-Chris.
Hi Chris, for me it was the other way round... I did not see immediately where the methods came from and had to do some navigation. But I'm happy to revert this. As I had only worked with AIX so far, I'll put the test update into our test system to see whether there'll be issues on other platforms. I'll send an updated webrev tomorrow. Best regards Christoph From: Chris Hegarty <chris.hegarty@oracle.com> Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph <christoph.langer@sap.com> Cc: net-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.langer@sap.com<mailto:christoph.langer@sap.com>> wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris.
Hi Christoph, Have reviewed you changes and they look OK. I have no preference with regards the static imports, but my view is keep the changes as simple as possible and to not make changes just for the sake of it. Have tested your patches on a couple of AIX systems, both with IPv6 enabled but one didn't have an IPv6 address configured and the other did. All the jdk/java/net/MulticastSocket tests passed. So the change also looks functionally OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" <christoph.langer@sap.com> To: Chris Hegarty <chris.hegarty@oracle.com> Cc: "ppc-aix-port-dev@openjdk.java.net" <ppc-aix-port-dev@openjdk.java.net>, "net-dev@openjdk.java.net" <net-dev@openjdk.java.net> Date: 17/01/2019 11:34 Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Sent by: "net-dev" <net-dev-bounces@openjdk.java.net> Hi Chris, for me it was the other way round… I did not see immediately where the methods came from and had to do some navigation. But I’m happy to revert this. As I had only worked with AIX so far, I’ll put the test update into our test system to see whether there’ll be issues on other platforms. I’ll send an updated webrev tomorrow. Best regards Christoph From: Chris Hegarty <chris.hegarty@oracle.com> Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph <christoph.langer@sap.com> Cc: net-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.langer@sap.com> wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Hi Steve, thanks for the review and the additional testing. I’ll post an update tomorrow after I have results from our test system which will test all platforms that we have an eye on. I’ll roll back the change to the import statement and will also add an update to the problem list in order to make the tests run by default on AIX. You could do me a favor though. There’s not only the issue with the IPV6_MULTICAST_IF setsockopt operation but there’s also the other where node local IPv6 multicast does not work when only the loopback interface is configured for IPv6 (as show in Test.java). Could you check this also with the AIX team whether they consider this a bug or working as expected? Thanks & Best regards Christoph From: Steve Groeger <GROEGES@uk.ibm.com> Sent: Donnerstag, 17. Januar 2019 14:32 To: Langer, Christoph <christoph.langer@sap.com> Cc: Chris Hegarty <chris.hegarty@oracle.com>; net-dev@openjdk.java.net; net-dev <net-dev-bounces@openjdk.java.net>; ppc-aix-port-dev@openjdk.java.net Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Hi Christoph, Have reviewed you changes and they look OK. I have no preference with regards the static imports, but my view is keep the changes as simple as possible and to not make changes just for the sake of it. Have tested your patches on a couple of AIX systems, both with IPv6 enabled but one didn't have an IPv6 address configured and the other did. All the jdk/java/net/MulticastSocket tests passed. So the change also looks functionally OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges@uk.ibm.com<mailto:groeges@uk.ibm.com> Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" <christoph.langer@sap.com<mailto:christoph.langer@sap.com>> To: Chris Hegarty <chris.hegarty@oracle.com<mailto:chris.hegarty@oracle.com>> Cc: "ppc-aix-port-dev@openjdk.java.net<mailto:ppc-aix-port-dev@openjdk.java.net>" <ppc-aix-port-dev@openjdk.java.net<mailto:ppc-aix-port-dev@openjdk.java.net>>, "net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net>" <net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net>> Date: 17/01/2019 11:34 Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Sent by: "net-dev" <net-dev-bounces@openjdk.java.net<mailto:net-dev-bounces@openjdk.java.net>> ________________________________ Hi Chris, for me it was the other way round… I did not see immediately where the methods came from and had to do some navigation. But I’m happy to revert this. As I had only worked with AIX so far, I’ll put the test update into our test system to see whether there’ll be issues on other platforms. I’ll send an updated webrev tomorrow. Best regards Christoph From: Chris Hegarty <chris.hegarty@oracle.com<mailto:chris.hegarty@oracle.com>> Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph <christoph.langer@sap.com<mailto:christoph.langer@sap.com>> Cc: net-dev@openjdk.java.net<mailto:net-dev@openjdk.java.net>; ppc-aix-port-dev@openjdk.java.net<mailto:ppc-aix-port-dev@openjdk.java.net> Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.langer@sap.com<mailto:christoph.langer@sap.com>> wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
Hi, here is the updated webrev with modifications to the problem list and reverting the static imports: http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/ It went fine through our test system so I think it's good now. Please review. Thanks Christoph From: Chris Hegarty <chris.hegarty@oracle.com> Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph <christoph.langer@sap.com> Cc: net-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.langer@sap.com<mailto:christoph.langer@sap.com>> wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris.
Hi Christoph, Had a look at the latest webrev and everything looks OK to me. Have also re-tested on my AIX systems and all tests oass OK. Thanks Steve Groeger IBM Runtime Technologies Hursley, Winchester Tel: (44) 1962 816911 Mobex: 279990 Mobile: 07718 517 129 Fax (44) 1962 816800 Lotus Notes: Steve Groeger/UK/IBM Internet: groeges@uk.ibm.com Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU From: "Langer, Christoph" <christoph.langer@sap.com> To: Chris Hegarty <chris.hegarty@oracle.com>, Steve Groeger <GROEGES@uk.ibm.com> Cc: "net-dev@openjdk.java.net" <net-dev@openjdk.java.net>, "ppc-aix-port-dev@openjdk.java.net" <ppc-aix-port-dev@openjdk.java.net> Date: 18/01/2019 08:54 Subject: RE: RFR: 8207404: MulticastSocket tests failing on AIX Hi, here is the updated webrev with modifications to the problem list and reverting the static imports: http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/ It went fine through our test system so I think it’s good now. Please review. Thanks Christoph From: Chris Hegarty <chris.hegarty@oracle.com> Sent: Donnerstag, 17. Januar 2019 12:27 To: Langer, Christoph <christoph.langer@sap.com> Cc: net-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX On 17 Jan 2019, at 10:55, Langer, Christoph <christoph.langer@sap.com> wrote: Hi, here is a fix for the MulticastSocket tests failing on AIX (in certain sceanrios): Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8207404.0/ Why remove the static imports from NetworkConfiguration? It makes the code more verbose ( and IMO harder to read ). -Chris. Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
On 18/01/2019 08:54, Langer, Christoph wrote:
Hi,
here is the updated webrev with modifications to the problem list and reverting the static imports: _http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/__ I think this is ok.
-Chris.
Thanks, Steve and Chris for reviewing. Pushed to jdk12.
-----Original Message----- From: Chris Hegarty <chris.hegarty@oracle.com> Sent: Freitag, 18. Januar 2019 15:15 To: Langer, Christoph <christoph.langer@sap.com>; Steve Groeger <GROEGES@uk.ibm.com> Cc: net-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: Re: RFR: 8207404: MulticastSocket tests failing on AIX
On 18/01/2019 08:54, Langer, Christoph wrote:
Hi,
here is the updated webrev with modifications to the problem list and reverting the static imports: _http://cr.openjdk.java.net/~clanger/webrevs/8207404.1/__ I think this is ok.
-Chris.
participants (3)
-
Chris Hegarty
-
Langer, Christoph
-
Steve Groeger