Thanks David! Submit ran thru, will push now. ..Thomas On Wed, Oct 24, 2018 at 10:35 AM David Holmes <david.holmes@oracle.com> wrote:

Looks fine - and consistent with other files affected by 8212611.

Thanks, David

On 24/10/2018 4:19 PM, Thomas Stüfe wrote:

...

Hi all,

may I please have a review (trivial rule) for this tiny build fix:

https://bugs.openjdk.java.net/browse/JDK-8212896 http://cr.openjdk.java.net/~stuefe/webrevs/8212896-aix-build-broken-after-82...

Thank you,

Thomas

Yes I wondered about that too. Turns out this header sneaks in on other platforms via JFR: 471 ........ /shared/projects/openjdk/jdk-jdk/output-fastdebug-nopch/hotspot/variant-server/gensrc/jfrfiles/jfrEventClasses.hpp 472 ......... /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/jfr/recorder/service/jfrEvent.hpp 477 .......... /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/jfr/writers/jfrNativeEventWriter.hpp 482 ........... /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/jfr/writers/jfrEventWriterHost.inline.hpp 483 ............ /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/jfr/writers/jfrEventWriterHost.hpp 484 ............. /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/jfr/writers/jfrWriterHost.inline.hpp 505 .............. /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/oops/typeArrayOop.inline.hpp 506 ............... /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/oops/access.inline.hpp 507 ................ /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/gc/shared/barrierSetConfig.inline.hpp 508 ................. /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp 509 .................. /shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/gc/shared/barrierSet.hpp Since on AIX INCLUDE_JFR is not set, we miss out on those includes. ...Thomas On Wed, Oct 24, 2018 at 8:51 AM Volker Simonis <volker.simonis@gmail.com> wrote:

Looks good!

However I don't understand why this bug does not also break the non-PCH build on Linux for example (I've just tried and it still works)? Do you understand?

Regards, Volker On Wed, Oct 24, 2018 at 8:19 AM Thomas Stüfe <thomas.stuefe@gmail.com> wrote:

...

Hi all,

may I please have a review (trivial rule) for this tiny build fix:

https://bugs.openjdk.java.net/browse/JDK-8212896 http://cr.openjdk.java.net/~stuefe/webrevs/8212896-aix-build-broken-after-82...

Thank you,

Thomas