Re: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions
Hi, Ping. Can anyone review this enhancement backport request? Regards, Ogata Kazunori Ogata/Japan/IBM wrote on 2018/12/18 23:41:16:
From: Kazunori Ogata/Japan/IBM To: hotspot-compiler-dev@openjdk.java.net, ppc-aix-port-dev@openjdk.java.net Date: 2018/12/18 23:41 Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions
Hi,
May I get review for enhancement backport of 8154156: PPC64: improve array copy stubs by using vector instructions?
To make this patch buildable (and usable by other planned backports listed in [1]), I cherry picked config_dscr() and its dependent code from [2,3]
and has_mfdscr() from [4].
Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/c9d756fa846e Weberv: http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8154156/webrev.01/
I confirmed it was buildable for both relase and fastdebug builds, and JTREG caused no degradation.
Refs: [1] http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2018-December/ 003818.html [2] 8149655: PPC64: Implement CompactString intrinsics http://hg.openjdk.java.net/jdk/jdk/rev/6241574f5982 [3] 8080684: PPC64: Fix little-endian build after "8077838: Recent developments for ppc" http://hg.openjdk.java.net/jdk/jdk/rev/12ccf8b26eb0 [4] 8077838: Recent developments for ppc. http://hg.openjdk.java.net/jdk/jdk/rev/c703c89fddbf
Regards, Ogata
Hi Ogata, looks good to me. However, I'm not a jdk8u reviewer. Best regards, Martin -----Original Message----- From: ppc-aix-port-dev <ppc-aix-port-dev-bounces@openjdk.java.net> On Behalf Of Kazunori Ogata Sent: Montag, 7. Januar 2019 06:14 To: hotspot-compiler-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: Re: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions Hi, Ping. Can anyone review this enhancement backport request? Regards, Ogata Kazunori Ogata/Japan/IBM wrote on 2018/12/18 23:41:16:
From: Kazunori Ogata/Japan/IBM To: hotspot-compiler-dev@openjdk.java.net, ppc-aix-port-dev@openjdk.java.net Date: 2018/12/18 23:41 Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions
Hi,
May I get review for enhancement backport of 8154156: PPC64: improve array copy stubs by using vector instructions?
To make this patch buildable (and usable by other planned backports listed in [1]), I cherry picked config_dscr() and its dependent code from [2,3]
and has_mfdscr() from [4].
Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/c9d756fa846e Weberv: http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8154156/webrev.01/
I confirmed it was buildable for both relase and fastdebug builds, and JTREG caused no degradation.
Refs: [1] http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2018-December/ 003818.html [2] 8149655: PPC64: Implement CompactString intrinsics http://hg.openjdk.java.net/jdk/jdk/rev/6241574f5982 [3] 8080684: PPC64: Fix little-endian build after "8077838: Recent developments for ppc" http://hg.openjdk.java.net/jdk/jdk/rev/12ccf8b26eb0 [4] 8077838: Recent developments for ppc. http://hg.openjdk.java.net/jdk/jdk/rev/c703c89fddbf
Regards, Ogata
Hi Martin, Thank you for reviewing the patch. I'll submit RFR to jdk8u-dev mailing list referring your reply. Regards, Ogata "Doerr, Martin" <martin.doerr@sap.com> wrote on 2019/01/07 22:08:57:
From: "Doerr, Martin" <martin.doerr@sap.com> To: Kazunori Ogata <OGATAK@jp.ibm.com>, "hotspot-compiler- dev@openjdk.java.net" <hotspot-compiler-dev@openjdk.java.net>, "ppc-aix- port-dev@openjdk.java.net" <ppc-aix-port-dev@openjdk.java.net> Date: 2019/01/07 22:09 Subject: RE: [8u] RFR for backport of 8154156: PPC64: improve array copy
stubs by using vector instructions
Hi Ogata,
looks good to me. However, I'm not a jdk8u reviewer.
Best regards, Martin
-----Original Message----- From: ppc-aix-port-dev <ppc-aix-port-dev-bounces@openjdk.java.net> On Behalf Of Kazunori Ogata Sent: Montag, 7. Januar 2019 06:14 To: hotspot-compiler-dev@openjdk.java.net; ppc-aix-port-dev@openjdk.java.net Subject: Re: [8u] RFR for backport of 8154156: PPC64: improve array copy
stubs by using vector instructions
Hi,
Ping. Can anyone review this enhancement backport request?
Regards, Ogata
Kazunori Ogata/Japan/IBM wrote on 2018/12/18 23:41:16:
From: Kazunori Ogata/Japan/IBM To: hotspot-compiler-dev@openjdk.java.net, ppc-aix-port-dev@openjdk.java.net Date: 2018/12/18 23:41 Subject: [8u] RFR for backport of 8154156: PPC64: improve array copy stubs by using vector instructions
Hi,
May I get review for enhancement backport of 8154156: PPC64: improve array copy stubs by using vector instructions?
To make this patch buildable (and usable by other planned backports listed in [1]), I cherry picked config_dscr() and its dependent code from [2,3]
and has_mfdscr() from [4].
Original patch: http://hg.openjdk.java.net/jdk/jdk/rev/c9d756fa846e Weberv: http://cr.openjdk.java.net/~horii/jdk8u_aes_be/8154156/webrev.01/
I confirmed it was buildable for both relase and fastdebug builds, and
JTREG caused no degradation.
Refs: [1] http://mail.openjdk.java.net/pipermail/ppc-aix-port-dev/2018-December/ 003818.html [2] 8149655: PPC64: Implement CompactString intrinsics http://hg.openjdk.java.net/jdk/jdk/rev/6241574f5982 [3] 8080684: PPC64: Fix little-endian build after "8077838: Recent developments for ppc" http://hg.openjdk.java.net/jdk/jdk/rev/12ccf8b26eb0 [4] 8077838: Recent developments for ppc. http://hg.openjdk.java.net/jdk/jdk/rev/c703c89fddbf
Regards, Ogata
participants (2)
-
Doerr, Martin
-
Kazunori Ogata