RFR: 8202435: [aix] print program break as part of memory info into hs-err file
Hi all, may I please have reviews for this tiny, AIX-specific enhancement. bug: https://bugs.openjdk.java.net/browse/JDK-8202435 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8202435-aix-print-program-break/w... It prints out program break information as part of os::print_memory_info().
Hi Thomas, looks good. Just a minor thing: For "kilo" usually lower case "k" is used (like for "The thread stack size specified is invalid: "). But I don't need to see a new webrev for that. Thanks for contributing! Martin -----Original Message----- From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 3. Mai 2018 17:28 To: Hotspot dev runtime <hotspot-runtime-dev@openjdk.java.net>; ppc-aix-port-dev@openjdk.java.net Subject: RFR: 8202435: [aix] print program break as part of memory info into hs-err file Hi all, may I please have reviews for this tiny, AIX-specific enhancement. bug: https://bugs.openjdk.java.net/browse/JDK-8202435 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8202435-aix-print-program-break/w... It prints out program break information as part of os::print_memory_info().
Thank you Martin! On Thu, May 3, 2018, 17:50 Doerr, Martin <martin.doerr@sap.com> wrote:
Hi Thomas,
looks good. Just a minor thing: For "kilo" usually lower case "k" is used (like for "The thread stack size specified is invalid: "). But I don't need to see a new webrev for that.
Thanks for contributing! Martin
-----Original Message----- From: ppc-aix-port-dev [mailto:ppc-aix-port-dev-bounces@openjdk.java.net] On Behalf Of Thomas Stüfe Sent: Donnerstag, 3. Mai 2018 17:28 To: Hotspot dev runtime <hotspot-runtime-dev@openjdk.java.net>; ppc-aix-port-dev@openjdk.java.net Subject: RFR: 8202435: [aix] print program break as part of memory info into hs-err file
Hi all,
may I please have reviews for this tiny, AIX-specific enhancement.
bug: https://bugs.openjdk.java.net/browse/JDK-8202435 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8202435-aix-print-program-break/w...
It prints out program break information as part of os::print_memory_info().
Hi Thomas, Looks fine to me. Cheers, David On 4/05/2018 1:28 AM, Thomas Stüfe wrote:
Hi all,
may I please have reviews for this tiny, AIX-specific enhancement.
bug: https://bugs.openjdk.java.net/browse/JDK-8202435 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8202435-aix-print-program-break/w...
It prints out program break information as part of os::print_memory_info().
Thanks David! On Fri, May 4, 2018, 09:40 David Holmes <david.holmes@oracle.com> wrote:
Hi Thomas,
Looks fine to me.
Cheers, David
On 4/05/2018 1:28 AM, Thomas Stüfe wrote:
Hi all,
may I please have reviews for this tiny, AIX-specific enhancement.
bug: https://bugs.openjdk.java.net/browse/JDK-8202435 webrev: http://cr.openjdk.java.net/~stuefe/webrevs/8202435-aix-print-program-break/w...
It prints out program break information as part of os::print_memory_info().
participants (3)
-
David Holmes
-
Doerr, Martin
-
Thomas Stüfe