Hi, Jonathan.
20.03.2013 18:54, Jonathan Gibbons wrote
Someone should convert these JUnit tests to use TestNG.
Just to clarify. Are junit should not be used in regression tests of jdk and TestNG can be used?

-- Jon



On 03/20/2013 05:41 AM, Mani Sarkar wrote:
Oops, these tests are still failing despite copying junit.jar into the lib folder.

> FAILED: java/lang/invoke/AccessControlTest.java
> FAILED: java/lang/invoke/BigArityTest.java
> FAILED: java/lang/invoke/ClassValueTest.java
> FAILED: java/lang/invoke/InvokeGenericTest.java
> FAILED: java/lang/invoke/JavaDocExamplesTest.java
> FAILED: java/lang/invoke/MethodHandlesTest.java
> FAILED: java/lang/invoke/MethodTypeTest.java
> FAILED: java/lang/invoke/PermuteArgsTest.java
> FAILED: java/lang/invoke/PrivateInvokeTest.java
> FAILED: java/lang/invoke/RicochetTest.java
> FAILED: java/lang/invoke/ThrowExceptionsTest.java

They are still not finding junit.jar despite being placed next to jtreg.jar as you can see:

$ tree -P *.jar
.
├── lib
│   ├── javatest.jar
│   ├── jh.jar
│   ├── jtreg.jar
│   ├── junit.jar
│   └── testng.jar

java/lang/invoke/AccessControlTest.java                                                                            Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/BigArityTest.java                                                                                 Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/ClassValueTest.java                                                                               Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/InvokeGenericTest.java                                                                            Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/JavaDocExamplesTest.java                                                                          Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/MethodHandlesTest.java                                                                            Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/MethodTypeTest.java                                                                               Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/PermuteArgsTest.java                                                                              Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/PrivateInvokeTest.java                                                                            Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/RicochetTest.java                                                                                 Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
java/lang/invoke/ThrowExceptionsTest.java                                                                          Failed. Execution failed: `main' threw exception: java.lang.Exception: No JUnit 4 driver (install junit.jar next to jtreg.jar)
vm/verifier/TestStaticIF.java                                                                                      Failed. Unexpected exit from test [exit code: 134]

Cheers,
mani

On Wed, Mar 20, 2013 at 12:33 PM, Mani Sarkar <sadhak001@gmail.com> wrote:
Hi Balchandra,

Thanks for all the helpful tips.

I fixed Junit and reran the tests, also played around with the jtreg commands, and they worked as well - see wiki instructions [2] - any feedback is welcome. There are a couple of TODO items but other than that its pretty usable.

The link you posted [1] - isn't working for me, is it an internal one?


Cheers,
mani


On Tue, Mar 19, 2013 at 11:09 PM, Mani Sarkar <sadhak001@gmail.com> wrote:
Thanks Balachandra for your response., hope you had a good time away.

I'll get back to the list with a feedback once I have applied everyone's suggestions so far.


Cheers,
mani
--
Twitter: @theNeomatrix369
JUG activity: LJC Advocate (@adoptopenjdk & @adoptajsr programs)
Don't chase success, rather aim for "Excellence", and success will come chasing after you!



--
Twitter: @theNeomatrix369
JUG activity: LJC Advocate (@adoptopenjdk & @adoptajsr programs)
Don't chase success, rather aim for "Excellence", and success will come chasing after you!



--
Twitter: @theNeomatrix369
Blog: http://neomatrix369.wordpress.com
JUG activity: LJC Advocate (@adoptopenjdk & @adoptajsr programs)
Meet-a-Project: https://github.com/MutabilityDetector
Come to Devoxx UK 2013: http://www.devoxx.com/display/UK13/Home
Don't chase success, rather aim for "Excellence", and success will come chasing after you!



-- 
Best regards, Sergey.