On Fri, 24 Dec 2021 07:08:31 GMT, Fei Yang <fyang@openjdk.org> wrote:
Xiaolin Zheng has updated the pull request incrementally with three additional commits since the last revision:
- Cover most RVC instructions by using CompressibleRegion to cover minimal functions in C2 - Revise as proposed comments, including - Fix macros in assembler_riscv_c.hpp - Remove UncompressibleRegion - Modify comments - Change names: C-Ext to RVC - Enable RVC instructions (based on the basic patch)
src/hotspot/cpu/riscv/assembler_riscv_c.hpp line 30:
28: 29: private: 30: bool _in_compressible_region;
So where will this variable be used then?
Sorry I missed this comment. This variable `_in_compressible_region` is used in `CompressibleRegion cr(&_masm)`. During [RTTI](https://github.com/openjdk/riscv-port/blob/dbc763edfbee277125283fdd0cf98f46d...) this variable is set, and when emitting instructions inside the region, instructions inside the region will be considered qualified as safe to be emitted as RVC instructions -- please see the [macros](https://github.com/openjdk/riscv-port/blob/dbc763edfbee277125283fdd0cf98f46d...) and [an example usage](https://github.com/openjdk/riscv-port/blob/dbc763edfbee277125283fdd0cf98f46d...). ------------- PR: https://git.openjdk.java.net/riscv-port/pull/34