[riscv-port] RFR: 8277430: riscv: Refactor interpreter native wrappers
A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. ------------- Commit messages: - 8277430: riscv: Refactor interpreter native wrappers Changes: https://git.openjdk.java.net/riscv-port/pull/12/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=12&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8277430 Stats: 155 lines in 2 files changed: 39 ins; 33 del; 83 mod Patch: https://git.openjdk.java.net/riscv-port/pull/12.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/12/head:pull/12 PR: https://git.openjdk.java.net/riscv-port/pull/12
On Mon, 22 Nov 2021 09:53:44 GMT, Yadong Wang <yadongwang@openjdk.org> wrote:
A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures.
Changes requested by fyang (Lead). src/hotspot/cpu/riscv/interpreterRT_riscv.cpp line 175:
173: private: 174: address _from; 175: char* _to;
It would be better to do this change in another commit. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/12
A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures.
Yadong Wang has updated the pull request incrementally with one additional commit since the last revision: 8277430: riscv: Refactor interpreter native wrappers(2) ------------- Changes: - all: https://git.openjdk.java.net/riscv-port/pull/12/files - new: https://git.openjdk.java.net/riscv-port/pull/12/files/d6d4c6fd..b0e28c80 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=12&range=01 - incr: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=12&range=00-01 Stats: 11 lines in 1 file changed: 0 ins; 2 del; 9 mod Patch: https://git.openjdk.java.net/riscv-port/pull/12.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/12/head:pull/12 PR: https://git.openjdk.java.net/riscv-port/pull/12
On Tue, 23 Nov 2021 02:55:07 GMT, Yadong Wang <yadongwang@openjdk.org> wrote:
A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures.
Yadong Wang has updated the pull request incrementally with one additional commit since the last revision:
8277430: riscv: Refactor interpreter native wrappers(2)
Updated changes looks good. Nice cleanup! ------------- Marked as reviewed by fyang (Lead). PR: https://git.openjdk.java.net/riscv-port/pull/12
On Mon, 22 Nov 2021 09:53:44 GMT, Yadong Wang <yadongwang@openjdk.org> wrote:
A similar refactor similar to https://bugs.openjdk.java.net/browse/JDK-8261071, to make the code more clean and open for extension. Hotspot and jdk tier1 test passed on unmatched boards. All JTreg tests were tested on qemu without new failures.
This pull request has now been integrated. Changeset: 2485efbf Author: Yadong Wang <yadongwang@openjdk.org> Committer: Fei Yang <fyang@openjdk.org> URL: https://git.openjdk.java.net/riscv-port/commit/2485efbf90041ff98506dfe46d254... Stats: 152 lines in 2 files changed: 38 ins; 34 del; 80 mod 8277430: riscv: Refactor interpreter native wrappers Reviewed-by: fyang ------------- PR: https://git.openjdk.java.net/riscv-port/pull/12
participants (2)
-
Fei Yang
-
Yadong Wang