[riscv-port] RFR: 8276832: riscv: typo in LIR_Assembler::check_no_conflict
This is similar to: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type. Difference is that LIR_Assembler::emit_profile_type is refactored and now the typo is in LIR_Assembler::check_no_conflict. And LIR_Assembler::check_no_conflict is only called by LIR_Assembler::emit_profile_type for now. ------------- Commit messages: - 8276832: riscv: typo in LIR_Assembler::check_no_conflict Changes: https://git.openjdk.java.net/riscv-port/pull/23/files Webrev: https://webrevs.openjdk.java.net/?repo=riscv-port&pr=23&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-8276832 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/riscv-port/pull/23.diff Fetch: git fetch https://git.openjdk.java.net/riscv-port pull/23/head:pull/23 PR: https://git.openjdk.java.net/riscv-port/pull/23
On Mon, 6 Dec 2021 09:51:14 GMT, Yanhong Zhu <yzhu@openjdk.org> wrote:
This is similar to: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type.
Difference is that LIR_Assembler::emit_profile_type is refactored and now the typo is in LIR_Assembler::check_no_conflict.
And LIR_Assembler::check_no_conflict is only called by LIR_Assembler::emit_profile_type for now.
Looks good! ------------- Marked as reviewed by shade (Reviewer). PR: https://git.openjdk.java.net/riscv-port/pull/23
On Mon, 6 Dec 2021 09:53:06 GMT, Aleksey Shipilev <shade@openjdk.org> wrote:
Looks good!
Thanks for the quick review. Verified with the original testcase. I have pasted the test result in PR description. ------------- PR: https://git.openjdk.java.net/riscv-port/pull/23
On Mon, 6 Dec 2021 09:51:14 GMT, Yanhong Zhu <yzhu@openjdk.org> wrote:
This is similar to: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type.
Difference is that LIR_Assembler::emit_profile_type is refactored and now the typo is in LIR_Assembler::check_no_conflict.
And LIR_Assembler::check_no_conflict is only called by LIR_Assembler::emit_profile_type for now.
The result of testcase on QEMU（https://bugs.openjdk.java.net/secure/attachment/95368/Test.java）： Before：
static Test::test(LTest$A;I)I interpreter_invocation_count: 5376 invocation_counter: 5376 backedge_counter: 0 decompile_count: 0 mdo size: 416 bytes
ParametersTypeData 0: stack(0) none
After "ld" -> "sd":
static Test::test(LTest$A;I)I interpreter_invocation_count: 5376 invocation_counter: 5376 backedge_counter: 0 decompile_count: 0 mdo size: 416 bytes
ParametersTypeData 0: stack(0) 'Test$A'
This pull request has now been integrated. Changeset: 997bbe2b Author: Yanhong Zhu <yzhu@openjdk.org> Committer: Fei Yang <fyang@openjdk.org> URL: https://git.openjdk.java.net/riscv-port/commit/997bbe2b60813a1a5d394b60ba25d... Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod 8276832: riscv: typo in LIR_Assembler::check_no_conflict Reviewed-by: shade ------------- PR: https://git.openjdk.java.net/riscv-port/pull/23
participants (2)
-
Aleksey Shipilev
-
Yanhong Zhu