September 2016 - s390x-port-dev

RFR: JEP draft for Linux/s3990x port
by Volker Simonis 27 Oct '16

27 Oct '16

Hi, can you please review and endorse the following draft JEP for the integration of the Linux/s390x port into the jkd9 master repository: https://bugs.openjdk.java.net/browse/JDK-8166730 As detailed in the JEP, the Linux/s390x requires very few shared changes and we therefore don't foresee any impact on the existing platforms at all. Following you can find a short description of the planned changes: hotspot: ======= Out for review: 8166560: [s390] Basic enablement of s390 port. http://cr.openjdk.java.net/~goetz/wr16/8166560-basic_s390/hotspot.wr01/ Reviewed: 8166562: C2: Suppress relocations in scratch emit. http://cr.openjdk.java.net/~goetz/wr16/8166562-scratch_emit/webrev.01/ Will send RFR soon (depends on 8166560): 8166561: [s390] Adaptions needed for s390 port in C1 and C2. http://cr.openjdk.java.net/~goetz/wr16/8166562-scratch_emit/webrev.01 We are still investigating the need of these shared changes: http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000011-pa… http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000016-co… And finally the patch with the s390x-only platform files. We are still editing these to get them into OpenJdk style and shape. Hotspot passes most jck, jtreg and spec tests with these. http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/hotspot/9000101-zF… top-level repository: =============== The following is just adding some s390x specific compiler flags to flags.m4 8166800: [s390] Top-level build changes required for Linux/s390x https://bugs.openjdk.java.net/browse/JDK-8166800 jdk repository: ============ This one just adds a new jvm.cfg file for s390x 8166801: [s390] Add jvm.cfg file for Linux/s390x https://bugs.openjdk.java.net/browse/JDK-8166801 And finally we plan to do one more change which fixes the jtreg test on Linux/s390x. But this is mainly for the correct detection of the platform and for excluding the tests which are not appropriate for s390x. Thank you and best regards, Volker

3 13

RE: OpenJDK9 build issues for s390x
by Lindenmaier, Goetz 21 Sep '16

21 Sep '16

Hi, I uploaded an updated patch queue to my own webrev space: http://cr.openjdk.java.net/~goetz/wr16/s390x_patch_queue/ Vaibhav, you need to apply this to the hs-comp repository. Best regards, Goetz. > -----Original Message----- > From: Volker Simonis [mailto:volker.simonis@gmail.com] > Sent: Dienstag, 20. September 2016 17:38 > To: s390x-port-dev(a)openjdk.java.net; vaibhavv(a)us.ibm.com; Lindenmaier, > Goetz <goetz.lindenmaier(a)sap.com> > Subject: Re: s390x-port-dev post from vaibhavv(a)us.ibm.com requires > approval > > Hi Vaibhav, > > thanks a lot for your interest in the s390x port and sorry for the > inconvenience. We haven't updated the patch for some weeks and it may > be very well possible that it doesn't cleanly apply to the current > version any more. But this doesn't mean that we're not working on the > port internally. > > @Goetz: can you please be so kind to upload a new version of our patch > queue? > > If your impatient, you could try to sync back the whole jdk9/hs forest > to the date when I uploaded the patch queue (around Aug 1st). That > should work as I've tested that version before uploading the patches. > > That said, I'd like to kindly ask you to subscribe to the > s390x-port-dev mailing list at > http://mail.openjdk.java.net/mailman/listinfo/s390x-port-dev, > otherwise you posts will not be accepted by the list. > > Thank you and best regards, > Volker > > > On Tue, Sep 20, 2016 at 3:09 AM, <s390x-port-dev- > owner(a)openjdk.java.net> wrote: > > As list administrator, your authorization is requested for the > > following mailing list posting: > > > > List: s390x-port-dev(a)openjdk.java.net > > From: vaibhavv(a)us.ibm.com > > Subject: OpenJDK9 build issues for s390x > > Reason: Post by non-member to a members-only list > > > > At your convenience, visit: > > > > http://mail.openjdk.java.net/mailman/admindb/s390x-port-dev > > > > to approve or deny the request. > > > > > > ---------- Forwarded message ---------- > > From: Vaibhav Vaingankar <vaibhavv(a)us.ibm.com> > > To: s390x-port-dev(a)openjdk.java.net > > Cc: Cindy Lee <cinderel(a)ca.ibm.com>, Amod Borkar > <aborkar(a)us.ibm.com> > > Date: Tue, 20 Sep 2016 15:38:55 +0530 > > Subject: OpenJDK9 build issues for s390x > > > > Hello, > > > > We are trying to build openjdk for s390x. We did face issues while doing the > same. > > > > Applying of patch failed > > After manually making the changes as per the patch build failed > > > > > > Following are the steps we followed to build openJDK > > > > 1. Clone openjdk hs branch > > > > hg clone http://hg.openjdk.java.net/jdk9/hs/ > > cd hs > > sh ./get_sources.sh > > > > 2. Apply s390x patches > > > > - Download all s390x patches from here. > > - copy all the .patch files in hs/hotspot/.hg/patches folder > > - Run following command to apply the patch > > > > cd hs/hotspot > > hg qpush -a > > > > Note: The patch 9000017-add_defines_shared.patch fails to apply. > > > > Hunk #3 FAILED at 405 > > 1 out of 3 hunks FAILED -- saving rejects to file > src/share/vm/utilities/macros.hpp.rej > > patch failed, rejects left in working dir > > errors during apply, please fix and refresh 9000017- > add_defines_shared.patch > > We than made the changes manually in the file > src/share/vm/utilities/macros.hpp as per the patch. > > > > 3. Next, we tried to build using the following commands: > > > > bash ./configure --disable-hotspot-gtest > > make all > > > > Build failed > > > > gmake[3]: *** No rule to make target > `/home/test/hs/jdk/src/java.base/unix/conf/s390x/jvm.cfg', needed by > `/home/test/hs/build/linux-s390x-normal-server- > release/support/modules_libs/java.base/s390x/jvm.cfg'. Stop. > > gmake[3]: *** Waiting for unfinished jobs.... > > gmake[2]: *** [java.base-copy-jdk] Error 1 > > > > > > Please let us know if we are missing anything here. > > > > Regards, > > Vaibhav > > > > > > > > > > ---------- Forwarded message ---------- > > From: s390x-port-dev-request(a)openjdk.java.net > > To: > > Cc: > > Date: Tue, 20 Sep 2016 10:09:11 +0000 > > Subject: confirm 064fbee247ff69a4e6ba78ad753ee3f97d9cc317 > > If you reply to this message, keeping the Subject: header intact, > > Mailman will discard the held message. Do this if the message is > > spam. If you reply to this message and include an Approved: header > > with the list password in it, the message will be approved for posting > > to the list. The Approved: header can also appear in the first line > > of the body of the reply.

2 1

Re: s390x-port-dev post from vaibhavv@us.ibm.com requires approval
by Volker Simonis 20 Sep '16

20 Sep '16

Hi Vaibhav, thanks a lot for your interest in the s390x port and sorry for the inconvenience. We haven't updated the patch for some weeks and it may be very well possible that it doesn't cleanly apply to the current version any more. But this doesn't mean that we're not working on the port internally. @Goetz: can you please be so kind to upload a new version of our patch queue? If your impatient, you could try to sync back the whole jdk9/hs forest to the date when I uploaded the patch queue (around Aug 1st). That should work as I've tested that version before uploading the patches. That said, I'd like to kindly ask you to subscribe to the s390x-port-dev mailing list at http://mail.openjdk.java.net/mailman/listinfo/s390x-port-dev, otherwise you posts will not be accepted by the list. Thank you and best regards, Volker On Tue, Sep 20, 2016 at 3:09 AM, <s390x-port-dev-owner(a)openjdk.java.net> wrote: > As list administrator, your authorization is requested for the > following mailing list posting: > > List: s390x-port-dev(a)openjdk.java.net > From: vaibhavv(a)us.ibm.com > Subject: OpenJDK9 build issues for s390x > Reason: Post by non-member to a members-only list > > At your convenience, visit: > > http://mail.openjdk.java.net/mailman/admindb/s390x-port-dev > > to approve or deny the request. > > > ---------- Forwarded message ---------- > From: Vaibhav Vaingankar <vaibhavv(a)us.ibm.com> > To: s390x-port-dev(a)openjdk.java.net > Cc: Cindy Lee <cinderel(a)ca.ibm.com>, Amod Borkar <aborkar(a)us.ibm.com> > Date: Tue, 20 Sep 2016 15:38:55 +0530 > Subject: OpenJDK9 build issues for s390x > > Hello, > > We are trying to build openjdk for s390x. We did face issues while doing the same. > > Applying of patch failed > After manually making the changes as per the patch build failed > > > Following are the steps we followed to build openJDK > > 1. Clone openjdk hs branch > > hg clone http://hg.openjdk.java.net/jdk9/hs/ > cd hs > sh ./get_sources.sh > > 2. Apply s390x patches > > - Download all s390x patches from here. > - copy all the .patch files in hs/hotspot/.hg/patches folder > - Run following command to apply the patch > > cd hs/hotspot > hg qpush -a > > Note: The patch 9000017-add_defines_shared.patch fails to apply. > > Hunk #3 FAILED at 405 > 1 out of 3 hunks FAILED -- saving rejects to file src/share/vm/utilities/macros.hpp.rej > patch failed, rejects left in working dir > errors during apply, please fix and refresh 9000017-add_defines_shared.patch > We than made the changes manually in the file src/share/vm/utilities/macros.hpp as per the patch. > > 3. Next, we tried to build using the following commands: > > bash ./configure --disable-hotspot-gtest > make all > > Build failed > > gmake[3]: *** No rule to make target `/home/test/hs/jdk/src/java.base/unix/conf/s390x/jvm.cfg', needed by `/home/test/hs/build/linux-s390x-normal-server-release/support/modules_libs/java.base/s390x/jvm.cfg'. Stop. > gmake[3]: *** Waiting for unfinished jobs.... > gmake[2]: *** [java.base-copy-jdk] Error 1 > > > Please let us know if we are missing anything here. > > Regards, > Vaibhav > > > > > ---------- Forwarded message ---------- > From: s390x-port-dev-request(a)openjdk.java.net > To: > Cc: > Date: Tue, 20 Sep 2016 10:09:11 +0000 > Subject: confirm 064fbee247ff69a4e6ba78ad753ee3f97d9cc317 > If you reply to this message, keeping the Subject: header intact, > Mailman will discard the held message. Do this if the message is > spam. If you reply to this message and include an Approved: header > with the list password in it, the message will be approved for posting > to the list. The Approved: header can also appear in the first line > of the body of the reply.

2 1