s390x-port-dev

Download

s390x-port-dev@openjdk.org

November 2017

5 participants
2 discussions

RFR(S): 8191863: [s390] Fix CDS: some bytecode rewriting doesn't depend on RewriteControl
by Volker Simonis 27 Nov '17

27 Nov '17

Hi, can I please have a review for the following small, s390-only change which fixes CDS on s390: http://cr.openjdk.java.net/~simonis/webrevs/2017/8191863/ https://bugs.openjdk.java.net/browse/JDK-8191863 The problem was that mistakenly rewrote zputfield into fast_zputfield although the active RewriteControl instance indicated that we shouldn't rewrite bytecodes. With this change, all the CDS and upcoming AppCDS jtreg pass on Linux/s390. Thank you and best regards, Volker

4 5

RFR(S) 8190817: deopt special-case for _return_register_finalizer is confusing and leads to bugs
by dean.long＠oracle.com 13 Nov '17

13 Nov '17

https://bugs.openjdk.java.net/browse/JDK-8190817 http://cr.openjdk.java.net/~dlong/8190817/webrev/ This fix replaces the problematic use of _normal_table.entry(Bytecodes::_return).entry(vtos) as a deoptimization entry point with a proper deopt entry point returned by deopt_reexecute_return_entry(). This is needed to handle the situation where compiled code is calling register_finalizer() and gets deoptimized. I also noticed that we generate duplicate entry points unnecessarily, so I cleaned that up at the same time. aarch64/ppc64/s390 folks, please check that compiler/runtime/Test8168712.java still passes. dl

1 0