RFR (XS) 8175267: [s390] cleanup stub code "handler_for_unsafe_access"
Hi all, May I kindly request reviews for my very small cleanup change? Further down the road, I would need a sponsor, too. Bug: https://bugs.openjdk.java.net/browse/JDK-8175267 Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8175267/ Description: The "handler_for_unsafe_access” is a relic from former times, having survived only on s390x. The stub is generated, but never used (called). This change removes everything related. Thanks, Lutz
Hi Lutz, thanks for doing this cleanup. Looks good to me. I think I can sponsor it as it only touches s390 files and is targeted for jdk10. However, we need a jdk10 reviewer, too. Best regards, Martin -----Original Message----- From: s390x-port-dev [mailto:s390x-port-dev-bounces@openjdk.java.net] On Behalf Of Schmidt, Lutz Sent: Dienstag, 21. Februar 2017 16:38 To: s390x-port-dev@openjdk.java.net; hotspot-dev@openjdk.java.net Subject: RFR (XS) 8175267: [s390] cleanup stub code "handler_for_unsafe_access" Hi all, May I kindly request reviews for my very small cleanup change? Further down the road, I would need a sponsor, too. Bug: https://bugs.openjdk.java.net/browse/JDK-8175267 Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8175267/ Description: The "handler_for_unsafe_access” is a relic from former times, having survived only on s390x. The stub is generated, but never used (called). This change removes everything related. Thanks, Lutz
Thank you, Martin, for reviewing this one. Regards, Lutz
On 21 Feb 2017, at 18:11, Doerr, Martin <martin.doerr@sap.com> wrote:
Hi Lutz,
thanks for doing this cleanup. Looks good to me. I think I can sponsor it as it only touches s390 files and is targeted for jdk10. However, we need a jdk10 reviewer, too.
Best regards, Martin
-----Original Message----- From: s390x-port-dev [mailto:s390x-port-dev-bounces@openjdk.java.net] On Behalf Of Schmidt, Lutz Sent: Dienstag, 21. Februar 2017 16:38 To: s390x-port-dev@openjdk.java.net; hotspot-dev@openjdk.java.net Subject: RFR (XS) 8175267: [s390] cleanup stub code "handler_for_unsafe_access"
Hi all,
May I kindly request reviews for my very small cleanup change? Further down the road, I would need a sponsor, too.
Bug: https://bugs.openjdk.java.net/browse/JDK-8175267 Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8175267/
Description: The "handler_for_unsafe_access” is a relic from former times, having survived only on s390x. The stub is generated, but never used (called). This change removes everything related.
Thanks, Lutz
Hi Lutz, the change looks good. Best regards, Goetz.
-----Original Message----- From: s390x-port-dev [mailto:s390x-port-dev-bounces@openjdk.java.net] On Behalf Of Doerr, Martin Sent: Dienstag, 21. Februar 2017 19:11 To: Schmidt, Lutz <lutz.schmidt@sap.com>; s390x-port- dev@openjdk.java.net; hotspot-dev@openjdk.java.net Subject: RE: RFR (XS) 8175267: [s390] cleanup stub code "handler_for_unsafe_access"
Hi Lutz,
thanks for doing this cleanup. Looks good to me. I think I can sponsor it as it only touches s390 files and is targeted for jdk10. However, we need a jdk10 reviewer, too.
Best regards, Martin
-----Original Message----- From: s390x-port-dev [mailto:s390x-port-dev-bounces@openjdk.java.net] On Behalf Of Schmidt, Lutz Sent: Dienstag, 21. Februar 2017 16:38 To: s390x-port-dev@openjdk.java.net; hotspot-dev@openjdk.java.net Subject: RFR (XS) 8175267: [s390] cleanup stub code "handler_for_unsafe_access"
Hi all,
May I kindly request reviews for my very small cleanup change? Further down the road, I would need a sponsor, too.
Bug: https://bugs.openjdk.java.net/browse/JDK-8175267 Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8175267/
Description: The "handler_for_unsafe_access” is a relic from former times, having survived only on s390x. The stub is generated, but never used (called). This change removes everything related.
Thanks, Lutz
Hi Lutz, I concur that this removes all code related to handler_for_unsafe_access in the s390 code. Reviewed. :) Thanks, David On 22/02/2017 1:38 AM, Schmidt, Lutz wrote:
Hi all,
May I kindly request reviews for my very small cleanup change? Further down the road, I would need a sponsor, too.
Bug: https://bugs.openjdk.java.net/browse/JDK-8175267 Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8175267/
Description: The "handler_for_unsafe_access” is a relic from former times, having survived only on s390x. The stub is generated, but never used (called). This change removes everything related.
Thanks, Lutz
Hi David, thanks for reviewing! Lutz On 22.02.17, 04:09, "David Holmes" <david.holmes@oracle.com> wrote: Hi Lutz, I concur that this removes all code related to handler_for_unsafe_access in the s390 code. Reviewed. :) Thanks, David On 22/02/2017 1:38 AM, Schmidt, Lutz wrote: > Hi all, > > May I kindly request reviews for my very small cleanup change? Further down the road, I would need a sponsor, too. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8175267 > Webrev: http://cr.openjdk.java.net/~lucy/webrevs/8175267/ > > Description: > The "handler_for_unsafe_access” is a relic from former times, having survived only on s390x. The stub is generated, but never used (called). This change removes everything related. > > Thanks, > Lutz >
participants (4)
-
David Holmes
-
Doerr, Martin
-
Lindenmaier, Goetz
-
Schmidt, Lutz