RFR: 8302857: Generational ZGC: enable correctness barrier elision tests on all platforms
This changeset splits the recent barrier elision tests added by [JDK-8301584](https://bugs.openjdk.org/browse/JDK-8301584) and extended by [JDK-8301769](https://bugs.openjdk.org/browse/JDK-8301769) into correctness tests (do not elide necessary barriers) and effectiveness tests (do elide unnecessary barriers), and enables the former on all platforms that support ZGC, following the [discussion on JDK-8301769](https://github.com/openjdk/zgc/pull/13). {@TheRealMDoerr, @RealFYang}: could you please check whether the updated tests pass on the other ZGC-supporting platforms? **Testing:** re-run the updated tests (x64 and aaarch64; linux, windows, and macosx; release and debug mode) ------------- Commit messages: - Split tests and enable correctness ones on all platforms Changes: https://git.openjdk.org/zgc/pull/14/files Webrev: https://webrevs.openjdk.org/?repo=zgc&pr=14&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8302857 Stats: 382 lines in 1 file changed: 169 ins; 127 del; 86 mod Patch: https://git.openjdk.org/zgc/pull/14.diff Fetch: git fetch https://git.openjdk.org/zgc pull/14/head:pull/14 PR: https://git.openjdk.org/zgc/pull/14
On Mon, 20 Feb 2023 12:28:47 GMT, Roberto Castañeda Lozano <rcastanedalo@openjdk.org> wrote:
This changeset splits the recent barrier elision tests added by [JDK-8301584](https://bugs.openjdk.org/browse/JDK-8301584) and extended by [JDK-8301769](https://bugs.openjdk.org/browse/JDK-8301769) into correctness tests (do not elide necessary barriers) and effectiveness tests (do elide unnecessary barriers), and enables the former on all platforms that support ZGC, following the [discussion on JDK-8301769](https://github.com/openjdk/zgc/pull/13).
{@TheRealMDoerr, @RealFYang}: could you please check whether the updated tests pass on the other ZGC-supporting platforms?
**Testing:** re-run the updated tests (x64 and aaarch64; linux, windows, and macosx; release and debug mode)
Hi, this passed with fastdebug build on linux-riscv: Running test 'jtreg:./test/hotspot/jtreg/compiler/gcbarriers/TestZGCBarrierElision.java' Passed: compiler/gcbarriers/TestZGCBarrierElision.java#id0 Test results: passed: 1 ------------- PR: https://git.openjdk.org/zgc/pull/14
On Mon, 20 Feb 2023 13:44:19 GMT, Fei Yang <fyang@openjdk.org> wrote:
Hi, this passed with fastdebug build on linux-riscv:
Thanks for checking, @RealFYang ! ------------- PR: https://git.openjdk.org/zgc/pull/14
On Mon, 20 Feb 2023 12:28:47 GMT, Roberto Castañeda Lozano <rcastanedalo@openjdk.org> wrote:
This changeset splits the recent barrier elision tests added by [JDK-8301584](https://bugs.openjdk.org/browse/JDK-8301584) and extended by [JDK-8301769](https://bugs.openjdk.org/browse/JDK-8301769) into correctness tests (do not elide necessary barriers) and effectiveness tests (do elide unnecessary barriers), and enables the former on all platforms that support ZGC, following the [discussion on JDK-8301769](https://github.com/openjdk/zgc/pull/13).
{@TheRealMDoerr, @RealFYang}: could you please check whether the updated tests pass on the other ZGC-supporting platforms?
**Testing:** re-run the updated tests (x64 and aaarch64; linux, windows, and macosx; release and debug mode)
Hi, the test has passed on PPC64le, too. Thanks! ------------- PR: https://git.openjdk.org/zgc/pull/14
On Mon, 20 Feb 2023 14:37:48 GMT, Martin Doerr <mdoerr@openjdk.org> wrote:
Hi, the test has passed on PPC64le, too. Thanks!
Great, thanks for checking @TheRealMDoerr ! ------------- PR: https://git.openjdk.org/zgc/pull/14
On Mon, 20 Feb 2023 12:28:47 GMT, Roberto Castañeda Lozano <rcastanedalo@openjdk.org> wrote:
This changeset splits the recent barrier elision tests added by [JDK-8301584](https://bugs.openjdk.org/browse/JDK-8301584) and extended by [JDK-8301769](https://bugs.openjdk.org/browse/JDK-8301769) into correctness tests (do not elide necessary barriers) and effectiveness tests (do elide unnecessary barriers), and enables the former on all platforms that support ZGC, following the [discussion on JDK-8301769](https://github.com/openjdk/zgc/pull/13).
{@TheRealMDoerr, @RealFYang}: could you please check whether the updated tests pass on the other ZGC-supporting platforms?
**Testing:** re-run the updated tests (x64 and aaarch64; linux, windows, and macosx; release and debug mode)
Looks good. ------------- Marked as reviewed by eosterlund (Reviewer). PR: https://git.openjdk.org/zgc/pull/14
On Wed, 1 Mar 2023 12:33:34 GMT, Erik Österlund <eosterlund@openjdk.org> wrote:
Looks good.
Thanks for reviewing, Erik! ------------- PR: https://git.openjdk.org/zgc/pull/14
On Mon, 20 Feb 2023 12:28:47 GMT, Roberto Castañeda Lozano <rcastanedalo@openjdk.org> wrote:
This changeset splits the recent barrier elision tests added by [JDK-8301584](https://bugs.openjdk.org/browse/JDK-8301584) and extended by [JDK-8301769](https://bugs.openjdk.org/browse/JDK-8301769) into correctness tests (do not elide necessary barriers) and effectiveness tests (do elide unnecessary barriers), and enables the former on all platforms that support ZGC, following the [discussion on JDK-8301769](https://github.com/openjdk/zgc/pull/13).
{@TheRealMDoerr, @RealFYang}: could you please check whether the updated tests pass on the other ZGC-supporting platforms?
**Testing:** re-run the updated tests (x64 and aaarch64; linux, windows, and macosx; release and debug mode)
This pull request has now been integrated. Changeset: 3da8cd2f Author: Roberto Castañeda Lozano <rcastanedalo@openjdk.org> URL: https://git.openjdk.org/zgc/commit/3da8cd2fcca534ae8d887aa94834a9b53ee314ad Stats: 382 lines in 1 file changed: 169 ins; 127 del; 86 mod 8302857: Generational ZGC: enable correctness barrier elision tests on all platforms Reviewed-by: eosterlund ------------- PR: https://git.openjdk.org/zgc/pull/14
participants (4)
-
Erik Österlund
-
Fei Yang
-
Martin Doerr
-
Roberto Castañeda Lozano