[OpenJDK 2D-Dev] Code review request to integrated IcedTea lcms fixes into OpenJDK 6

Alexey Ushakov Alexey.Ushakov at Sun.COM
Thu Aug 7 12:41:41 UTC 2008


Looks good for me.

Best Regards,
Alexey

Joseph D. Darcy wrote:
> Hello.
>
> I'm working on getting the baseline OpenJDK 6 code base to pass JCK 
> 6b.  Toward that end I'm requesting a code review of my application of 
> little cms patches previously sent in by Keith:
>    http://mail.openjdk.java.net/pipermail/2d-dev/2008-April/000228.html
> and Tom:
>    
> http://mail.openjdk.java.net/pipermail/awt-dev/2007-November/000107.html,
> These are also the IcedTea patches
>    icedtea-LCMS-setTagData.patch: Add support for setTagData to LCMS 
> peer.
>    icedtea-lcms-leak.patch: Fix LCMS memory leak.
> respectively.
>
> I've applied the patches to OpenJDK 6 build 11; existing cmm 
> regression tests pass as do more JCK tests (see bug 6657581).
>
> Webrev uploaded to:
> http://dcstaff.invokedynamic.info/images/7/7e/darcy-6733501.tgz
>
> It would be helpful to have a review by August 8 to ease getting this 
> change into OpenJDK 6 build 12.
>
> Thanks,
>
> -Joe




More information about the 2d-dev mailing list