[OpenJDK 2D-Dev] Still waiting for review

[Phil Race]

We're going to institute some better tracking of these, at least in the 
2D team, so that individual engineers
beng tied up doesn't leave these forgotten on the floor (not that these 
were forgotten, just backlogged).

The fixes look OK although there's a few tweaks we think are needed - to 
both your IIO fixes
and Mark's pisces fixes. We are making those.

But there are some things I need to make sure of from our checklist, eg
- patch in an acceptable format (webrev preferred)
- follows coding standards
- has regression test, or explanation why this isn't possible (eg build 
fix, doc fix, perf fix ..)
- contributor of the fix has signed the Sun Contributor Agreement.

The regression test inclusion is a standard we apply internally too.
Martin's fixes look to pass all of these tests, but for Mark's we'll 
need to either receive or attempt to create a regression test.

In addition I recall from another thread 
(http://mail.openjdk.java.net/pipermail/build-dev/2008-November/001613.html)
that we need to receive Mark's fix via Redhat to be covered under the SCA
The SCA is a requirement that we need to check before integrating, I 
know this can sound
like setting roadblocks, but as individual engineers we are not 
empowered to waive this requirement.
Mark : can you please resubmit. Then we'll get them in ASAP.

-phil.

Martin von Gagern wrote:
> Mark Wielaard wrote:
>   
>> Martin, if you like we can use IcedTea http://icedtea.classpath.org/ as
>> staging area for these fixes. That is what I do after testing. The above
>> two fixes are already in IcedTea6 for a couple of months since I know
>> other users are seeing the same bugs. That way things are at least
>> picked up in a timely manner for the various GNU/Linux distros out
>> there. http://icedtea.classpath.org/hg/icedtea6
>>     
>
> Hi Mark!
>
> Looking at the IcedTea FAQs I read "It is not a fork of the OpenJDK, and
> doesn't contain the OpenJDK source code". So I'm a bit surprised about
> the suggestion. Looking at the repository, I see a collection of
> patches, which seems to be the place you had in mind.
>
> While I like the idea of making my chnges available to distros even
> before they have been officially accepted into OpenJDK, it feels a bit
> like a misuse of the IcedTea project. A community-driven experimental
> fork would be more suitable to stage such patches imho.
>
> As acceptance into OpenJDK still is my primary goal, and as Igor's mail
> indicates light at the end of the tunnel in that direction, I'm inclined
> to rather wait for the review than invest additional effort into pushing
> those patches into yet another project.
>
> Still thanks for the suggestion, I'll keep it in mind and get back to
> that if things don't work out here.
>
> Greetings,
>  Martin
>
>