[OpenJDK 2D-Dev] LCMS stale native method

Roman Kennke roman.kennke at aicas.com
Wed May 28 19:45:30 UTC 2008


I notice that there is a native method freeTransform() in LCMS.java, but
LCMS.c doesn't have an implementation for that. There is only
LCMS_freeTransform(), which of course isn't a JNI method. It could
easily be implemented like this:

JNIEXPORT void JNICALL
Java_sun_java2d_cmm_lcms_LCMS_freeTransform(JNIEnv* env, jclass cls,
jlong id) {
  LCMS_freeTransform(env, id);
}

Wondering, why this never showed up anywhere, I digged a little deeper
an looked around for possible callers of freeTransform(), but found
none. Considering this, I think this must be a stale method maybe left
from some earlier experiments and could be removed now. Is this correct?
In this case, I would propose to remove the native method declaration.

Cheers, Roman

-- 
Dipl.-Inform. (FH) Roman Kennke, Software Engineer, http://kennke.org
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-0
USt-Id: DE216375633, Handelsregister HRB 109481, AG Karlsruhe
Geschäftsführer: Dr. James J. Hunt




More information about the 2d-dev mailing list