[OpenJDK 2D-Dev] [PATCH] Request for review: 6888734, regression test fails when java.security.manager is enabled

Dmitri Trembovetski Dmitri.Trembovetski at Sun.COM
Mon Dec 7 21:48:09 UTC 2009


   Hi Roman,

   I think you also need to move the 'policy' file from the closed dir along 
with the test.

   Thanks,
     Dmitri


Roman Kennke wrote:
> Hi Phil,
> 
> Am Montag, den 30.11.2009, 13:37 -0800 schrieb Phil Race:
>> Roman Kennke wrote:
>>> I added the (previously closed) testcase, keeping it in the same
>>> relative directory location:
>>>
>>> http://cr.openjdk.java.net/~rkennke/6888734/webrev.01/
>>>
>>> Is this ok?
>>>   
>> Almost. Reg tests don't have the classpath exception.
> 
> Fixed.
> 
>> And probably the copyright year should be a range, starting
>> with whatever the existing year is.
> 
> This file is added to the closed repository in 2007, with the initial
> commit, it doesn't say anything how old this file is. I put it in
> OpenJDK in 2009, this is why I say so in the header. What else can I do?
> 
> Also, we need one more review, Igor, can you have a look?
> 
> http://cr.openjdk.java.net/~rkennke/6888734/webrev.02/
> 
> Thanks, Roman
> 
> 
> 



More information about the 2d-dev mailing list