[OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

[Mario Torre]

Hello all!

While hacking on Cacio I've found that SunGraphics2D exposes a reference
to "this" inside the constructor to another class, while initialising a
field that contains the RederingLoops.

I filed a bug report and proposed a patch for review:

https://bugs.openjdk.java.net/show_bug.cgi?id=100068

The webrew is here:

http://cr.openjdk.java.net/~neugens/100068/webrev.01/

There is not much to say about the rationale for the bug/fix, just that
the code looks a bit borked to me with those public references (there
are others around, I think I should fix them all at some point), but the
real problem is indeed exposing "this" in the constructor.

I hope I did the webrew correctly, as I had other patches around and no
patch queue on this tree (yeah, yeah, I know...) so I had to do some
manual tricks to make webrew happy, but the patch should be complete.

I tested with all the swing apps that come with OpenJDK, as well as
those two nice things:

http://java.sun.com/products/java-media/2D/samples/index.html

I'll bug you every day if you make me wait too much about that review :)

Have fun,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/