[OpenJDK 2D-Dev] Review Reqeust for Bug 100068 - SunGraphics2D exposes a reference to itself while non fully initialised

[Mario Torre]

Il 18/06/2009 21:52, Jim Graham ha scritto:

> One solution would be to always set the loops for the validations that
> install one of these pipes. That could have potential performance
> impact, but it would be no worse than the validation sequences that
> already set the loops every time so I don't think it would be serious,
> or even measurable.

Hi Jim,

I'm trying this approach.

Basically, I just set the loops to null now in invalidate and validate 
them back in validatePipe:

http://cr.openjdk.java.net/~neugens/100068/webrev.03/

What I do is to get valid Loops when we call getTextPipe, but other than 
that, the behavior is basically unchanged. I tried with various 
applications, including NetBeans, the Java2D demo and the FontTest app, 
playing around with the text configurations (AA, LCD, size, Glyphs etc.. 
even output to a PNG file) and looks good, but I may miss something of 
course.

I moved to a 64 bit machine, I don't think this makes any difference in 
this case, but maybe it's a good thing to say.

I would like to see a method in the pipelines that does something like:

boolean mustInitialiseLoopsBecauseWeReallyWantToUseThemGranted()

or so, that we may call at the end of the validatePipe method, but when 
I tried this I got a funny StackOverflowException, maybe I did something 
wrong, but looks like it's not so easy to change this code and still 
make it behave correctly, so I would like to go deeper in this issue 
even if you think we can close the bug (of course if the proposed fix is 
evaluated as complete).

Cheers,
Mario
-- 
Mario Torre, Software Developer, http://www.jroller.com/neugens/
aicas Allerton Interworks Computer Automated Systems GmbH
Haid-und-Neu-Straße 18 * D-76131 Karlsruhe * Germany
http://www.aicas.com   * Tel: +49-721-663 968-44
pgp key: http://subkeys.pgp.net/ PGP Key ID: 80F240CF
Fingerprint: BA39 9666 94EC 8B73 27FA  FC7C 4086 63E3 80F2 40CF

USt-Id: DE216375633, Handelsregister HRB 109481, AG Mannheim
Geschäftsführer: Dr. James J. Hunt

Please, support open standards:
http://endsoftpatents.org/