[OpenJDK 2D-Dev] Trying to understand changeset 1010:467e4f25965c for lcms

[Phil Race]

I recall that we refactored the patch to touch fewer of the littlecms
internals. This helped since just 4 days after that patch the littlecms
version was upgraded from 1.16 to 1.18. I'd be surprised if you have
only this patch and not the littlecms 1.18 patch. Maybe its 1.18
rather than this changeset that's the root of the problem.

FYI, the code in 6-open and jdk7 should now, I think, be identical.

-phil.

Andrew Haley wrote:
> I've been getting JCK failures in lcms, and it seems to be down to
> this changset:
> 
> changeset:   1010:467e4f25965c
> user:        avu
> date:        Fri Mar 20 20:05:22 2009 +0300
> summary:     6733501: Apply IcedTea little cms patches
> 
> The bug points to the webrev at
> http://mail.openjdk.java.net/pipermail/2d-dev/2008-August/000413.html
> but the change that actually got committed was quite different to
> Joe's webrev.  I can't find any bug or webrev for this subsequent
> change, nor can I tell from the hg log who approved it.
> 
> It seems that the patch from IcedTea was substantially changed
> before being committed.
> 
> Andrew.